From 2d62759f6cb3cc6c8f529f473f7036f0b2d10e7a Mon Sep 17 00:00:00 2001 From: Fiona Ebner Date: Fri, 6 Dec 2024 17:25:45 +0100 Subject: [PATCH] backup: parse backup hints: use volume format from storage layer Avoid using the extension based qemu_img_format() helper. Failure is not critical, because this is just the hint for what format the restored target image should be allocated with, so fallback to 'raw'. Signed-off-by: Fiona Ebner --- PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm index e6cd8452..04ba6144 100644 --- a/PVE/QemuServer.pm +++ b/PVE/QemuServer.pm @@ -6825,7 +6825,7 @@ my $parse_backup_hints = sub { my ($storeid, $volname) = PVE::Storage::parse_volume_id($drive->{file}); $storeid = $options->{storage} if defined ($options->{storage}); my $scfg = PVE::Storage::storage_config($storecfg, $storeid); - my $format = qemu_img_format($scfg, $volname); # has 'raw' fallback + my $format = eval { checked_volume_format($storecfg, $drive->{file}) } // 'raw'; $check_storage->($storeid, $scfg); # permission and content type check