proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-08 04:14:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Refactor snapshot_create to match LXC.pm

Browse Source
This commit is contained in:
Fabian Grünbichler 2016-02-24 12:33:31 +01:00 committed by Dietmar Maurer
parent 5be9e3104a
commit 2d3caa008c
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
PVE/QemuServer.pm
View File

@ -6160,6 +6160,17 @@ sub qga_check_running {
return 1; return 1;
} }
sub check_freeze_needed {
my ($vmid, $config, $save_vmstate) = @_;
my $running = check_running($vmid);
if ($save_vmstate) {
return ($running, $running && $config->{agent} && qga_check_running($vmid));
} else {
return ($running, 0);
}
}
sub snapshot_create { sub snapshot_create {
my ($vmid, $snapname, $save_vmstate, $comment) = @_; my ($vmid, $snapname, $save_vmstate, $comment) = @_;
@ -6169,19 +6180,16 @@ sub snapshot_create {
my $config = load_config($vmid); my $config = load_config($vmid);
my $running = check_running($vmid); my ($running, $freezefs) = check_freeze_needed($vmid, $config, $snap->{vmstate});
my $freezefs = $running && $config->{agent} && qga_check_running($vmid);
$freezefs = 0 if $snap->{vmstate}; # not needed if we save RAM
my $drivehash = {}; my $drivehash = {};
eval {
if ($freezefs) { if ($freezefs) {
eval { vm_mon_cmd($vmid, "guest-fsfreeze-freeze"); }; eval { vm_mon_cmd($vmid, "guest-fsfreeze-freeze"); };
warn "guest-fsfreeze-freeze problems - $@" if $@; warn "guest-fsfreeze-freeze problems - $@" if $@;
} }
eval {
# create internal snapshots of all drives # create internal snapshots of all drives
my $storecfg = PVE::Storage::config(); my $storecfg = PVE::Storage::config();
@ -6234,7 +6242,7 @@ sub snapshot_create {
if ($err) { if ($err) {
warn "snapshot create failed: starting cleanup\n"; warn "snapshot create failed: starting cleanup\n";
eval { snapshot_delete($vmid, $snapname, 0, $drivehash); }; eval { snapshot_delete($vmid, $snapname, 1, $drivehash); };
warn $@ if $@; warn $@ if $@;
die $err; die $err;
} }