proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-29 20:58:54 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #2175: PVE/API2/Qemu: update_vm_api: check old drive for permissions too

Browse Source 
otherwise a user with only VM.Config.CDROM can detach a disk from a VM
by updating it to a cdrom drive

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This commit is contained in:
Dominik Csapak 2021-06-24 16:25:11 +02:00 committed by Thomas Lamprecht
parent bb660bc3ce
commit 2c44ec4974
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
PVE/API2/Qemu.pm
View File

@ -1346,6 +1346,12 @@ my $update_vm_api = sub {
my $arch = PVE::QemuServer::get_vm_arch($conf); my $arch = PVE::QemuServer::get_vm_arch($conf);
if (PVE::QemuServer::is_valid_drivename($opt)) { if (PVE::QemuServer::is_valid_drivename($opt)) {
# old drive
if ($conf->{$opt}) {
$check_drive_perms->($opt, $conf->{$opt});
}
# new drive
$check_drive_perms->($opt, $param->{$opt}); $check_drive_perms->($opt, $param->{$opt});
PVE::QemuServer::vmconfig_register_unused_drive($storecfg, $vmid, $conf, PVE::QemuServer::parse_drive($opt, $conf->{pending}->{$opt})) PVE::QemuServer::vmconfig_register_unused_drive($storecfg, $vmid, $conf, PVE::QemuServer::parse_drive($opt, $conf->{pending}->{$opt}))
if defined($conf->{pending}->{$opt}); if defined($conf->{pending}->{$opt});