proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-02 13:30:18 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

memory: replace deprecated check_running() call

Browse Source 
PVE::QemuServer::check_running() does both
PVE::QemuConfig::assert_config_exists_on_node()
PVE::QemuServer::Helpers::vm_running_locally()

The former one isn't needed here when doing hotplug, because the API
already assert that the VM config exists. It also would introduce a
new cyclic dependency between PVE::QemuServer::Memory <->
PVE::QemuConfig with the proposed virtio-mem patch set.

In preparation to remove the cyclic include of PVE::QemuServer in the
memory module.

No functional change intended.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
This commit is contained in:
Fiona Ebner 2023-09-04 13:39:47 +02:00 committed by Thomas Lamprecht
parent 0e32bf5bc2
commit 2951c45ec0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
PVE/QemuServer/Memory.pm
View File

@ -175,7 +175,7 @@ sub foreach_dimm{
sub qemu_memory_hotplug {
my ($vmid, $conf, $defaults, $value) = @_;
return $value if !PVE::QemuServer::check_running($vmid);
return $value if !PVE::QemuServer::Helpers::vm_running_locally($vmid);
my $sockets = $conf->{sockets} || 1;