proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2026-01-26 23:51:55 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #2367: do not allow snapshot with name PENDING

Browse Source 
or any other variant of the word 'pending'.

note that we can actually allow this snapshot after PVE 7.0, since
pending section and snapshots will be properly namespaced.
([pve:pending] and [snap:$snapname] or similar).

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
This commit is contained in:
Oguz Bektas 2019-10-24 13:53:09 +02:00 committed by Fabian Grünbichler
parent 045749f2fc
commit 15c6e277a4
1 changed files with 4 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
PVE/QemuServer.pm
View File

@ -2740,7 +2740,10 @@ sub write_vm_config {
&$cleanup_config($conf->{pending}, 1);
foreach my $snapname (keys %{$conf->{snapshots}}) {
die "internal error" if $snapname eq 'pending';
# TODO: we can allow snapshots with name 'pending' after PVE 7.0
# since pending section is namespaced with 'pve:'
# but for now, we should forbid it to avoid confusion in parser
die "internal error: snapshot name '$snapname' is forbidden" if lc($snapname) eq 'pending';
&$cleanup_config($conf->{snapshots}->{$snapname}, undef, $snapname);
}