proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-19 19:42:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix #3588: helper: consider NIC count for config-specific timeout

Browse Source 
There have been some reports about `qm start` timeouts on VMs that have a
lot of NICs assigned.
This patch considers the number of NICs when calculating the config-specific
timeout. Since the increase in start time is linearly related to the number
of NICs, a constant timeout increment per NIC was chosen.

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
This commit is contained in:
Hannes Laimer 2024-11-26 15:52:38 +01:00 committed by Thomas Lamprecht
parent 0250b7f52f
commit 14374ab1bd
1 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
PVE/QemuServer/Helpers.pm
View File

@ -167,6 +167,15 @@ sub config_aware_timeout {
$timeout = 150;
}
# Some testing showed that adding a NIC increased the start time by ~450ms
# consistently across different NIC models, options and already existing
# number of NICs.
# So 10x that to account for any potential system differences seemed
# reasonable. User reports with real-life values (20+: ~50s, 25: 45s, 17: 42s)
# also make this seem a good value.
my $nic_count = scalar (grep { /^net\d+/ } keys %{$config});
$timeout += $nic_count * 5;
return $timeout;
}