proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-08-12 12:10:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

hugepages: fix memory size checking

Browse Source 
The codepath for "any" hugepages did not check if memory size was even,
leading to the code below trying to allocate half a hugepage (e.g. VM
with 2049MiB RAM would lead to 1024.5 2kB hugepages).

Also improve error message for systems with only 1GB hugepages enabled.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This commit is contained in:
Stefan Reiter 2019-10-28 14:30:41 +01:00 committed by Thomas Lamprecht
parent 331a5079e1
commit 062a7ea714
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
PVE/QemuServer/Memory.pm
View File

@ -402,10 +402,11 @@ sub hugepages_size {
if ($gb_exists && ($size % 1024 == 0)) { if ($gb_exists && ($size % 1024 == 0)) {
return 1024; return 1024;
} elsif (-d "/sys/kernel/mm/hugepages/hugepages-2048kB") { } elsif (-d "/sys/kernel/mm/hugepages/hugepages-2048kB") {
die "memory size must be even to use hugepages\n" if $size % 2 != 0;
return 2; return 2;
} }
die "your system doesn't support hugepages for memory size $size\n" die "your system doesn't support hugepages for memory size $size (1GB hugepages would be supported)\n"
if $gb_exists; if $gb_exists;
die "your system doesn't support hugepages\n"; die "your system doesn't support hugepages\n";