proxmox-mirrors/qemu-server
1
0
Fork 0
mirror of https://git.proxmox.com/git/qemu-server synced 2025-05-04 00:14:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

api: clone: mention "snapshot" in the error message if specified

Browse Source 
as it may be the only cause of the clone incompatibility

Example:
 # qm clone 101 102 --full --snapname foo

Before:
> Full clone feature is not supported for 'local-zfs:base-100-disk-2/vm-101-disk-2' (tpmstate0)

After:
> Full clone feature is not supported for a snapshot of 'local-zfs:base-100-disk-2/vm-101-disk-2' (tpmstate0)

Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
This commit is contained in:
Alexander Zeidler 2024-12-04 11:30:04 +01:00 committed by Fiona Ebner
parent a1140f00b9
commit 0250b7f52f
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
PVE/API2/Qemu.pm
View File

@ -3900,13 +3900,16 @@ __PACKAGE__->register_method({
$newconf->{$opt} = $value; # simply copy configuration $newconf->{$opt} = $value; # simply copy configuration
} else { } else {
my $volid = $drive->{file}; my $volid = $drive->{file};
my $msg = "clone feature is not supported for";
$msg .= " a snapshot of" if $snapname;
$msg .= " '$volid' ($opt)";
if ($full || PVE::QemuServer::drive_is_cloudinit($drive)) { if ($full || PVE::QemuServer::drive_is_cloudinit($drive)) {
die "Full clone feature is not supported for '$volid' ($opt)\n" die "Full $msg\n"
if !PVE::Storage::volume_has_feature($storecfg, 'copy', $volid, $snapname, $running); if !PVE::Storage::volume_has_feature($storecfg, 'copy', $volid, $snapname, $running);
$fullclone->{$opt} = 1; $fullclone->{$opt} = 1;
} else { } else {
# not full means clone instead of copy # not full means clone instead of copy
die "Linked clone feature is not supported for '$volid' ($opt)\n" die "Linked $msg\n"
if !PVE::Storage::volume_has_feature($storecfg, 'clone', $volid, $snapname, $running); if !PVE::Storage::volume_has_feature($storecfg, 'clone', $volid, $snapname, $running);
} }
$drives->{$opt} = $drive; $drives->{$opt} = $drive;