mirror of
https://git.proxmox.com/git/pve-manager
synced 2025-08-14 18:07:40 +00:00
6d727f81c8
under certain circumstances, the migrate button stays disabled, even when a valid target node was selected: * the first node that gets autoselected (most likely the second) is not a valid migration target * the user changes to a migration target that is a valid one if that happens, the migration button would stay disabled. switching once to a non valid target and would enable the button. To fix it, we have to do two things here: 'checkQemuPreconditions' is actually an async function that awaits an api call and uses the result to set the 'migration.allowedNodes' property 'checkMigratePreconditions' calls 'checkQemuPreconditions' and uses the 'migration.allowedNodes' property afterwards. but since 'checkMigratePreconditions' is not async, that happens before the api call can return the valid data and thus leaves it empty, making all nodes valid in the selector. (thus the initial selected node is valid) instead make 'checkMigratePreconditions' also async and await the result of 'checkQemuPreconditions' this unearthed another issue, namely we access an object that is possibly undefined (worked out before due to race conditions) so fallback to an empty object. and lastly, since we want the 'disallowedNodes' set before actually checking the qemu preconditions, we move the setting of that on the node selector above the qemu preconditions check (this is the only place where we set it anyway, and the source does not change, we probably could move that out of that function altogether) Signed-off-by: Dominik Csapak <d.csapak@proxmox.com> |
||
|---|---|---|
| aplinfo | ||
| bin | ||
| configs | ||
| debian | ||
| network-hooks | ||
| PVE | ||
| services | ||
| test | ||
| www | ||
| .gitignore | ||
| defines.mk | ||
| Makefile | ||
| spice-example-sh | ||
| vzdump-hook-script.pl | ||