when changing the guest os, we changed the disk type
(e.g. ide for windows, scsi for linux, etc.)
but if the id was outside the allowed range (e.g. > 3 for ide)
we did not correctly enable/disable tabs
now we check all tabs until the highest already visited,
or until we detect a not valid tab
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Proxmox.button.Help renamed the css class for the button styling, as
this class is only used rarely and the widget toolkit does not
provides a (shared) css file itself, just rename it here too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The current size was choosen with the older, more compact, classic
theme. The Crisp theme, now in use, has a bit more spaces and bigger
font sizes to adapt to the increased pixel density of current
displays.
Increase the size a bit (~13%) but try to keep the aspect ratio.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
with the commit
40342aa6c4
we introduced a validator on the guestidselector, but did not
notice that the wizard checks the validity on the field change event,
but the selector gets valid/invalid in an api callback(so a little later)
with this patch, we now validate the field correctly with validate()
and also listen on the validitychange event to catch it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Inside a wizard, switching to a new tab will fire
the 'activate' event to the new tab, causing
the inputPanel of this tab to display its help in
the wizard window.
we always checked the validity of the panels of the wizard,
when the event validitychange of a subelement triggered,
sadly this does not always happen
for example:
when switching back and forth between 'cdrom' and iso
while having no valid iso selected, the validitchange does not
trigger for the combogrids
instead we listen to the 'change' event, then the check will
be executed at the right time
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
disable_at() iterates over all the fields of the previously selected
tab and disables them
however disabling an input field makes it valid for validation purposes. I can't see a reason why disabling the tab fields
is needed, since the tab already hidden
and after testing, it seems safe to remove this call
this fix a problem when going back and forth in the wizard would
make some fields uneditable for the wrong reason
Without this, the summary grid in the end of the LXC creation
wizard needs to be scrolled to see some settings.
Note that we still want to use a fixed height, so that all wizard
panels have the same height and next/previous buttons
are always displayed at the same place.
