Commit Graph

23 Commits

Author SHA1 Message Date
Dominik Csapak
1011b56983 ui: fix missing htmlEncodes
username can include some special characters, so we have
to escape them

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-05-06 16:59:50 +02:00
Thomas Lamprecht
300c0f736b fix #2552: ui: allow to collapse notes panel from guest summary
Allow to collapse and expand the "Notes" panel on the virtual guests
summary panel.

Further add a browser setting to control the default behavior, one
can chose from:
 * expand on show (default)
 * collapse on show
 * collapse if there are no notes

This way users can make slightly better use of the available screen
space for the guest status.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Co-developed-by: Stefan Reiter <s.reiter@proxmox.com>
2020-01-14 11:13:42 +01:00
Thomas Lamprecht
6b6cd0e496 ui: settings: use default-value functionallity from state manager
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-01-10 15:50:59 +01:00
Dominik Csapak
f973c5b262 gui: let users choose the number of columns
introduce a new browser setting, with which the users can choose between
the automatic mode of choosing columns, or always using 1/2/3 columns

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Thomas Lamprecht
8cfcb41b00 ui: window settings: remove no-op onShow overwrite
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-23 18:20:56 +02:00
Thomas Lamprecht
9d6d8d8620 ui: window settings: use column layout
This change shouldn't be noticeable, main advantage is that we can
add a top or botton spanning row for hints or a save/restore feature
(in the future)

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-23 18:18:09 +02:00
Thomas Lamprecht
f5c68a74c7 ui settings: fix noVNC scaling mode radiogroup setValue
radio groups set and get Value helper are objects, as they are
expected to be key, value, where key is a field-name of the radio
group and values is the inputValue from the radiobutton to be set.

So ensure we extract only the value in the change event handler, as
we do not want to save the whole object. But on restoring (setValue)
we need to wrap it as object again, else radiogroup won't know what
field we want to set..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-21 15:20:22 +02:00
Thomas Lamprecht
94666c47dd ui: settings: remove ":" from some gettext labels
to make those easier to be re-used

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-21 11:31:09 +02:00
Thomas Lamprecht
a3c30fbca3 ui: settings/xterm.js: add margin between reset/save button
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-04 14:40:24 +02:00
Thomas Lamprecht
0ddacca181 ui: labelWidth gets px suffixed so auto won't work
This is a common mistake with widths in ExtJS, most of them have the
'px' unit implicit, so using things like 'auto' or '100%' does not
works with them.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-04 14:38:34 +02:00
Dominic Jäger
bd7aef8664 Harmonize reset buttons in "My Settings"
- Rename both buttons to a single word as it is clear where they belong
  to. Use "Reset" instead of "Clear" as you can rather "Reset a saved
  user name" than "Clear a layout".
- Use container instead of panels as they are simpler (e.g. no "border:
  false" necessary) and sufficient.
- Align the buttons at the right for visual appeal.
- Use title case for the user name label for consistency.

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2019-10-03 12:26:12 +02:00
Thomas Lamprecht
9a08bd8a27 browser settings: move reset layout button to same row as label
diff best viewed with git diff -w

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-09-04 15:14:09 +02:00
Thomas Lamprecht
98b14eb0ec browser settings: add tooltip to reset layout button
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-09-04 14:30:19 +02:00
Thomas Lamprecht
b89a26bcb8 vnc scaling: show setting in a single line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-09-04 14:30:01 +02:00
Dominic Jäger
26fcae336c Close #2262: Add noVNC scale setting
Add a setting to choose the scale mode of the noVNC pop-up as well as
the embedded console in the content panel to "My Settings". Having both
set to local scaling was the most important use-case for the users. One
setting for both places is the simplest solution making this possible.

The new section (fieldset) makes adding further options such as
"Local Cursor" easy.

Co-developed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2019-09-03 14:15:37 +02:00
David Limbeck
75ceae787d add help button to 'My Settings' window
link to 'gui_my_settings' in docs

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-14 15:46:44 +01:00
Dominik Csapak
2b0bdc4652 improve xtermjs settings button behaviour
we now put a form around the fields/buttons and can track
the valid/dirty state, and use this for setting the button states

now the buttons are correctly enabled/disabled when the form
is dirty/valid/empty

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-07-19 10:38:01 +02:00
Dominik Csapak
d9ace13c6c add xterm.js settings
this adds font-settings to the 'My Settings'
window and makes that bigger

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 09:42:55 +02:00
Thomas Lamprecht
672a6270ea use HelpButton from widget toolkit
Proxmox.button.Help renamed the css class for the button styling, as
this class is only used rarely and the widget toolkit does not
provides a (shared) css file itself, just rename it here too.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
e7ade592e3 use Proxmox.Utils instead of PVE.Utils
some function are now in Proxmox.Utils instead, so we have to use that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Emmanuel Kasper
61516423ad Improve a bit the esthetics of the User Settings window
* group the action buttons on the left, to distinguish them from the modal
 'close' button
 * display the action buttons as grey instead of blue, to be consistent
 with the rest of the GUI
2017-07-25 14:24:35 +02:00
Dominik Csapak
2488c226f1 add a storage selection in the settings window
this will be used to filter the dashboard storage graph to the selected
storages, so that one can choose which storages are relevant

e.g. if you have one nfs server with multiple exports (on the same filesystem),
you only want to count it once

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-12-22 10:11:13 +01:00
Dominik Csapak
ce11a8afd0 add 'my settings' to top bar
this adds a menu right to the username with an entry 'my settings',
this opens a window with (for now) browser specific settings
and a place to reset them

the plan would be to add password change, 2fa setup etc here

one remark: the reset layout button reloads the window,
to really apply the reset

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-28 09:46:25 +02:00