Commit Graph

15 Commits

Author SHA1 Message Date
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Dominik Csapak
c0d4a151fd ui: NodeSelector: check status field for offline nodes
the memory stat is not available if the user has no audit privilges on
/nodes/NODENAME but the status is always available

also it makes simple more sense to check if it is online not only if the
memory value is there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-05-09 16:30:22 +00:00
Thomas Lamprecht
56a353b9e7 use RestProxy from widget toolkit
Split PVE specific models, which where not moved to the general
widget toolkit, in a separate folder: data/models/

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
0fc95a12ee use ComboGrid from proxmox-widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:37 +01:00
Dominik Csapak
134b4017eb fix nodeselector when no element in the tree is selected
it can happen that nothing in the tree is selected,
then PVE.curSelectedNode is undefined, generating an exception there.
so we check if this is available

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-08-22 10:27:03 +02:00
Dominik Csapak
7c1150766d show nodeselector errors only if a node is selected
otherwise we get the error:

'Node seems to be offline'

if we do not have a node selected

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-03-09 10:53:58 +01:00
Dominik Csapak
e4ad4e064a validate nodeselector after store is loaded
this shows the validation status immediatly if no node is selected (for
instance because no node is online or you have only one node and open
the migration window)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-12-19 12:06:00 +01:00
Dominik Csapak
ce57c4a612 check for array in disallowednodes filter
extjs throws an error if disallowednodes is not an array,
so we need to check this

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-22 16:38:29 +01:00
Thomas Lamprecht
97ec0d0716 NodeSelector: add disallowedNodes configuration property
This can be used to mask out some nodes from the node selector.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2016-11-19 09:51:14 +01:00
Dominik Csapak
22f2f9d6c0 jslint: remove trailing commas
before ECMA5 trailing commas in arrays and objects
are forbidden

in jslint this is an error and cannot be deactivated

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:34 +02:00
Dominik Csapak
728f1b97e6 fix #143: add disk/mem percent sort
previously, we had a disk/memory usage column in the resource grid,
whose raw data were the bytes used, but we added a renderer
to display it as percentage

with this, the columns sorted by bytes and not by percentage,
which made the column rather confusing

with this patch, we add a real percentage column (where the
data is a float from 0 to 1) so it sorts correctly

also make the old columns show the used size in B/KiB/etc.
by default we still only show the percentage column

since the disk usage part was always zero with qemu guests,
leave it empty there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-20 09:36:23 +02:00
Dominik Csapak
fbf6e7b412 ext6migrate: fix NodeSelector
the intial value of the node selector is null,
but when the store is loaded, it becomes an empty array

this triggers the 'dirtychanged' event and causes
the edit windows to enable the OK/Submit Button,
even when no change is made

this fix sets the default value to an empty array,
which fixes the mentioned behaviour

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-08 11:25:57 +01:00
Emmanuel Kasper
9ccd656a61 load the store later, move non-dynamic properties and methods to class body
this fixes two problems:
 * we were loading the store before the parent ComboGrid class could put
  a listener on the load event
  * displayField must now be set in class body, take opportunity to move out
  what we can of the mega initComponent()

this two fixes allow the HA GroupEdit  Window to properly display the
existing members of a HA Group when editing group membership
2016-02-26 07:38:50 +01:00
Emmanuel Kasper
d46faa2c06 change xtype name to follow ExtJS and our own conventions
this also fixes the problem that the method
Ext.ComponentQuery.query() was outputting a warning
since it did not know if it should perform a  lookup
for a class name or a xtype
2016-02-26 07:37:29 +01:00
Dietmar Maurer
bac5bd135c rename manager5 to manager6 2016-01-22 11:24:10 +01:00