We have good command line completion and history with 'bash', so there is
no real need to duplicate this functionality.
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
The lxc CreateWizard ignores the pool setting. That makes creating
containers impossible for users who are restricted to using a pool. This
patch fixes that.
Signed-off-by: Andrew Neitsch <andrew@neitsch.ca>
username, password and domain name are all related, they are non-pve
options related to accessing the CIFS storage and have all influence
on the pveCIFSScan component.
So group at kleast user and password together. But keep domain on the
right for the sake of balance.
Move the content type selector to the right, as the RBD and other
panels do.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we ignore the password in the backend if no user is passed,
which can be very confusing for the user - or more important, me,
when testing cifs/storage stuff.
So change the mechanics slightly. Previously we changed the
allowBlank property of the password field if username was changed.
I set it to always required, but disable the whole field if we do not
have a username.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we have the defaults documented here, so set them here too
otherwise if the default change in PVE::Tools, we probably forget to
update the api description
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since letsencrypt updates their implementation to the ACMEv2 spec [1],
we should correctly parse the order status
1: https://community.letsencrypt.org/t/acmev2-order-ready-status/62866
note that we (for now) try to be compatbile to both versions,
with and without ready state, this can be changed when all letsencrypt
apis have changed
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
/usr/share/$(PACKAGE) is used for country.dat, installed
with -D
/usr/share/man/man1 is defined as $(MAN1DIR) in
defines.mk and already created in bin/Makefile where it is
actually used.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
we inherited the import from PVE::RESTHandler but may want to get rid
of it there. So explicitly import it here.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
else all non-root users get an empty dropdown box for the directories
and get no feedback why that is
with this, they can select it, but ultimately get an api error if the
permissions are not sufficient
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
We defined 'default' as fallback default value for the optional
pve-acme-account-name standard option but did not honored that.
Thus we got a perl error ($account_name not defined) if we did not
passed a name. Fix that by actually falling back to 'default' in this
case.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
