Commit Graph

2574 Commits

Author SHA1 Message Date
Dominik Csapak
df0875c20e gui: refactor {lxc, qemu}/Summary to panel/GuestSummary
they are both similar enough to have it only once

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Dominik Csapak
0545b2a560 ui: window/Restore: fixup unit conversion for bwlimit
vzdumps bwlimit is in KiB, so we have to tell our component that
and also remove the unnecessary multiplication with 1024
(the field previously returned the value in MiB)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
24c55f4143 ui: backup restore: add start-after-restore checkbox
Restore may be a long running operation, as it goes over the common
create API path we can reuse the "start after create" for a "start
after restore" for free.

Add this as hbox layout, as else it looks like a lot of wasted space
in the right side of the window, especially when restoring a CT
backup (were the "unprivileged" checkbox is additionally there).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
a331258a87 ui: backup restore: use new bandwith limit component
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
12d50fcd21 ui: add date column for backups in storage content view
main use case is to sort by date, e.g., I just re-created a cluster,
did some VM/CT backups on a NFS dump of mine which already had quite
some backups. Now, on restore I knew that only the backups made
yesterday were interesting, so a sort by date would allow me to find
them all easily, thus this patch was born.

Simple frontend extraction of information from the volid, for now
only for backups as there's the only case were we have the info at
all. Called the model entry "vdate" for "virtual date".

Mayb adding the creation date to all entries could be a nice addition
for the API someday.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
f1e9257274 ui: ha: drop unused pve-ha-resources model
we only have the unified pve-ha-status model now

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-03 14:29:51 +01:00
Thomas Lamprecht
105e575681 ui: ha: calculate service name in model to fix sorting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-03 14:29:36 +01:00
Thomas Lamprecht
2ae20617aa ui: ha: add name of service to resource grid
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 20:03:53 +01:00
Thomas Lamprecht
4b07ffdd1f ui: vm/hw: be more specific what VM state this is
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 18:14:33 +01:00
Thomas Lamprecht
59bce2875c ui: vm/hw: order VM state last and add extra warning
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 18:12:28 +01:00
Thomas Lamprecht
b2a5aa1812 ui: vm/hw: make extra message from deletion flexible
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 18:12:08 +01:00
Dominik Csapak
23dfddc637 gui: qemu/HardwareView: show vmstate and allow removal
so that a user can remove the 'suspended' state without resuming it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-30 17:50:10 +01:00
Thomas Lamprecht
736cffb1f9 follow bulk-migrate gui adaptions
show both, checkbox and hint in one row, there more horizontal space
than vertical.

s/Warning/Note/

default to on for convenience

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 16:24:53 +01:00
Tim Marx
3d62533052 ui: add checkbox to bulk migrate window to allow migration with local disks
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2019-11-30 15:25:18 +01:00
Thomas Lamprecht
d6896db530 ui: lxc: fix cmd menu separator hiding
use same condition boolean line as VMs have

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-30 14:39:25 +01:00
Oguz Bektas
b8f34731da add reboot button to right-click menu for VMs
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-30 14:31:22 +01:00
Thomas Lamprecht
6ddc083cb5 ui: dc/options: fix capabillities for u2f, bwlimits, ha settings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-29 15:20:32 +01:00
Fabian Ebner
5ef877b935 LXC: Disable resize button when volume is unusued
The size of an unused volume is not visible to the user and trying to resize
an unused volume runs into a 'parameter verification failed' anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-29 08:41:52 +01:00
Thomas Lamprecht
17a1ffa1b9 ui: dc/options: add onlineHelp to u2f and ha edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 19:35:17 +01:00
Dominik Csapak
7d01dad4ef gui: Bandwidth limits: increase labelWidth to 120
in some languages (e.g. German) the default (100) is too short for some labels,
resulting in cut-off text. We often use 120 in such cases, so we should
do here as well

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-27 18:40:30 +01:00
Dominik Csapak
f3c90a1d7c gui: UserView: show api call errors
otherwise, an api error leads to an empty UserView, and the user
wonders why no users show up

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-27 16:51:15 +01:00
Thomas Lamprecht
d837e79e39 fixup whitespace error
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:36:19 +01:00
Thomas Lamprecht
a89375f6a3 ui: dc/options: add bandwidth limit editor
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:25:51 +01:00
Thomas Lamprecht
56b14a54ea ui: add Bandwidth selector widget
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:24:46 +01:00
Thomas Lamprecht
481816075e followup: add intermediate directory index for sdn/zones
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:58:01 +01:00
Oguz Bektas
cef9b653ec lxc: disable remove button for pending resource changes
for a pending change, it's 'revert's job to do this. pressing remove
doesn't do anything and it might be confusing for users.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-26 17:06:27 +01:00
Thomas Lamprecht
61c2b43420 ui: dc/options: allow to set U2F
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:02:01 +01:00
Thomas Lamprecht
08e38f032d ui: printPropertyString: skip empty string values
This cannot work anyway, and it simplifies some editors for
format-string backed properties, like the upcoming u2f settings
integration.

If such a value was passed to the backend one would get:
> invalid format - missing key in comma-separated list property

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:00:29 +01:00
Dominik Csapak
009d20a811 gui: node network: enable apply config button
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-26 10:13:12 +01:00
Thomas Lamprecht
e86024b727 allow to set 'migrate' shutdown policy in datacenter options
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-25 19:54:44 +01:00
Thomas Lamprecht
ba3c982ed0 ui: lxc: switch reboot and stop button to match VMs
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-25 06:40:50 +01:00
Thomas Lamprecht
176a62d392 followup: vm QGA type: handle a explicit set virtio type
as else we'd show "Unknown" if one set the type explicitly to
"virtio", either over API/CLI or editing the configuration directly

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-20 20:45:30 +01:00
Matt Dunwoodie
5a6c563c06 Add 'type' option to AgentFeatureSelector
This adds an extra field to the AgentFeatureSelector that reflects the
change in qemu-server.

Changes since previous version:

 * Use map rather than if/else if/else for type display string.
 * Use Proxmox.Utils.unknownText for unknown type (should not occur with
   regular use).
 * Keep existing fields as boxLabel rather than fieldLabel, as they
   look crammed with fieldLabel.
 * Use __default__ for default option, to save space and replicate
   behaviour in other places.
 * Store option in advancedItems as it is a special case.

Even though the map only contains one item, it will be easily added to
in the future. There is only one item as there is no need to have a
string for "virtio" as it is not displayed because of __default__.

Signed-off-by: Matt Dunwoodie <ncon@noconroy.net>
2019-11-20 20:45:30 +01:00
Oguz Bektas
6aee12f1fc lxc: add reboot button
to right-click menu and dropdown menu

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-20 20:28:53 +01:00
Oguz Bektas
2f13fde351 lxc: refactor stop button
move stopBtn into shutdownBtn as a menu item.

we can remove the setDisabled() call for stopBtn near the end, since when
shutdownBtn is disabled, so is stopBtn.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-11-20 20:28:53 +01:00
Dominik Csapak
f36240c507 gui: pci passthrough: consider domain in PCISelector
but remove the default domain '0000' before sending to the backend,
and add it if no domain is given in the config

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-20 19:43:31 +01:00
Thomas Lamprecht
df598da578 ui: ceph/Services: do some housekeeping
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-16 14:31:31 +01:00
Aaron Lauterer
ff4d18e1b1 ui: vm opts: add hint for spice foldersharing
Spice foldersharing needs the webdavd daemon installed inside the guest.
This patch adds a hint to remind the user to install it in the VM.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2019-11-12 11:28:48 +01:00
Stefan Reiter
a202f65a95 gui: fix onlineHelp for join window
We have an entire chapter written about this, why not link it too.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2019-11-11 11:47:45 +01:00
Dominik Csapak
f9b633668f gui: lxc/MPEdit: save and use the mountpoint propertyString
this way, backend only settings do not get lost (like 'size', 'shared')
when editing in the gui

this was most obvious with the new pending options, as every time
we edited a mp, we lost its size, and even setting the options
to exactly the same as the originals, we still had the mp as
'pending', but without the size

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-06 21:12:35 +01:00
Dominik Csapak
e4e36020aa gui: qemu/HDEdit: use propertyStringSet helper
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-06 21:12:35 +01:00
Dominik Csapak
49dfba72c8 gui: Utils: add propertyString helper
this helper conditionally sets the given value to the given property
on the given object, optionally a different value

this is useful for our MP/HD Edit panels, where we set the options
of the drive/mp this way for every gui option we have

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-06 21:12:35 +01:00
Dominik Csapak
69f36699b6 gui: lxc/Resources: improve reload behaviour
reload when a new disk was added, and set the button status
on a reload

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-06 21:12:35 +01:00
Dominik Csapak
18f57a2319 gui: qemu/HardwareView: use builtin reload function
ObjectGrid (an ancestor of PendingObjectGrid) does already have
a 'reload' function which does exactly the same, so get rid
of the local one here

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-06 21:12:35 +01:00
Thomas Lamprecht
7a04ce2376 ui: dc/backup: add separators between panel buttons
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-06 19:56:33 +01:00
Thomas Lamprecht
a0fecb88ba ui: dc/backup: refactor and fix run-job-now
rather than reducing the total job count during execution (and that
not for all cases) do some checks first and pass only the known good
nodes to the for-each-node-POST-request loop, so we can omit all
checks there.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-06 19:55:43 +01:00
Stefan Reiter
448454ffcd ui: fix backup "Run now" with specific node selected
Previous behaviour was bugged and displayed "Node is offline" for all
non-selected nodes (only 1 can be selected at a time).

Also fix progress window to show correct number of nodes in backup job.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2019-11-05 07:26:45 +01:00
Thomas Lamprecht
417f904f78 ui: pending revert: detect parent pending grid automatically
but cache it to avoid frequent, potential costly, up() calls

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-30 15:49:31 +01:00
Thomas Lamprecht
3ee15859b2 ui: pending revert: rename baseurl config to apiurl
makes more sense and avoids confusion

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-30 15:48:33 +01:00
Thomas Lamprecht
591efb6725 ui: factor out pending changes revert button
makes no sense to have the, more or less, exact same 25 line method 5
times..

could be moved to widget TK, but that's for another time.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-10-30 11:48:03 +01:00