on the view destroy we have to stop the updatestore again,
they do not get cleaned up by a destroy because until they are stopped
the have a reference on themselves, which prevent a garbage collection
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
We need to set mixedversions also if
data.version.parts < view.maxversion
so lets do that.
This avoids a bug when the first version in the list already is the
highest one.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
New version including the cluster name didn't work in some languages,
e.g. german: "Beitreten 'cluster'" vs the correct "'cluster' beitreten"
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
this makes it closer to the OSD list, using the new 'version-only'
metadata api call
this partially fixes#2468
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of always expecting a '.' separated version string
we will use this for the 'structured' version data
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
so that we can choose to only include the versions and not all metadata
this is done to avoid having a seperate 'versions' api call
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
there's no caps.dc['Sys.Modify'] in our heuristic caps-for-frontend
and the === undefined check was wrong
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
if the webinterface got loaded the api call to check if SDN is
available did not yet returned, so we could show it by accident -
even if libpve-network-perl wasn't instralled.
Fix that by hiding it (once) in the failure callback of the API call.
also move menu entries below, before Firewall, this fits better to
networking.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
when a user is disabled, we do not touch any ACLs, and already issued
tickets are still valid (until their expiration time)
check directly after the verification of the ticket if the user
is still enabled, so that any api call fails for that user
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
So it has a more fixed position, independent of the column header
length. Also, this brings it nearer to the button where one can
adapt/turn off filters.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
by adding the icon 'fa-filter' (see fontawesome.css) after the column header
and making it slightly darker than the text
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
while this /could/ (not benched marked in any way) be slower it
operates on so small data sets that this isn't worth it having double
the code lines.
A map + join is still quite readable and not yet "code golfy"
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Slightly confusing with the units:
* Backend stores values in KiB/s
* Frontend displays MiB/s (which is a good choice when considering
current generation network speeds as opposed to huge KiB numbers IMO)
* Renderer previously showed no units, which would usually be interpreted
as Bytes/s
So add a pretty renderer that shows units and set backendUnit to submit
correctly converted values.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Warn the user when selecting /dev/random or disabling speed limits.
'hardware_counts' is used since technically more than one RNG could be
attached to a QEMU machine. It is limited to 1 however, since the
usefulness of such a setup is more than questionable, considering the
linux kernel only ever uses one hwrng at a time anyway.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
instead of having multiple regexes in various places for the name,
define a 'SERVICE_REGEX' in PVE::Ceph::Services, and use that
everywhere in the api where we need it
additionally limit new sevices to 200 characters, since
systemd units have a limit of 256 characters[0] (including suffix), and
200 seems to be enough.
users can now create ceph services on machines with hostnames
longer than 32 characters
0: https://www.freedesktop.org/software/systemd/man/systemd.unit.html
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the network and the cluster network are optional in the ceph config
and with 'pveceph init', so only check if we have an ip address
from those networks if it is actually configured
otherwise, the createosd call dies with an 'ip' error message
even if it would work
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
When a property description already contained an option, no standard
output options at all would be added to it, e.g. '/nodes/NODE/vzdump'
already defines its own 'quiet'. Now all not yet defined options are
added to the description, this is done by using the fact that we can
pass a explicit list of std options to add to
add_standard_output_properties, so we filter all already defined ones
out and just pass that as list.
Fixes
pvesh create /nodes/NODE/vzdump -vmid ID -storage STORAGE
issued from a different node and
pvesh create /nodes/NODE/vzdump -vmid ID -storage STORAGE --output-format json
and maybe other calls.
Reported here: https://forum.proxmox.com/threads/output-format-error-with-pvesh-create.47711/
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Similar to commit 12d50fcd21 which
added this column to the storage content grid let's also add it here.
As we also base off the 'pve-storage-content' it's just a matter of
copying over the column definition 1:1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Commit f36240c507 (gui: pci passthrough: consider domain in PCISelector)
used 'values.host' without checking if it's set, resulting in an error
when the dialog was opened for a new device (where values.host is
undefined).
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
To (re)start and stop Ceph services the API calls systemd units using the
function ceph_service_cmd. If unspecified, this function assumes the type
".target" for a unit. By making the unit type suffix in the API optional, it
can make use of this assumption.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
The default value for "pveceph start" and "pveceph stop" is "ceph.target".
However, omitting the parameter to use the default has been forbidden.
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
Show only links found on the cluster.
'enableColumnHide' is set to false, since it causes confusing behaviour
for the user, considering we'd overwrite part of their choices every 5
seconds.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
changing from Ext.Array.each to a for loop and changing the return
to a 'break', resulted in exiting the wrong loop (previously the outer,
now the inner) resulting in wrongly looping through all controllers
instead of only until we found a match
using a label and labeled break, we can break the outer loop
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
if no storage is selected in 'My Settings' our calculatin was done as follows:
* for every node, count 'local',
* every other storage gets only counted *once*, even if it is a local storage
as we have the 'shared' flag available, we can count local storages
for every node where they are defined which results in a storage total
calculation:
sum of all local storages on all nodes + all shared storages once
should make a better overview of storage for a cluster with local storages
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
