Commit Graph

3596 Commits

Author SHA1 Message Date
Aaron Lauterer
219293bd1d ui: CephInstall: fix a/an typo
and switch to template string

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-09-07 15:25:09 +02:00
Aaron Lauterer
f25c38553e ui: CephInstallWizard: make first mon node static
Removes the possibility to select the node on which to create the first
monitor in the configuration / initialization step and always sets it to
the current node.

This prevents that a user might select another node on which the Ceph
packages have not yet been installed. If a user did that, they would get
an error, but the Ceph config file would have been written. If the user
then does not select a valid node to create the first mon, but aborts
the wizard, they are greeted with a rados_connect error because the
config file exists, but it does not contain any mon infos that are
needed to connect to the Ceph cluster.

Creating a mon manually will remedy such a situation, but especially for
new users, this behavior is not ideal and confusing.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2022-09-07 15:25:09 +02:00
Fabian Grünbichler
dc17baee74 www: subscription: add Signed/Offline status
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Dominik Csapak
9c020707a0 ui: improve form/MDevSelector
by
* showing the (optional) name in front of the type
* making the 'availble' column a bit narrower
* enabling 'cellWrap' for the description
* making the dropdown a bit wider (so all the information can fit)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-08-12 14:04:49 +02:00
Thomas Lamprecht
bad1742cef ui: datacenter: use "Name" label for respective part of full rp
as contrary to the property name this is actually only the rather
irrelevant part (auth wise) of the whole relying party, the ID is the
other part, and that one actually matters.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-07-26 12:00:45 +02:00
Thomas Lamprecht
727b64aec3 ui: datacenter: rework webauthn settings UX
Make origin optional, as it actually is, and its not covered by the
challenge anyway.

Also, not the thing we name rp, but the ID is important for the
validity of existing webauthn records, this error comes from the
confusing use of the same named thing in different ways by browsers,
us and the webauthn rust crate...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-07-25 16:48:32 +02:00
Thomas Lamprecht
a707bed6dd ui: ct restore: put mountpoint-erasure note on new line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-07-07 10:08:02 +02:00
Fabian Ebner
5f855ccf27 ui: restore: improve warning for restoring container with same ID
It's not clear to users that the "VM data" includes mount point
volumes including those that are not marked for backup. This is
different from VM restore, where volumes attached at drives not
present in the backup will be kept around as unused volumes.

Several (supposedly newer) users got tripped up by this over the
years, the latest report being [0]. The long term plan is to make the
restore dialog more flexible to be able to select actions for disks
individually, but that will take a bit of time. In the mean time, make
the warning more explicit.

[0]: https://forum.proxmox.com/threads/111760/#post-482045

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-07-07 10:03:39 +02:00
Fabian Ebner
6a3052b299 ui: manual backup: unescape notes template on load
It's escaped in the API result and will be re-escaped upon submit,
leading to confusion as reported in the community forum:
https://forum.proxmox.com/threads/110747/post-480507

Fixes: c4dca88b ("ui: manual backup: also set notes-template default")
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-06-28 16:10:13 +02:00
Thomas Lamprecht
719e95c9a6 ui: ceph: add quincy installation support
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-06-21 16:52:35 +02:00
Dominik Csapak
9cd2e6382c ui: dc/Backup: add 'repeat-missed' checkbox
so that the users can configure how to handle missed job runs
move the vmgrid inside the ipanel in 'columnB', so that the
advanced items show below the vmgrid (not above)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
2022-06-17 17:21:56 +02:00
Aaron Lauterer
5f7f0095cb fix #3597: ui: ceph setup: avoid autofill of monitor network
By not auto filling the Ceph public network we can avoid accidental
clicks on 'Next' which will cause the first Mon to be created with a
potentially wrong network. While that is fixable, it is tedious and
can be easily avoided by making the user always select the network to
use.

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Tested-by: Stefan Hrdlicka<s.hrdlicka@proxmox.com>
 [ T: adapted commit subject to be more specific and match our common
   style ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-06-08 09:02:07 +02:00
Matthias Heiserer
0fe712de01 ui: qemu disk edit: fix typo in view model variable name
Worked before because we always set the correct one manually in the
view controllers init and scsi-controller change handler.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
 [ T: added actual subject and reworded commit message ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-28 09:15:13 +02:00
Fabian Ebner
c4dca88b5e ui: manual backup: also set notes-template default
like is done for other vzdump options already.

Requested in the community forum:
https://forum.proxmox.com/threads/108970/#post-468655

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-05-12 17:17:56 +02:00
Fabian Ebner
03875d7ac4 ui: manual backup: list possible template variables directly
rather than as a tooltip.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-05-12 17:17:56 +02:00
Thomas Lamprecht
1992003e00 ui: move new node options below hosts entry
avoid splitting the related DNS and Hosts settings in the middle

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-12 16:40:41 +02:00
Daniel Tschlatscher
5837726350 fix #3994: ui: add Options entry in the node System menu
Add the subentry "Options" in the "System" menu to expose some
options in the GUI which were not exposed before.

Added a new file for displaying and editing the node config options
which were not exposed through the GUI yet. Namely those are the
settings for wakeonlan and startall-on-boot-delay. Edited the
Makefile to include the newly created file.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
2022-05-12 16:38:07 +02:00
Daniel Tschlatscher
5ff695733f gui: VM Create wizard - display default scsi controller correctly
Fixed a cosmetic issue where in the VM creation wizard the SCSI
controller would not be displayed correctly if the default value
"Default (LSI 53C895A)" was selected. In this case, "__default__"
would be printed for the user after progressing into the next "Disks"
pane.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
2022-05-12 16:32:02 +02:00
Thomas Lamprecht
26f68e6534 ui: storage: add namespace support when creating PBS storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-12 15:07:38 +02:00
Thomas Lamprecht
c956508c7d fix # 4044: ui: hd move: avoid bogus progress bar, show task viewer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-11 16:23:11 +02:00
Matthias Heiserer
719f1d3c6f ui: disk reassign: remove unused reference and bind
They are not used anywhere else, so I assume they were left over from
an earlier version.
Also, sometimes "[object object] flashes in the Target Guest field
when opening the reassign window, with this removed it doesn't occur.

Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
2022-05-02 16:44:44 +02:00
Fabian Ebner
ab0616aacb ui: snapshot tree: warn that current state is lost when confirming rollback
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-05-02 15:46:36 +02:00
Aaron Lauterer
a73f844d71 ui: ceph pools: add pool type column
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2022-05-02 15:43:19 +02:00
Aaron Lauterer
1a04202598 ui: ceph pool edit: disable size and crush rule for erasure pools
They cannot be changed after pool creation for erasure coded pools

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
2022-05-02 15:43:15 +02:00
Dominik Csapak
2637f372fe ui: realm sync: let users set 'remove vanished options' independently
and label it correctly. The 'Properties' option was mislabeled,
it means 'remove vanished fields from synced users', not 'remove
fields from vanished users'.

So don't couple that with the 'Entries' option, and update the label
to convey the right meaning.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-05-02 15:28:27 +02:00
Thomas Lamprecht
5a912de3f3 ui: storage content: support filtering by notes for backups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-02 15:26:21 +02:00
Dominik Csapak
a9faeb43ad ui: dc/SyncWindow: realign to sync options
put the checkboxes in a fieldset and reuse their labels

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-04-29 14:23:30 +02:00
Thomas Lamprecht
7d72d62f9c ui: add virgl GPU to possible VGA drivers
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-28 16:36:31 +02:00
Fabian Ebner
34721757e7 close #438: ui: backup job: allow setting a notes-template for a job
Add a tooltip to the comment field, to better distinguish it from the
notes-template.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Co-authored-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-28 14:16:04 +02:00
Fabian Ebner
5e73ffe680 ui: backup: allow setting protected and notes-template for manual backup
Setting a width, so the text area can fill the horizontal space.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 13:45:53 +02:00
Fabian Ebner
7c8ff459a8 ui: util: add helpers for (un)escaping notes-template
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 13:45:53 +02:00
Fabian Ebner
b61d079afc ui: restore: fix syntax error introduced in previous commit
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 11:29:42 +02:00
Thomas Lamprecht
8ce4c52480 ui: restore overrides: switch from column to hbox+panel layout
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-28 11:12:19 +02:00
Fabian Ebner
6161093e26 ui: restore: display "Hostname" for container
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 10:45:17 +02:00
Fabian Ebner
c7f66bd038 ui: restore: group override settings in a fieldset
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 10:45:17 +02:00
Fabian Ebner
1ad2651202 ui: restore: allow override of some settings
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 08:43:36 +02:00
Fabian Ebner
47520da33a ui: restore: disallow empty storage selection if it wouldn't work
Namely, if there is a storage in the backup configuration that's not
available on the current node.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 08:43:36 +02:00
Thomas Lamprecht
47353b27df ui; datacenter options: add next-id editor
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-27 20:34:37 +02:00
Alexandre Derumier
fef32ce05c ui: sdn: zone evpn: delete exitnodes-primary if empty
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2022-04-27 10:35:15 +02:00
Dominik Csapak
a8e22a83ab ui: dont show '__default__' in renderer
with the recent rework of the render/maps/arrays, we now
show 'Default (__default__)'. Since '__default__' is only an internal
value in the gui, don't expose it by explicitely checking for it

in the other render functions it works already because we either construct
the text differently (console_map) or we check the result from
parsing (vga_driver)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-04-26 15:31:11 +02:00
Thomas Lamprecht
04f27b64d9 ui: realm sync: use fieldset for remove-vanished & ux/wording
Use fieldsets, which are just way nicer for grouping these things.

Disable the "remove properties" checkbox if we'd remove the whole
user anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-26 14:26:11 +02:00
Dominik Csapak
3e43739f57 ui: realm sync: replace 'full' and 'purge' with 'remove-vanished'
in default sync options and the sync window. We do this by exposing
the individual flags as checkboxes. We get the mapped value from the
backend so we do not have to handle 'old' values here.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-04-26 13:35:03 +02:00
Thomas Lamprecht
56148f253e ui: utils: drop some useles _array helpers, just use Object.entries
if we need to enforce ordering it may help to reintroduce them
though.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-26 09:07:14 +02:00
Thomas Lamprecht
b7004b4682 ui: utils: rework kvm-vga/keymaps and console-viewer schema handling
shave off some bloat

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-26 09:01:13 +02:00
Dominik Csapak
f3d8ca24b5 ui: Utils: remove unnecessary render_kvm_vga_driver
the 'value' here is already the rendered text, passing it through
render again does not make sense

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-04-26 08:32:48 +02:00
Dominik Csapak
dd8b3252af ui: fix adding hostpci > 5
by using the limits from PVE.Utils

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2022-04-25 18:22:24 +02:00
Thomas Lamprecht
c8e171a8bd ui: vm display: refactor and cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-24 12:03:34 +02:00
Thomas Lamprecht
70aaf893b8 ui: backup restore: add hint to window title on overwrite restore
we prompt for confirmation in that case anyway, but some subtle, but
extra difference may still help

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:46 +02:00
Thomas Lamprecht
0e593799aa ui: backup restore: show "make unique" field also for self-overrride-existing
For example, relevant if the filterVMID checkbox got turned off. But
a user may also want to make the restored VM unique in other cases
too.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:45 +02:00
Thomas Lamprecht
ce60366ff3 ui: backup restore: use displayEdit field for guest selector
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:27 +02:00