to match the recently change in the container backend
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Editing an existing interface with DHCP set showed the emptyText
"None", which is confusing (and wrong)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this way it is more clear that leaving that field empty results in
no configured ip for that interface, this may help prevent
users to select 'dhcp' for e.g. ipv6 when they do not want an ipv6
and do not have a dhcp6 server in the network (which would result
in a long boot time of the container, because of the dhcp timeout)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
using the better View, ViewModel, Controller style,
while doing this, make it generic so that we can use it for qemu and lxc
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
using an Proxmox.window.Edit, which does many of the things we did
manually, also rewrite is in such way that we can use it for qemu
and lxc
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Same as with previous QEMU patch, avoids manual reload after starting a
container while the "Console" window is open.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
This patch enables the backup checkbox by default for newly created
LXC mount points.
Hopefully this will help to avoid situations in the future where people
realize too late that the mount point has not been backed up when they
expected it to because they missed the checkbox.
The reason why `view.isCreate` is not passed directly is because
AFAIU the 'view.isCreate' can have one of three values:
* null - editing an existing mount point
* true - creating a new mp
* array('unusedX') - adding an unused disk again
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
The size of an unused volume is not visible to the user and trying to resize
an unused volume runs into a 'parameter verification failed' anyways.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
for a pending change, it's 'revert's job to do this. pressing remove
doesn't do anything and it might be confusing for users.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
move stopBtn into shutdownBtn as a menu item.
we can remove the setDisabled() call for stopBtn near the end, since when
shutdownBtn is disabled, so is stopBtn.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
this way, backend only settings do not get lost (like 'size', 'shared')
when editing in the gui
this was most obvious with the new pending options, as every time
we edited a mp, we lost its size, and even setting the options
to exactly the same as the originals, we still had the mp as
'pending', but without the size
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
makes no sense to have the, more or less, exact same 25 line method 5
times..
could be moved to widget TK, but that's for another time.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
adds the pending button for Resources, Options and DNS screens.
Co-developed-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
uses the new /pending and the adapted /config API endpoints
to get pending changes and show them in a PendingObjectGrid
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
They should not be required and result in exceptions thrown if this
component is used in combination with ExtJS debug sources
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
having this new selector on the left column makes it a better fit for
both possible edit situations, rootfs is now fully balanced and both
mp/rootfs kip the "skip replication" setting on the same place - in
sync with VMs
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This allows the following non-problematic mount options for lxc
container mountpoints:
* noexec - Do not permit execution of binaries on the mounted FS
* noatime - Do not update inode access times on this filesystem
* nosuid - Do not allow suid or sgid bits to take effect
* nodev - Do not interpret character or block devices on the FS
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
While for now you only have elements which require the add disk
capability in the add sections it makes no sense to hide it, as it
would suggest that one can add no resource at all, and can easily
introduce a bug if we add another type of resource here, independent
of disk add cap.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
While we can allow them via the apparmor profile, they still
won't be usable as the kernel doesn't have FS_USERNS_MOUNT
set on those.
Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Tested-by: Dominik Csapak <d.csapak@proxmox.com>
We want to name an example here, so `e.g.` would be better.
Also show that in the field if empty. No changes to gettext stuff.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
