Commit Graph

54 Commits

Author SHA1 Message Date
Thomas Lamprecht
75cac2797f perlcritic fixes
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-10-22 18:18:35 +02:00
Thomas Lamprecht
7b74b60a49 5to6: cleanup cert check and make more general
If we need to add other types or increases the min size this makes it
easier as it's just a schematic definition.

Also just do a pass/fail on each cert, so drop the last "summary
pass".

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-23 09:46:55 +02:00
Alwin Antreich
91bebedbd0 pve5to6: cert: check certificates key size
Debian Buster raised the default security level (1 -> 2) for TLS
connections.

This moves from the 80 bit security level to the 112 bit security level
and will require 2048 bit or larger RSA and DHE keys, 224 bit or larger
ECC keys, and SHA-2.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2019-07-23 08:16:55 +02:00
Dominik Csapak
8be1b3ba95 pve5to6: check for ceph-volume osds
do not warn in case there exist nautilus osds
since the upgrade has to be done by the time a user should add new
osds, it does not make sense to warn in that case

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-15 17:09:27 +02:00
Fabian Grünbichler
82662dc83a 5to6: make corosync totem checks more verbose
to avoid just printing the subheader with no results

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-08 10:44:41 +02:00
Fabian Grünbichler
a2e5aa4e3e 5to6: add more corosync subheaders
to improve readability

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-08 10:44:41 +02:00
Fabian Grünbichler
d1dcb3e96e 5to6: fail if a corosync node has neither ring0 nor ring1 defined
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-08 10:44:41 +02:00
Fabian Grünbichler
b481d354c8 5to6: reword/-structure corosync message
and fix a typo as well

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-08 10:44:41 +02:00
Fabian Grünbichler
0e78b5157e 5to6: attempt to resolve corosync rings
and only fail if unable to

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-08 10:44:41 +02:00
Thomas Lamprecht
99181ca860 5to6: only tell to solve problems if fails are present
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 15:32:35 +02:00
Thomas Lamprecht
c50590ef72 5to6: improve final note on errors and/or warning a bit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 15:30:54 +02:00
Thomas Lamprecht
0e788b3e07 5to6: fiy typo: s/detailled/detailed/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 15:23:19 +02:00
Thomas Lamprecht
3724703551 5to6: check common services pveproxy pvedaemon pvestatd
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 15:20:28 +02:00
Thomas Lamprecht
14886691a2 5to6: add log_systemd_unit_state and use for pve-cluster and corosync
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 15:20:28 +02:00
Thomas Lamprecht
bd6a59c2d3 5to6: import run_command
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 14:56:50 +02:00
Thomas Lamprecht
5c420879bf 5to6: clarify "cluster quorate" message a bit
As this is the state from the pmxcfs

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 14:21:10 +02:00
Thomas Lamprecht
23a60185fb 5to6: fixup: really set $total_votes to 0 if not defined
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 14:20:41 +02:00
Fabian Grünbichler
6ab8927e85 5to6: drop detailed quorumtool output
since we already print most of that anyway, and it is rather long.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 14:06:13 +02:00
Fabian Grünbichler
82fd088c0d 5to6: more quorum / vote checking
handle expected votes set to non-standard value, and try to adjust
calculations for qdevice setups.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 14:06:13 +02:00
Fabian Grünbichler
5d54e2ee38 5to6: quote some Ceph flags/options
to improve readability

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 11:37:17 +02:00
Fabian Grünbichler
880563233c 5to6: check for ceph global keyring config
which causes issues after upgrading to Nautilus.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 11:37:17 +02:00
Thomas Lamprecht
60b81f16cf 5to6: followup: also detect ceph conf keys separated with -
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 10:37:35 +02:00
Thomas Lamprecht
f9f8cd7d01 5to6: ceph mon host check: switch config check from defined to hash values exist
we can get here if a empty (or one with just comments) ceph.conf
exists

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 10:31:08 +02:00
Thomas Lamprecht
780a57b6d1 5to6: ceph global mon host check: also detect mon-host
and adapt message a bit

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 10:30:39 +02:00
Dominik Csapak
38bd1ffc17 pve5to6: check ipv6/ipv4 settings in ceph.conf
having ipv6 enabled while not disabling ipv4 prevents
nautilus osds to start if no ipv4 network is given (because they
are trying to bind to both ip families and die if one of them
is not found)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-04 10:23:36 +02:00
Dominik Csapak
c553da9283 pve5to6: check ceph config for mon_host line
this already works on luminous, so it does not harm to add it already,
and is recommended when both msgr1 and msgr2 is activated in nautilus

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-04 10:23:36 +02:00
Fabian Grünbichler
a1687fd928 5to6: invert check for noout for nautilus
mainly because it looks strange to get a warning after the upgrade is
finished and noout has been removed again

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 09:36:48 +02:00
Thomas Lamprecht
3323207150 5to6: followup: still include nodename in IP check
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 09:36:48 +02:00
Fabian Grünbichler
6a494e2e47 5to6: reuse $nodename
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 09:36:48 +02:00
Fabian Grünbichler
6c9e9cc83f 5to6: improve some log messages
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 09:36:48 +02:00
Thomas Lamprecht
b8bdb17eb5 5to6: followup sheepdog message
do not suggest that we ever supported it as first class storage, it
was always just a experimental support and upstream is
EOL/unmaintained now.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-04 09:36:48 +02:00
Fabian Grünbichler
68f0d1611b 5to6: add check for configured Sheepdog storages
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-07-04 09:30:15 +02:00
Thomas Lamprecht
6deabaacf1 5to6: improve ceph warning on non OK state
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-03 13:14:28 +02:00
Thomas Lamprecht
b6c10c6392 pve5to6: be a bit more verbose for misc. checks
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-02 12:09:50 +02:00
Thomas Lamprecht
000acacacc pve5to6: followup: improve coding style and outputs a bit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-02 12:09:46 +02:00
Dominik Csapak
03f79391c0 pve5to6: list vms with active vmx/svm flag
list all vms with either max/host cputype or vmx/svm explicitely set
(this can only happen in the args)

give a general message if none is found at the moment (and do not warn)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-07-02 11:39:10 +02:00
Thomas Lamprecht
7d1b353b09 5to6: get_pkg: cache version list
this is a short running script, so the version list can be re-used,
the chance that there where updates in between are slim and racy
anyway. IF getting the versions did not succeeded, we still retry on
every call though, simpler and ensures a warning is printed in the
caller check vicinity.

Makes script noticeable faster.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-28 08:42:20 +02:00
Thomas Lamprecht
f034380db0 5to6: followup kernel version checks, make compatible with PVE 5
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-28 08:34:40 +02:00
Fabian Grünbichler
32526d275a 5to6: add check for scanned simple OSDs
only as a warning, since this will also trigger a Ceph health warning
and is easily recoverable.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-06-27 21:52:56 +02:00
Fabian Grünbichler
f8da12992b 5to6: add check for running kernel version
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2019-06-27 21:52:56 +02:00
Thomas Lamprecht
bacd0b0b0b pve5to6: improve is-node-IP active check
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 19:30:42 +02:00
Thomas Lamprecht
bc91ccac99 pve5to6: add total count in summary
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 19:23:05 +02:00
Thomas Lamprecht
1c6ac415c4 pve5to6: align summary counters
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 19:21:45 +02:00
Thomas Lamprecht
079d1188a0 pve5to6: list packages with updates in new line
with two spaces indentation, like apt does

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 19:15:39 +02:00
Thomas Lamprecht
f31c3e4a17 pve5to6: versions: detect if already upgraded
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 19:15:15 +02:00
Thomas Lamprecht
465b3ea2b0 pve5to6: add and use print_header
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 18:41:05 +02:00
Thomas Lamprecht
3f11a62cfa pve5to6: make this a simple CLI command
with this it's enough to call `pve5to6`, no (sub)command needed

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-27 18:04:32 +02:00
Mira Limbeck
e6191e3eab move check_kvm_nested call to check_misc
Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2019-06-27 17:37:39 +02:00
Mira Limbeck
0286a6598d pve5to6: add IP check to misc
Adds the same check we run in pve-cluster before joining a node to make
sure the hostname resolves to a configured IP.

Signed-off-by: Mira Limbeck <m.limbeck@proxmox.com>
2019-06-27 17:37:39 +02:00
Dominik Csapak
eb8bf43025 pve5to6: add check for nested kvm
this warns the user that he cannot live migrate VMs with svm/vmx to PVE6 when
the nested parameter of the kvm module is on

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-06-26 17:22:01 +02:00