The check for dkms kernel modules relies on the output of `dkms
status`. dkms command invocation will perform the following sanity
check:
```
if [ ! -e <(echo) ]; then
warn $"dkms will not function properly if /proc is not mounted."
fi
```
This check will however throw the following warning when SIGPIPE is
set to be ignored:
```
sbin/dkms: line 2497: echo: write error: Broken pipe
```
While only cosmetic, this can be confusing. Therefore, temporarily
enable SIGPIPE before calling dkms, restoring the originally setting
afterwards.
Reported-by: Alexander Zeidler <a.zeidler@proxmox.com>
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
Allow non-root users with the VM.Config.HWType privilege to configure
/dev/urandom & /dev/random as an entropy source for a VirtIO RNG device.
Users with the Mapping.Use privilege on the /mapping/hwrng ACL path may
also configure /dev/hwrng as an entropy source.
Signed-off-by: Filip Schauer <f.schauer@proxmox.com>
if the hardware/driver is capable, the admin can now mark a pci device
as 'live-migration-capable', which then tries enabling live migration
for such devices.
mark it as experimental when configuring and in the migrate window
also change 'hideComment' to 'globalEdit' and reverse the logic
(so hideComment => !globalEdit) to better reflect what it does now.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we now return the 'allowed_nodes'/'not_allowed_nodes' also if the vm is
running, when it has mapped resources. So do that checks independently
so that the user has instant feedback where those resources exist.
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this now takes into account the 'not_allowed_nodes' hash we get from the
api call. With that, we can now limit the 'local_resources' check for
online vms only, as for offline guests, the 'unavailable-resources' hash
already includes mapped devices that don't exist on the target node.
This now also includes unavailable storages on target nodes.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
by also providing the global config in assert_valid, and by also
adding the mdev config in the 'toCheck' object in the gui
For the gui, we extract the mdev property from the global entry, and add
it to the individual mapping entries, that way we can reuse the checking
logic of the other properties.
Reviewed-by: Christoph Heiss <c.heiss@proxmox.com>
Reviewed-by: Fiona Ebner <f.ebner@proxmox.com>
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
WWNs (WWIDs) are useful information for debugging setups where
multipath is not (correctly) set up, as the WWN reveals which block
devices point to the same LUN. The report currently does not provide
WWNs in such scenarios. There is a symlink for the WWN under
/dev/disk/by-id/wwn-*, but if there are multiple block devices with
the same WWN, the symlink just points to one of them.
Hence, add the WWN column to the lsblk output.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
Everywhere else (including in the Ceph documentation itself [0]) it is
spelled without a space in "metadata", so fix this lonely occurrence for
consistency.
[0] https://docs.ceph.com/en/latest/glossary/#term-Ceph-Metadata-Server
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
The current implementation is slightly misleading. When creating a
privileged container, the nesting checkbox is disabled but keeps its
current state. However, nesting is not enabled for privileged
containers even if the checkbox was set to true.
With this change, the nesting checkbox gets unticked whenever it is
disabled, making clear that the nesting feature will not be enabled.
Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
[TL: slight rewording of the commit message]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The description 'VZDump backup file' for content type 'backup' is
wrong for PBS and other future backup providers. Just use 'Backup' to
describe the content type everywhere and avoid confusion.
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
To avoid code duplication, a dedicated component with the xtype
pmxFingerprintField was added to proxmox-widget-toolkit which we are
now also using here.
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
We divide the layout into two columns in preparation for the
fingerprint field, as this is as long as two columns
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
[TL: touch up commit subject]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
by using 'localeCompare'.
Assume the files 'a', 'B' and 'c'. The current default sorting results
in :
'B'
'a'
'c'
(C collation)
With this patch we use locale dependent sorting, so the browser/client
setting controls how it's sorted. For example with english, the list
becomes:
'a'
'B'
'c'
Which makes it easier to visually search for specific entries.
Using the default settings here makes sense (so no explicit
'sensitivity' setting for example.), since that is whats most
expected per locale.
Also enable 'numeric' sorting, so 'foo10' is sorted after 'foo2' as
suggested by Fiona.
Interestingly, the initial sorter (via the 'sorters' property of the
store), cannot seem to reuse the sorter defined in the columns, so we
have to specify it twice, once for the initial sort and once when the
user clicks the column header.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The package ships a small helper executable for making it easier to
set up the NVIDIA vGPU driver.
Signed-off-by: Hannes Duerr <h.duerr@proxmox.com>
[TL: move from hard-dependency to recommends, adapt commit message]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The hash from which we query cpu metrics contains 'iowait' as well as
'wait'. The first one is the total amount of time that was spent
waiting on IO, the second one is the percentage of time spent on waiting
on IO in a certain time frame.
For the metrics returned by the /cluster/metrics/export endpoint we want
the second one.
Reported-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
Sometimes the desired migration network is not configured on any
network interfaces on the node. For instance, if there is a full-mesh
network the CIDR for the router IPs is not configured on any network
interface, but still a valid choice as migration network. This patch
fixes this by allowing users to additionally enter arbitrary CIDRs
into the field setting the migration network.
Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
to avoid interpreting html tags in the values.
When setting a tooltip via the `data-qtip` attribute, the contents
needs to be double-encoded. Ext.js internally uses `innerHTML` to
apply the generated HTML, which undoes one layer of encoding in case
of `data-qtip`.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
to avoid interpreting html tags in the values.
When setting a tooltip via the `data-qtip` attribute, the contents
needs to be double-encoded. Ext.js internally uses `innerHTML` to
apply the generated HTML, which undoes one layer of encoding in case
of `data-qtip`.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
it's not all fields, but many useful ones
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
When the network-get-interfaces API endpoint returns an error, the GUI
currently only displays "No network information" instead of the actual
error message. The reason is that `Ext.String.format` is applied to
`text` to fill in the error message, but the format string `text` does
not contain any tokens. Commit e7f07a2e ("show guest-agent provided ip
address in qemu summary"), which introduced the feature, added a
format string in a variable `msg`, but unintentionally did not use it.
The unused variable `msg` was then removed in 55ee6ba1 ("ui: eslint:
No unused or duplicate variables").
Fix error reporting by re-introducing and actually using the format
string. Also, htmlEncode the error message returned by the backend.
Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
So we show the value as they get sent by the backend, and not get
interpolated as html.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reported-by: Jens Krabbenhöft <jens@krabbenhoeft.net>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Since we already have the information from the API call, why not add it
as a (hidden) column. It can be useful to quickly see which ceph
applications are enabled for a pool in some situations.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
As else we trigger a change event for the size field which triggers
the sizeChange callback that then re-calculates the default size
suggestion, which might be lower as the value the user configured.
This was reported in the Forum for a 5/4 size/min-size configuration
that got reset to 5/3 on edit.
Report: https://forum.proxmox.com/threads/158798/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Most options come from the api call parameter list
(`json_config_properties`). The description and types for the remaining
ons are either taken from the manpages, source code or similar
documentation where available.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This fixes the error:
unknown permission test at /usr/share/perl5/PVE/RPCEnvironment.pm line 536. (500)
which occurred when trying to create or update a notification target.
The cause was a permission 'check' parameter for the API handlers
which was nested one level too deep by accident.
This regression was introduced in a previous commit which raised the
needed permissions for notification target management. It likely went
unnoticed because the permission check is skipped for root@pam, so the
error occurs only if using another user.
Reported in the community forum:
https://forum.proxmox.com/threads/158101
Fixes: a3fe9c54 ("api: notifications: require powerful privileges for target management")
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
[ TL: minor commit message touch ups ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Since tags are mostly free-form, a single tag with a numeric value will
get sent to influxdb as a number by default. Change that to always quote
the tags as a string, like we do for the 'name' field. (InfluxDB can
only have one type per field, so either a string or a number type).
This won't fix influxdb databases after there are already numeric values
in there, but I guess most tags won't be purely numeric, so this won't
be an issue for most users, and fixes the reverse case where purely
numeric tags won't show up in influxdb.
reported in the community forum:
https://forum.proxmox.com/threads/138004/#post-724127
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
We use the same icon in other similar buttons already, e.g. for copying the
TLS certificate fingerprint in PBS.
Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
