setting the background color in js code adds that property as a style
attribute to the element. that makes it hard to alter later via css
and makes it hard to dynamically change the color e.g. if we want to
add different themes. the background color for these elements are
white already anyway, so just remove them here.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
while it should not matter as we override submit() here, using the #
ensures that there never will be any HTTP request produced.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
such as the sorting/grouping of guests. saves them in the browser local
storage under 'pve-tree-sorting'
adds a button for it next to the the view selector
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Better fit to the 800 px default width, especially as bulk shutdown
now also got some form fields that take up space.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
It's not clear to users that the "VM data" includes mount point
volumes including those that are not marked for backup. This is
different from VM restore, where volumes attached at drives not
present in the backup will be kept around as unused volumes.
Several (supposedly newer) users got tripped up by this over the
years, the latest report being [0]. The long term plan is to make the
restore dialog more flexible to be able to select actions for disks
individually, but that will take a bit of time. In the mean time, make
the warning more explicit.
[0]: https://forum.proxmox.com/threads/111760/#post-482045
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
It's escaped in the API result and will be re-escaped upon submit,
leading to confusion as reported in the community forum:
https://forum.proxmox.com/threads/110747/post-480507
Fixes: c4dca88b ("ui: manual backup: also set notes-template default")
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
They are not used anywhere else, so I assume they were left over from
an earlier version.
Also, sometimes "[object object] flashes in the Target Guest field
when opening the reassign window, with this removed it doesn't occur.
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
Setting a width, so the text area can fill the horizontal space.
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
we prompt for confirmation in that case anyway, but some subtle, but
extra difference may still help
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
For example, relevant if the filterVMID checkbox got turned off. But
a user may also want to make the restored VM unique in other cases
too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this removes the NotesView panel and NotesEdit and replaces them with
with the version from the widget kit. requires a bump of the widget
toolkit.
Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
The form is basically a 1:1 copy from what the edit window gives us
for free already anyway, so just drop it.
best viewed with `git show -w`
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
in commit
07195aa079 ("ui: fix novnc scaling radio button")
we always set to 'scale' when no value was set, but a non-set value
actually had a different behaviour:
in the embedded console it was set to 'scale', but in the pop-up it was
set to 'off'.
to restore this behaviour, introduce an option 'auto' which unsets the
'novnc-scaling' setting
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when having selected 'off', the next start of the window has both
radiobuttons selected and no change is possible anymore. It seems that
the 'checked: true' triggers only after the 'init' function.
So instead remove the 'checked: true', and add the default in the init
function.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>