sortedList was defined twice in the function
remove the declaration at the beginning of function as declaring a var
just before using it is more similar to the rest of code
(this means: rtl8139 as nic and lsi as hardware controller)
XP & 2003 ISO E1000 drivers are missing or do not work with Qemu
(source: https://pve.proxmox.com/wiki/Windows_2003_guest_best_practices)
(source: https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes)
The lsi SCSI controller was the default SCSI controller until recently and works with Win2003.
(NB: An IDE controller is still selected during installation for these OSes)
The aim is to provide an out-of-the box besser experience when using the Create Wizard.
NB: we have a distinct OS type between wxp and w2k3 in QemuServer.pm but since they
use the same defaults we can still wxp for both of those.
we have cases, were the original value of a combobox is an array,
but not the current value
on reset, we get an error in Ext.Array.equals, because we
did not check if the current value is also an array
this patch fixes this
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This allows the setting and editing node priorities in HA groups.
Also fixes the bug where the priorities of an existing group (e.g.
set through the CLI) where deleted when editing said group through
the GUI.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
Add the getNodes function to the periodically asynchronous updated
PVEResource store. This allows a component to get the node data
directly, without making an API call and waiting that it's finished,
the data is also up to date.
A usage example would be:
var data = PVE.data.ResourceStore.getNodes();
var store = Ext.create('Ext.data.Store', {
fields: [ 'node', 'mem', 'cpu', ... ], // or a model
data: data,
proxy: {
type: 'memory',
reader: {type: 'json'}
},
...
});
I'll use it in a later patch to avoid two asynchrony store loads
where I'd have logic in place for the case that either one finishes
first, this function helps me to avoid such logic while achieving
the same functionallity.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
This is a complementary fix for #1105 (Create Linux VM Wizard: use scsi
as default bus/device) and add some logic to the list of controllers
presented in the ControllerSelector combo box
Since we can have IDE, SCSI, Virtio(blk) as a controller during installation,
based on OS detection and personal preferences, we can reasonably assume
on 80 % of cases it will be the same controller we want to use for the
next time we add a hardisk.
This allows backward compatibility for Linux guests which were proposed a
virtio-blk as first choice, and also helps newly created Linux VMs by proposing
SCSI.
instead of using
'/dev/${real_dev}'
we use the devpath property directly
also we skip the smart check in the cleanup
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of getting all disks, only get the info
from the one we get as parameter
and use the 'devname' value for the
ceph commands instead of the parameter itself
(this fixes the cciss!cXdY cciss/cXdY mismatch)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this is to make up for the lost width,
and to make up for the lost height, you
can now toggle the legend
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we introduced the vertical menus,
each panel is about 30px too wide for having
two side by side with a 1920x1080 resolution
this patch changes, the paddings/sizes so that
this fits again, at the cost of about 30 pixels width
per panel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in case the disk is not type ATA (e.g. SAS),
the smartctl output is not well parsable,
so we show the raw text instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
so that we can actually read the monitor name without resizing the
grid every time we visit, there is space enough
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
As some Makefiles in sub directories do not implement the distclean
target, namely:
PVE/Service/Makefile
PVE/CLI/Makefile
This target is broken.
As all other implementations just redirect to the 'clean' target I
do not implement the missing ones but rather remove all such
targets. Keep it just in the top level directory, for consistence
sake with other pve repos, and redirect it there directly to the
clean target.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Refresh the grid after the template has been downloaded, instead
of refreshing after the template has been selected.
this fix a the problem that a newly Turnkey / PVE downloaded template
would not be shown in the storage content grid after closing the task
window
instead of setting virtio-scsi for all newly created VMs, pass the
OS Optimal SCSI Controller to pveQemuCreateWizard which will
add it as an hidden paramater just before POSTing the wizard data
to the API.
