Commit Graph

4835 Commits

Author SHA1 Message Date
Thomas Lamprecht
68dc909220 ui/sdn: better spelling and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-22 15:06:45 +02:00
Alwin Antreich
485b2cd10a Fix: ceph: mon_address not considered by new MON
The public_addr option for creating a new MON is only valid for manual
startup (since Ceph Jewel) and is just ignored by ceph-mon during setup.
As the MON is started after the creation through systemd without an IP
specified. It is trying to auto-select an IP.

Before this patch the public_addr was only explicitly written to the
ceph.conf if no public_network was set. The mon_address is only needed
in the config on the first start of the MON.

The ceph-mon itself tries to select an IP on the following conditions.
- no public_network or public_addr is in the ceph.conf
    * startup fails

- public_network is in the ceph.conf
    * with a single network, take the first available IP
    * on multiple networks, walk through the list orderly and start on
      the first network where an IP is found

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-04-15 09:52:31 +02:00
Alwin Antreich
93bf658986 ceph: remove unused variable assignment
Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2020-04-15 09:52:31 +02:00
Fabian Grünbichler
f893dd34e3 d/control: bump pve-guest-common build-dep
since the log output verified in tests changed and the build fails with
the old version now.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-04-10 11:30:54 +02:00
Fabian Grünbichler
58d46211e5 test: s/expeted/expected
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2020-04-10 10:34:13 +02:00
Dominic Jäger
8b449830dd replication test: Add log rate and transport type
pve-guest-common got a new log line [0] for rate and transport type of a
replication. This line must be added to the replication tests.

[0] e90f586aab5caad4d4c5e18711316e8dc5225c07

Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2020-04-10 10:31:47 +02:00
Thomas Lamprecht
6d143cafd0 ui: node: lower statusStore interval outside of summary panel
We normally only use that information for the nodes power management
buttons, only the Summary panel profits from more frequent updates
(due to the uptime, and resource usage graphs).
So use 5s interval in general and switch to 1s for the summary panel
only.

This also fixes a bug where the node-config panel owned store got
stopped by mistake if the summary panel, which shared the use of that
store, was "destroyed" (left).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-09 17:06:52 +02:00
Thomas Lamprecht
6386068d0e ui: call more update store functions in the store scope
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-09 16:45:22 +02:00
Alexandre Derumier
30f5d4769c API2: Network: display vnets in any_bridge
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-04-08 19:58:44 +02:00
Wolfgang Bumiller
eacb5482e5 pvestatd: cgroupv2 support
This uses the newly introduced PVE::LXC::CGroup's
cpuset_controller_path() method to find the controller path,
so we need to depend on the newer pve-container package.

Signed-off-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
2020-04-04 20:19:02 +02:00
Thomas Lamprecht
5643ac475c ui: node/config: use simply boolean expression for powermngt check
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-03 07:01:25 +02:00
Thomas Lamprecht
23f14fd929 ui: cleanups and some s/var/let/ transformations
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-02 14:15:16 +02:00
Thomas Lamprecht
fde3e23dcd ui: ceph/ServiceList: do not autoLoad the rstore
The 'autoStart' triggers a initial load already

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-02 12:48:15 +02:00
Dominik Csapak
30f63e7df1 ui: ceph/ServiceList: do not autoLoad the updatestore
they load once anyway with 'autoStart'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 11:10:51 +02:00
Dominik Csapak
facf9404c5 ui: ceph/ServiceList: stop leaky versionsstores
on the view destroy we have to stop the updatestore again,
they do not get cleaned up by a destroy because until they are stopped
the have a reference on themselves, which prevent a garbage collection

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 11:10:48 +02:00
Dominik Csapak
732c147cf9 ui: ceph/ServiceList: correctly set 'mixedversions'
We need to set mixedversions also if
data.version.parts < view.maxversion
so lets do that.

This avoids a bug when the first version in the list already is the
highest one.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-02 09:00:03 +02:00
Stefan Reiter
943672c67f gui/cluster: fix translation for cluster join button
New version including the cluster name didn't work in some languages,
e.g. german: "Beitreten 'cluster'" vs the correct "'cluster' beitreten"

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-04-01 18:57:56 +02:00
Thomas Lamprecht
0beb2578ff ui: ceph: use displayfield with tooltip for overview version
And drop the git shorthash for now, albeit we could add it to the
tooltip..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 18:39:08 +02:00
Dominik Csapak
949a660920 gui: ceph: add highest cluster version in summary
so that the admin knows what the 'expected' ceph version is
partially fixes #2468

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
277d6d15e1 gui: ceph: icons for versions in ServiceList
this makes it closer to the OSD list, using the new 'version-only'
metadata api call

this partially fixes #2468

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
3a08795a5e gui: ceph: let compare_ceph_versions accept arrays directly
instead of always expecting a '.' separated version string
we will use this for the 'structured' version data

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
4602218730 ceph: add 'scope' parameter to metadata api call
so that we can choose to only include the versions and not all metadata
this is done to avoid having a seperate 'versions' api call

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Dominik Csapak
0496138e44 ceph: factor out get/broadcast ceph versions to ceph::services
which also removes some dead code
(the my $local_last_version variable was never used)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-04-01 17:15:41 +02:00
Thomas Lamprecht
59807d1e3b ui: fix optionview caps
there's no caps.dc['Sys.Modify'] in our heuristic caps-for-frontend
and the === undefined check was wrong

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 17:14:42 +02:00
Thomas Lamprecht
3d3199a6bf ui: user edit: use new pmxExpireDate field
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 17:14:42 +02:00
Thomas Lamprecht
1efbcdfad0 drop Makefile.rej rebase/am left over
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-31 18:07:33 +02:00
Thomas Lamprecht
17b777914a ui: rng edit: drop useless gettext for integer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-31 18:05:27 +02:00
Thomas Lamprecht
44f193c330 ui: cluster join: trigger defered call to full reload earlier
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 16:16:21 +01:00
Thomas Lamprecht
35ffde01f0 followup sdn: move a bit below and fix showing on initial load
if the webinterface got loaded the api call to check if SDN is
available did not yet returned, so we could show it by accident -
even if libpve-network-perl wasn't instralled.
Fix that by hiding it (once) in the failure callback of the API call.

also move menu entries below, before Firewall, this fits better to
networking.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 15:21:13 +01:00
Alexandre Derumier
12ae2ddd90 add sdn icons
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-26 12:17:53 +01:00
Alexandre Derumier
f1ca55fb03 sdn: enable SDN menu if /cluster/sdn api exist
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-23 14:43:29 +01:00
Alexandre Derumier
9233148bc1 add sdn gui
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-23 14:43:26 +01:00
Thomas Lamprecht
8660ae22c9 d/control: bump versioned dependency for ifupdown2
ensures we have the OVS and recent adaptions we rely on in ifupdown
installed

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-23 09:45:55 +01:00
Alexandre Derumier
a93e105209 API2: network reload: allow ovs reloading
ifupdown2 support it now

Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-23 09:44:41 +01:00
Thomas Lamprecht
e9af22b08d Revert "API2: Network: allow cidr-list && use cidr for address"
applied by mistake, needs compat code in common or the like

This reverts commit 3b82e4cf43.
2020-03-13 12:02:59 +01:00
Thomas Lamprecht
3d45fe518b followup: whitespace and indentation cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-12 17:44:26 +01:00
Moayad Almalat
5979889332 fix #2634: print specific error if hook-script is not executable
Signed-off-by: Moayad Almalat <m.almalat@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
2020-03-12 16:32:32 +01:00
Dominik Csapak
86f64e0d8b check if user is enabled after verifying a ticket
when a user is disabled, we do not touch any ACLs, and already issued
tickets are still valid (until their expiration time)

check directly after the verification of the ticket if the user
is still enabled, so that any api call fails for that user

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-03-12 15:36:00 +01:00
Alexandre Derumier
3b82e4cf43 API2: Network: allow cidr-list && use cidr for address
Signed-off-by: Alexandre Derumier <aderumier@odiso.com>
2020-03-12 15:33:12 +01:00
Thomas Lamprecht
dcd887f4c0 bump version to 6.1-8
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-09 19:05:18 +01:00
Thomas Lamprecht
ca0f293f74 ui: let grid column filter symbol float right
So it has a more fixed position, independent of the column header
length. Also, this brings it nearer to the button where one can
adapt/turn off filters.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-07 19:04:22 +01:00
Thomas Lamprecht
da5fb60947 css: move smilar filter rules closer together
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-07 19:03:50 +01:00
Dominik Csapak
29d84fce15 gui: make grid column filter more obvious
by adding the icon 'fa-filter' (see fontawesome.css) after the column header
and making it slightly darker than the text

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-03-07 18:50:36 +01:00
Thomas Lamprecht
df9ad35744 ui: dc/options: add max_workers setting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:42:16 +01:00
Thomas Lamprecht
27af8ed019 ui dc/options: refactor render_bwlimits
while this /could/ (not benched marked in any way) be slower it
operates on so small data sets that this isn't worth it having double
the code lines.

A map + join is still quite readable and not yet "code golfy"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:19:12 +01:00
Thomas Lamprecht
136103b0c9 ui dc/options: add trailing commas
just to avoid making those lines dirty again in a future property
addition..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:16:32 +01:00
Stefan Reiter
e670ffc28a fix #2611: gui: use backendUnit and pretty renderer
Slightly confusing with the units:
* Backend stores values in KiB/s
* Frontend displays MiB/s (which is a good choice when considering
  current generation network speeds as opposed to huge KiB numbers IMO)
* Renderer previously showed no units, which would usually be interpreted
  as Bytes/s

So add a pretty renderer that shows units and set backendUnit to submit
correctly converted values.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 19:56:49 +01:00
Dietmar Maurer
a4a86fe9b9 ui: ContentView: consider new ctime value
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 19:05:28 +01:00
Stefan Reiter
4ba4c7c616 qemu: change virtio-rng icon to die
'die' as in 'dice', not what Perl does

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 18:19:39 +01:00
Stefan Reiter
6c1d8ead7a qemu: add virtio-rng option to GUI
Warn the user when selecting /dev/random or disabling speed limits.

'hardware_counts' is used since technically more than one RNG could be
attached to a QEMU machine. It is limited to 1 however, since the
usefulness of such a setup is more than questionable, considering the
linux kernel only ever uses one hwrng at a time anyway.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 18:19:39 +01:00