This warns the user that the datacenter firewall is disabled when editing the
host or the VM/CT firewall status.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
type confusion: value is int and string
let is not recognized by our jslint version yet, so
use var for now
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
only show warning in migration window and when a running lxc container
is chosen
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Co-Authored by: Dominik Csapak <d.csapak@proxmox.com>
if we do not have a language cookie, try to read
the language from the datacenter.cfg and fall back to 'en'
also set it into the 'Proxmox' object, so that the gui can show it
in the LoginWindow
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we now put a form around the fields/buttons and can track
the valid/dirty state, and use this for setting the button states
now the buttons are correctly enabled/disabled when the form
is dirty/valid/empty
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Let user input MiB/s as values in the KiB/s range are not that handy
and would make even smaller backups need several hours to restore,
days for bigger ones.
Try to give the user imformation about per-storage bandwidth limits
and how he can disable all of them.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
so that we can reuse it for containers
while we do this, we also have to adapt the SnapshotSelector
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when changing the guest os, we changed the disk type
(e.g. ide for windows, scsi for linux, etc.)
but if the id was outside the allowed range (e.g. > 3 for ide)
we did not correctly enable/disable tabs
now we check all tabs until the highest already visited,
or until we detect a not valid tab
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Proxmox.button.Help renamed the css class for the button styling, as
this class is only used rarely and the widget toolkit does not
provides a (shared) css file itself, just rename it here too.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
there we implemented deleteEmpty, which we can use in some cases.
this also fixes a bug in the ControllerSelector where
an empty field would be allowed (but should not)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
commit:
551456ff6e
added the defaultButton property to the loginwindow, but we missed that
pressing enter in the passwordfield/userfield led to a double ticket
api call.
while it did not any harm, remove it, so that we only have a single
ticket api call
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Acked-by: Wolfgang Bumiller <w.bumiller@proxmox.com>
Fixes: 551456ff6e ("add defaultButton to loginWindow")
instead of heuristically choosing the onlineHelp entry from our first
item prefer the one we have in our config, if noone the fallback to
the old heuristic.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The current size was choosen with the older, more compact, classic
theme. The Crisp theme, now in use, has a bit more spaces and bigger
font sizes to adapt to the increased pixel density of current
displays.
Increase the size a bit (~13%) but try to keep the aspect ratio.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This checkbox had not effect whatsoever:
* if the VM was online and offline was selected, the migration would fail
with the message that the --online flag is needed for running VMs
* if the the VM was offline and online was selected, the migration would
happen offline anyway
we sometimes want to give the api call a parameter,
with this, we don't have to encode it into the url
everytime ourselves, but just give a 'params' object
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch does a few things
1. we introduce a new api call /nodes/nodename/ceph/rules
which gets us a list of crush rules
2. we introduce a new CephRuleSelector which is a simple combobox
with the data from the api call ceph/rules
3. we use this in the create pool window
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
* group the action buttons on the left, to distinguish them from the modal
'close' button
* display the action buttons as grey instead of blue, to be consistent
with the rest of the GUI
In a previous commit, the inputField of SafeDestroy.js was converted
from a numberfield to a textfield to allow ceph pools names to be
entered.
This means the type of 'value' changed from number to string and
the strong equal test === was failing against a numeric id.
To solve this, we now always stringify the resource id before comparing.
we have translated 'Target Node' already and I add a translation for
german and italian for 'Parallel Jobs' in the next translation update
patches.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this patch sets following defaults for the edit window:
defaultFocus: 'field'
sets the focus on the first field it finds in its child items,
works for most edit windows, so that the cursor stands in a
textfield, or on a checkbox
defaultButton: 'submitbutton'
so that when someone presses enter, we submit the form
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>