Commit Graph

294 Commits

Author SHA1 Message Date
Dominik Csapak
a33f612bcf gui: CmdMenu: rename suspend to paus
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-30 14:36:31 +01:00
Dominik Csapak
995a8ea2c6 gui: CmdMenu: hide the start and suspend button conditionally
only to disable them wastes space for no reason and might confuse users

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-30 14:36:31 +01:00
Thomas Lamprecht
11515a43dd followup: remove unnecessary references
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-03-28 17:53:30 +01:00
Thomas Lamprecht
c24fdb62b9 fix schema error: do not submit efidisk checkbox value
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-03-28 17:51:47 +01:00
Dominik Csapak
aae2273c61 gui: qemu/HardwareView: add machine to HardwareView
so the user can edit this via the gui

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
439d78210a gui: qemu/HardwareView: move scsihw and bios to HardwareView
it is guest hardware and not really an option, and we have it now
in the wizard, so it makes sense to have it here

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
755f4e5469 gui: qemu/HardwareView: remove Keyboard setting
this is deprecated and should not be necessary anymore, since
qemu and novnc can handle this better if no keyboard layout is set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
8d554444e6 gui: qemu/HardwareView: add space between groups
so that we can add items between them

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
471d03aa6b gui: add system panel to the vm creation wizard
for this we have to adapt the scsiController logic slightly, so that
the ostype change sets the viewmodel, which in turn changes the
bound fields (one one the system tab, and the displayfield on the hd tab)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
a1ee14a296 gui: add qemu/SystemEdit
contains the inputpanel for the coming system tab in the vm creation
wizard, where the user can configure the vm system hardware like
the scsi controller, display, etc.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
6a040799f4 gui: qemu/HardwareView: prepare Hardwareview for font-awesome icons
we want to be able to use fontawesome icons directly instead of having
to use extracted png in css classes

this patch makes it possible to use 'iconCls' with the font-awesome icon name

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-28 17:04:06 +01:00
Dominik Csapak
375d291810 gui: show lock in status bar of vms/cts
also add 'tbarSpacing' parameter to ConfigPanel, that controls
the spacing after the title

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-21 18:39:27 +01:00
Dominik Csapak
de63d77a3f fix #2132: gui: set vcpu default maxValue to 1
else one can set it to higher values if the vm has one socket with one core

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-15 13:50:07 +01:00
Thomas Lamprecht
97f7773b6c ui: qemu/cddrive: increase width for better ux
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-02-21 11:14:16 +01:00
Oguz Bektas
fc32524056 fix #2096: enable resume in context menu for guest triggered sleep
We act correctly for an outside triggered suspend, but if the guest
suspends itself from inside (e.g., systemctl suspend,
`echo "standby" > /sys/power/state` or windows sleep) it has another
state (suspended vs. paused), so handled that also

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:46:17 +01:00
Dominik Csapak
95f2a8a21a show hookscript in gui
only viewing, no editing
and show it only when it is set

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-31 11:05:55 +01:00
Dominik Csapak
89ae1bb151 gui: add virtio-gpu and none to combobox
since 'virtio' is alredy used in that file for a number,
we have to add jslint confusion

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-01-28 17:32:32 +01:00
Dominik Csapak
2b25a905ad do not send 'undefined' as romfile
when adding a pcidevice, we added 'romfile=undefined' by accident

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-12-05 14:25:24 +01:00
Dominik Csapak
25a1063ac7 gui: let users add PCI devices
this enables the gui part to enable the user to add a pci device
via the gui

we disable the button after 4 devices, since that is the maximum
in the backend

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-22 13:31:39 +01:00
Dominik Csapak
c59fb4eef5 gui: add qemu/PCIEdit
this patch adds the PCIEdit window and InputPanel uses PCISelector
and MDevSelector

when we detect an iommugroup of -1, we put a warning on top to inform
the user that IOMMU is not activated (but let him add the devices
regardless, so that he can use it after IOMMU is activated)

also puts a warning if he selects a device that shares an iommugroup
with a different device (but not the same device with different
function). that detection is not perfect, but we cannot do really
better

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-22 13:31:31 +01:00
Thomas Lamprecht
3097170dad ui: qemu/HW: menu setDisable mustn't ignore caps
We passed a 'disable' config to those menu items on creation, but
promptly ignored that after the first set_button_status call, which
only checked if it's possible to add another device, but not if our
capabilities heuristic is OK.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 08:40:15 +01:00
Nick Chevsky
75357e9f0d Enable "Discard" option for IDE and SATA drives
Even though QEMU supports the discard feature for both ATA [1] and
SCSI drives, the "Discard" checkbox in Proxmox VE is artificially
restricted to SCSI drives. This change expands availability of the
"Discard" checkbox to all drive types supported by QEMU, leaving
VirtIO Block as the only remaining exclusion.

Combined with the new "SSD emulation" option [2], enabling discard
on IDE/SATA drives allows reclaiming of free space on thin-provisioned
storage with guests that do not support our SCSI controllers.

[1] d353fb72f5
[2] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f9261fde2134cec35a5ec7c3ebbee5daa4d67ec7

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-14 09:21:12 +01:00
David Limbeck
793f2cf4e0 fix #1959: remove invalid SLAAC option
nocloud configuration does not support SLAAC option, only static or dhcp
so this option shouldn't be available

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-13 10:12:06 +01:00
David Limbeck
afa1997599 fix #1969: increase max unused disks
Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 16:51:56 +01:00
Dominik Csapak
4f3e66d89b gui: let users edit the vga memory
and show the default for each type of virtual gpu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-09 14:02:35 +01:00
David Limbeck
cbe0b4b834 fix sorting for unused disks in HardwareView.js
sort everything based on group and order for those with multiple numbered
entries

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 14:02:26 +01:00
Nick Chevsky
f9261fde21 Add "SSD emulation" property to IDE, SATA, and SCSI drives
When enabled, the "SSD emulation" feature exposes drives as
solid-state (rather than rotational) by enabling the new `ssd`
qm.conf flag [1] on the drives, which in turn sets QEMU's
`rotation_rate` property [2, 3] on the underlying devices.

This change also moves the "Discard" option out of the advanced
section and promotes it to the top of the dialog box, as proposed
by Thomas Lamprecht [4].

[1] https://git.proxmox.com/?p=qemu-server.git;a=commit;h=6c875f9f315f2dc7a0a3a988622c2efdf089b171
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1498042
[3] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00698.html
[4] https://pve.proxmox.com/pipermail/pve-devel/2018-November/034327.html

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
2018-11-09 09:33:26 +01:00
Tim Marx
3b2e557ff9 close #584: ui qemu: changed remove unused disk to asynchron call
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-10-18 13:26:15 +02:00
David Limbeck
cdf5bec2c9 fix #1884: vm/hardware: ensure correct value on pending changes
e.g., pending deletion of cdrom/dvd drive showed as hard disk in
hardware tab

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-08-24 11:24:38 +02:00
David Limbeck
eb273d60e5 fix #1872 Move button stays on the screen after closing 2018-08-20 14:42:27 +02:00
Stoiko Ivanov
1662ccdbfd ui/qemu: Extend Qemu Guest agent
Change to agent now being a property_string, and including  fstrim_cloned_disks.

Co-Authored-By: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
2018-08-02 16:20:12 +02:00
Thomas Lamprecht
d8e2ae9956 ui: add auostart after create checkbox
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-06-12 09:45:05 +02:00
René Jochum
fdce7d56ce Remove swap/memory limit in the Manager, fixes #1799 2018-06-07 13:44:21 +02:00
Dominik Csapak
abbf0eb74f let NotesView load itself
instead of needing to load from the outside, let NotesView handle the
loading itself

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
2283cff333 correctly update qemu ip information
we updated the status from the status store too often, so that
if the guest agent was not running, the message would
change between 'no information' and 'not running'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:44:05 +02:00
Dominik Csapak
203829c718 only show 'more' buttons for ips when there are actually ips to show
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:43:59 +02:00
Dominik Csapak
5fa6f3205a check for VM.Montior privileges on qemu AgentIPView
so that the user does not get the useless 'no information' or
'not running' message, but the real cause

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 10:43:47 +02:00
Thomas Lamprecht
d49d0443b8 ui: use cbind to make usb input panel static
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-18 15:39:54 +02:00
Thomas Lamprecht
37977fa500 ui: vm: allow to add socket backed serial devices
We show and can remove serial devices but couldn't add new ones
through the WebUI.
Add a simple component to allow adding serial ports backed by a
socket, which can be especially useful now with xterm.js

Passing through serial devices from /dev isn't possible with this, as
it is normally a root only operation and not that often used.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-05-17 09:25:34 +02:00
Dominik Csapak
16dedd0f6a add missing onlineHelp links
for:
* dc/Cluster
* node/Certificates
* qemu/CloudInit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-14 12:01:39 +02:00
Dominik Csapak
d47512afe6 make HDMove.js also usable for lxc
this makes it possible to reuse the window for container move_volume

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Dominik Csapak
811a06ca65 close HDMove on taskDone
this triggers the 'destroy' event of the window at the correct time

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-07 14:55:49 +02:00
Dominik Csapak
1d90225274 use correct multiKey and getObjectValue calls for memory line
also show shares and if ballooning is off

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 12:12:47 +02:00
Dominik Csapak
3438c27eab allow xtermjs to be the default console
if not available for a vm, we fallback to novnc like with spice

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 09:42:55 +02:00
Wolfgang Link
7cb345b816 fix #1691: use asynchronous API call for HD create
It should use an asynchronous API call to create an image,
because some storages may need longer to alloc an image.

If a storage needs more than 30 sec
the proxy will timeout and we have an orphan image.

Also, it is possible to increase the timeout for some
storages if an asynchronous call is used
2018-04-20 11:03:47 +02:00
Dominik Csapak
b08ae04435 overwrite the built-in 'run_editor' function
this is needed for the 'enter' handler

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 14:03:59 +02:00
Dominik Csapak
29e19e9583 qemu/CreateWizard: add advanced options on general tab
add start on boot, guest agent and boot order fields

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
57f034f6ff qemu/NetworkEdit: rework panel for advanced options
move some fields into advanced options, and remove nat mode

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
869f805312 qemu/MemoryEdit: rework panel and move most things in advanced options
this is a major rework of the memory inputpanel
previously we had to select fixed/variable and
could set shares/ballooning, depending on what was selected

now the panel is much simpler:

non advanced:

memory: the target maximum memory

advanced:

min-memory: the minimum memory, if different from the memory field
we have 'dynamic' memory

shares, only if we have 'dynamic' memory

ballooning-device: better naming, deactivates the ballooning device

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00
Dominik Csapak
c2233c8fc2 qemu/HDEdit: move diskthrottling to advanced options
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-06 11:45:14 +02:00