Commit Graph

5857 Commits

Author SHA1 Message Date
Thomas Lamprecht
3527924585 ui: ceph status: use two column layout for 1600+ window width
Looks already OK at that size, and one gets a better overview.

We have a slightly complex layout here (to columns which should be
above each other) so we cannot just use the generic helper, but
that's OK here - it *is* a special view.

Note, not all people use full-sized windows all the time, so the
widths here must not only be considered in terms of display
resolutions...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-26 12:31:11 +02:00
Thomas Lamprecht
f9f81a01dc ui: tasks: add ceph edit-pool and set-flags descriptions
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-26 12:27:48 +02:00
Thomas Lamprecht
301f52b172 ui: break overly long line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-26 12:27:14 +02:00
Thomas Lamprecht
4c42fc7422 update shipped APL info
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-25 18:22:58 +02:00
Thomas Lamprecht
e248e28455 bump version to 6.4-2
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:29:03 +02:00
Thomas Lamprecht
519d9f3fee ui: ceph pools: fixup class names, drop extry xtype definition
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:23:04 +02:00
Thomas Lamprecht
5da1b6d0db ui: ceph: pool creation: default auto-scale value to "on"
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:18:51 +02:00
Thomas Lamprecht
3eaf388170 ui: node config: fix internal code order for nav bar
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:11:46 +02:00
Thomas Lamprecht
17f4e62e32 ui: ceph: status details: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:00:42 +02:00
Thomas Lamprecht
10b00f3a06 ui: ceph: status: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 19:00:42 +02:00
Thomas Lamprecht
f87b8d2f3f ui: ceph: services: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:44:57 +02:00
Thomas Lamprecht
fb792310d1 ui: ceph: service list: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:44:39 +02:00
Thomas Lamprecht
261bb63356 ui: ceph: pool: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:44:23 +02:00
Thomas Lamprecht
d7acb90022 ui: ceph: fs: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:44:13 +02:00
Thomas Lamprecht
436f638d44 ui: ceph: install wizard: eslint fixes and code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:44:01 +02:00
Thomas Lamprecht
13786fb021 ui: ceph: factor out installation mask store monitoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 18:43:07 +02:00
Thomas Lamprecht
d290acc84d ui: live-restore: refine notice
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 15:20:53 +02:00
Thomas Lamprecht
6da2926cbc ui: CT restore: make privilege level a tri-state radio group
Default to keeping the state of the archive, as that has the highest
chance to fully work, but allow to enforce either level.

It'd be good to add some more feedback of the to be restored guest,
i.e., the whole config..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 15:18:44 +02:00
Thomas Lamprecht
a4f1a33d09 ui: ceph crush: code cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 18:55:46 +02:00
Thomas Lamprecht
cd99757bdf ui: ceph pools: avoid resetting crush rule hwne editing a pool
we are only allowed to set autoselect the first record after load on
creation, else we may change the value by mistake which, if the admin
does not notices when changing some other setting, can be quite fatal
as it can trigger a huge rebalance, where the cause may then not even
be obvious and thus an admin be quite baffled.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 18:52:00 +02:00
Thomas Lamprecht
5a34ccd6b2 ui: ceph pools: do not grey-out name field when editing
The displayEdit field already shows it as display field in this case,
which is enough.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 18:00:13 +02:00
Thomas Lamprecht
ad33cfd53a ui: ceph pools: fix target size column renderer
Moved to widget toolkit recently..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 17:59:13 +02:00
Thomas Lamprecht
8e9a0d5792 bump version to 6.4-1
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 17:18:32 +02:00
Thomas Lamprecht
0c37330663 d/control: bump versioned dependency of libpve-http-server-perl
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 17:18:32 +02:00
Oguz Bektas
e224b7d2e6 fix #417: proxy: allow settnig LISTEN_IP for pveproxy and spiceproxy
The $host variable is set to "::0" by default to listen on wildcard
(with 'Domain' => PF_INET6).

If 'LISTEN_IP' is defined in /etc/default/pveproxy, that IP will be used
instead.

Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2021-04-23 17:13:45 +02:00
Thomas Lamprecht
74b6a95945 ui: storage: backups: allow to edit notes also here
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 16:47:32 +02:00
Thomas Lamprecht
6e339db129 ui: backup views: unfiy button order in storage and guest backup view
and group better, avoid alternating by destroying and restoring
button (prune, file restore, remove) and place file restore and
restore together

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 16:46:10 +02:00
Thomas Lamprecht
c72ff9a9ae ui: guest backup grid: hide file-restore button if not a PBS storage
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 16:44:58 +02:00
Fabian Grünbichler
4c02fcfd0a file-restore: pass in full volume ID
not just the snapshot name.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-04-23 15:32:10 +02:00
Stefan Reiter
fe66076f46 gui: add task name for 'pbs-download'
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-04-23 15:32:08 +02:00
Stefan Reiter
84ae9c8a19 backupview: add file restore button
Adds it for both BackupViews, on VM view and storage view.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-04-23 15:32:08 +02:00
Lorenz Stechauner
63c2296675 ui: set file name for spice console download in chrome
When the virt-viewer file is downloaded we already set a file name in
Android, so the file type may be recognized. Also doing this in
Chrome (and Chromium based browsers) allows users to "alyways open
files of this type". So the browser automatically opens the console
window without user interaction.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-23 15:25:25 +02:00
Dominik Csapak
c95917c263 ui: use pmxInfoWidget instead of pveInfoWidget
to prevent that they further diverge than they alread have
(pmxInfoWidget got an additional function that is compatible)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-23 10:37:55 +02:00
Aaron Lauterer
1490b5eb6d ui: firewall: rule: maxlength for source and dest
Limiting the length of the source and dest paramters helps to avoid
problems with iptables-restore which would not apply a rule if a
parameter is larger than the parameter buffer (1024)[0]. As the API is
already limiting this, we should also reflect that in the GUI and give
people a hint that IP sets are most likely the better approach.

[0] http://git.netfilter.org/iptables/tree/iptables/xshared.c?h=v1.8.7#n469

Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
2021-04-22 21:33:37 +02:00
Stoiko Ivanov
6cd854d8c7 fix #3385: api: network: check for used ports before writing
Currently the check for used ports for bonds and bridges happens
while rendering '/etc/network/interfaces.new' in PVE::Inotify
(pve-common).
However at that stage the new/updated interface is already merged
with the old settings, making it impossible to indicate where a NIC
is currently used.

The code is adapted from the renderer in
PVE::Inotify::__write_etc_network_interfaces.

Tested on a virtual PVE instance.

Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 21:32:26 +02:00
Thomas Lamprecht
5d4faa4dd7 d/control: bump versioned proxmox-widget-toolkit dependency
bunch of stuff moved over or got added there...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 20:43:39 +02:00
Dominik Csapak
e3c4b75d9e ui: panel/StatusView: use from widget-toolkit instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
2874be00f2 ui: Utils: use updateColumns from widget-toolkit
it was moved there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
a8ea1b6876 ui: use some icons from widget-toolkit
we moved them there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
1bd7bcdbf1 ui: Utils: use render functions from widget-toolkit
they live there now, so we can delete them here and use the ones from
widget-toolkit instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 18:34:34 +02:00
Thomas Lamprecht
b988934559 ui: guest safe destroy: try to be a bit more telling in box/tooltip label
Try to be more clear about what those checkboxes do, hopefully
reducing potential confusion by (newer) users.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 13:20:46 +02:00
Thomas Lamprecht
ff89c79e72 ui: guest safe destroy: fix alias
`proxmoxSafeDestroy` is the one from the parent, also widget. missed
in general...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 13:19:07 +02:00
Fabian Ebner
af6f4b9ba0 ui: remove SafeDestroy window
which has been moved to proxmox-widget-toolkit.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-22 13:02:45 +02:00
Fabian Ebner
b9635c9b99 ui: use safe destroy window from proxmox-widget-toolkit
for the remaining (i.e. non-guests) users.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 13:02:45 +02:00
Fabian Ebner
94d2359b78 ui: safe destroy guest: add checkbox for removal of unreferenced disks
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-22 12:48:41 +02:00
Fabian Ebner
2452e18de4 ui: use new SafeDestroyGuest window
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-22 12:48:41 +02:00
Fabian Ebner
803053dad8 ui: add SafeDestroyGuest window
The purge parameter is always explicitly set, which is different from the
existing behavior, but it does not rely on what the default in the backend is.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-04-22 12:48:41 +02:00
Dominik Csapak
ced67201ad ui: Parser: respect mtu in {parse, print}QemuNetwork
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 12:15:10 +02:00
Thomas Lamprecht
736b919d04 http server: comment and refactor CSRF skip-check logic
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 11:19:40 +02:00
Lorenz Stechauner
7d11059e2d http-server: fix for api token csrf token check
Do not check any csrf tokens for auth with api tokens.

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
2021-04-22 10:54:26 +02:00