Do not add/extract standard options if the method itself defined properties
using the same names (like 'quiet').
Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
to ensure we have the /etc/hosts inotify read/write, needed for it's
gui part, methods available
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This add a new api to online reload networking configuration
with ifupdown2.
This work with native ifupdown2 modules, as ifupdown2 have
interface dependency relationships.
Some specific interfaces options can't be reloaded online
(because kernel don't implement it), it this case, we ifdown/ifup
theses interfaces. (mainly vxlan interfaces options)
Switch the default mode 'MULTI' with 'SIMPLE', the same we use in the
dc/Backup guest selector. It allows to remove the 'checkOnly'
setting, which limited selection and deselection of elements on the
checkbox it self, doing nothing when clicking on rows.
Besides the friendlier and more streamlined UX this actually fixes a
bug in Firefox (confirmed in version 62, possible in other versions
too) where select/deselect di not worked when clicking in the white
area of the checkbox, but only when clicking on the surrounding
padding.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
btrfs is deprecated since Luminous and it will no more be tested.
If btrfs is used, you have to add an extra parameter to ceph.conf
to allow ceph-disk to activate btrfs OSD's.
In our default config this is not the case.
From Luminous release note [1]:
"We no longer test the FileStore ceph-osd backend in combination with
btrfs. We recommend against using btrfs. If you are using
btrfs-based OSDs and want to upgrade to luminous you will need to
add the follwing to your ceph.conf:
enable experimental unrecoverable data corrupting features = btrfs
The code is mature and unlikely to change, but we are only
continuing to test the Jewel stable branch against btrfs. We
recommend moving these OSDs to FileStore with XFS or BlueStore."
[1] https://ceph.com/releases/v12-2-0-luminous-released/
e.g., pending deletion of cdrom/dvd drive showed as hard disk in
hardware tab
Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we do all necessary checks in the backend, and there we allow
whitespace in mp paths, so there is no need to restrict it in
the gui to non-whitespace characters
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
openvz is deprecated but can still be a return value
maxcpu can be a real number (e.g., for CT if cpulimit is 1.5 and
cores is not set), and may not be an integer
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
if we do not have a language cookie, try to read
the language from the datacenter.cfg and fall back to 'en'
also set it into the 'Proxmox' object, so that the gui can show it
in the LoginWindow
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
some options are only relevant for some iscsi providers
so only allow thos who are relevant to the selected provider
and rename LIO target portal group to 'Target portal group'
since it is only active when lio is chosen
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since the whole panel was scrollable instead of the individual ones,
selecting a ha service triggered the 'jump to focus' which made it
hard (if not impossible) to reach the edit/remove buttons for it
this patch reorganizes the panels in such a way that the status
panel is fixed height, and the content of the resource panel is
scrollable (always showing the edit/remove buttons)
to avoid not seeing the resources when one has a large number of
nodes, we make the individual panels collapsible
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
adding LIO option and dedicated "LIO target portal group" input field to the
"Add: ZFS via iSCSI" dialog
Signed-Off-By: Udo Rader <udo.rader@bestsolution.at>
Change to agent now being a property_string, and including fstrim_cloned_disks.
Co-Authored-By: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
allows to catch bugs faster as we get a call trace and may see this
error even when our caller doesn't handle an undefined return value
from this method.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Combine both dialogues. This reduces storage choices from the
Storage -> Add menu, and thus improves usability.
We make the whole dialog also more intelligent by querying the
monitors, so that we can show them for the hyper converged case
keeping a similar interface for both cases. Further we can use this
to decide if a hyperconverged setup is possible at all.
While this information would also be available through the fact if
the pool selector has entries I wanted to show them anyway and could
make logic a bit easier using it.
allowSpice needs to be a real boolean, because of a
'=== true' check to open a spice console if allowed, so make it one here
this fixes the issue that a doubleclick on a tree item only opened
the novnc console even if spice is the default and the vm is spice
enabled
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
allows us to remove the external loading of extjs from the cloudflare
cdn in pve-docs easier with having the external hosted version in
mind.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Most of those API calls return simple strings, so it does not really matter.
Nethertheless, some calls return complex data structures and we want to set
output format for them.
