This patch relies on the corresponding patch to pve-firewall, adding the user
defined log levels for firewall rules.
By this, the user can select a per-rule log level for self defined rules. These
are independent of the global log level, which is defined in the firewall options.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
This warns the user that the datacenter firewall is disabled when editing the
host or the VM/CT firewall status.
Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
when using the 'run_editor' function provided by the ObjectGrid,
we have to make sure the function runs in the context of the grid,
not in that of the button, else we cannot access the
selectionModel/rows/etc. of the grid
this happened with the switch to the widget toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Split PVE specific models, which where not moved to the general
widget toolkit, in a separate folder: data/models/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
The alias stayed the same (store.diff) so we need to change direct
usage of 'PVE.data.DiffStore' only.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
switch add_boolean and add_integer row to a simple wrapper.
We really use it often and can save quite some lines with it so it
does not make sense to remove it completely yet.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
most 'Remove' buttons we have used the same code pattern over and over,
with the StdRemoveButton we have a component which does all of this for
us
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we want to use the getId method of some records, but for this
we need that the records are defined as an instance of a model,
so we create some and use them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
because we will use that in the widget toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
there we implemented deleteEmpty, which we can use in some cases.
this also fixes a bug in the ControllerSelector where
an empty field would be allowed (but should not)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we always had dhcp enabled by default in the backend, but
showed 'Disabled' on the gui, this patch show 'Enabled' by default
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
while it does not makes sense do over-reuse translations for the sake
of translating less, imo, here we can safely reuse already existing
ones and pull out the unit 'MB/s' from the gettext.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
It was a bit strange to have two separate status columns, which do
effectively the same thing. So merge them together to save a bit
space and have less columns.
We do not need to translate 'Status Text' as a nice side effect.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Add one more to show that also weekdays + intervals are possible
Further improve wording + reduce translation needs for others entries.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
When a user sees this the first time and wants to add a job he
shouldn't be confused what the default value means, so display this
through the emptyText property, which does not get submitted to the
backend.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Delete the strange sounding Note from the Removal dialog.
This was added to make sure that an user isn't confused that a Job is
still shown after 'removing' it. But it isn't needed as there is
already noted in the jobs status that it will get removed soon after
doing so, so the user sees that his action had the desired effect, no
extra note needed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The status '-' can confuse users, as it could indicate something is
missing, whereas OK indicates everything is alright (which is the status
we want to show)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
values.guest is only available when the field 'guest' is not a
displayfield (e.g. when in vm replication panel), so we have to
use the given vmid first and only when this is not available, fall back
to the value of the field
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch adds a replication grid, which shows the status/configuration
for the defined replication jobs, and allow them to be
added/edited/removed
in case the replication grid gets shown in the datacenter, we omit the
status fields, because we only have the configuration there
when opening the grid, we check if there are at least two nodes,
because currently we only allow replication in a cluster environment
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we gave erroneous entries in grids the class .x-form-invalid-field
but since we changed to the "crisp" theme, this class did not have any
highlighting
so instead we use our own "pve-invalid-row" class
and give it a light red background
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
