Commit Graph

150 Commits

Author SHA1 Message Date
Emmanuel Kasper
67cb91e4d7 Indentation fix 2017-02-28 11:33:51 +01:00
Emmanuel Kasper
f4f9e66296 Make explicit the meaning of an empty storage field
By default when no target storage is selected in the clone panel, the clone
will use the same storage*s* as the source.

This was not obvious to guess that from the panel.
2017-02-28 11:20:30 +01:00
Emmanuel Kasper
c8fc7a4eee Add a clone button in the VM toolbar
Up to now the Migrate function had a first class button in the toolbar,
but the Clone function didn't.
With this button the toolbar still fit correctly in a smaller
1280 pixel wide display.
2017-02-22 13:54:36 +01:00
Emmanuel Kasper
4e2b6cc8ee Move the snapshot API test to a static function
This will allow code reuse in a following patch.

No functional change.
2017-02-22 13:54:36 +01:00
Emmanuel Kasper
0057ea5c88 Fix handling of failed API call verifyFeature()
This call can for instance fails when a source VM has references
to non existing storages.
2017-02-22 13:54:35 +01:00
Emmanuel Kasper
4092576b1b Fix #1266: use a renderer when displaying Unix timestamps.
The timestamp is displayed read only in a large window, and not sortable,
hence we use the human readable renderer.
2017-02-01 10:09:58 +01:00
Emmanuel Kasper
ec99b1c367 Remove duplicate strings 2017-01-18 10:19:43 +01:00
Emmanuel Kasper
22c01a4473 Disable autoSelect of target storage
autoSelect: true  was surreptitiously commited with the refactoring
of 406ac585db
( Use component references via lookupReference() )
2017-01-12 17:00:33 +01:00
Emmanuel Kasper
406ac585db Use component references via lookupReference()
This allows to add the components in each column in the order they
appear in the Clone Window.
References from child components are kept in an object in the parent
component so it should be the same performance-wise (contrary to to Ext.ComponentQuery
which is doing DOM parsing)
2017-01-12 12:26:07 +01:00
Emmanuel Kasper
68a433faff Use qcow2 as default disk format for clones fix: #1144
When using a file based storage, qcow2 has more features as raw,
this is why we recommend it for clones, similarly to when adding
new disk images.
2017-01-12 10:56:02 +01:00
Emmanuel Kasper
1c06db3444 Do not show a Clone Mode selection Window for non-templates clones
As Non-templates clones are always a full clone.
2017-01-12 10:48:29 +01:00
Emmanuel Kasper
364c58460f Group the Pool selector combobox to the VM properties
The pool membership relates here to the VM membership, not
the storage membership, so it makes sense to move it closer
to the VM ID / VM name form fields.
2017-01-12 10:41:47 +01:00
Emmanuel Kasper
2f3c5c38c0 Make the Snapshot selector an optional parameter in the Clone Window
The snapshot selector was known to confuse first time pve users.
Some wondered that they had no snapshot called 'current' in their
snapshot trees, and other thought that snapshots would be included
in the copied image.

So before displaying the Clone Window, do an API call to verify
if the source VM has snapshots.
2017-01-12 10:41:36 +01:00
Emmanuel Kasper
26693bb937 Disable the submit button based on whole form validity
Until now we disabled the submit button, based on
the feature API call where we tested if the selected VM, and its snapshot
can be used as the source of a clone.

This had the following problems:
 * the feature test for copy clone / linked clone always returned true,
 since the passed paramaters were already filtered before user input
 (ie we only allowed a linked clone to be selected if the source VM is
 a template, or a snasphot to be selected if existed on source VM)
 * the guest ID input field was not validated

With the current patch, the validation is now made on each of the form
fields. verifyFeature() is still used to populate a list of valid nodes
passed to the Node Selector.
2017-01-12 10:40:22 +01:00
Emmanuel Kasper
c3dea8fcaa Use correct parameter for GuestIDSelector 2017-01-12 10:38:01 +01:00
Emmanuel Kasper
44494b4c4c Better naming for kv1 comb box, document the two private functions 2017-01-12 10:37:50 +01:00
Dominik Csapak
49e1990583 fix gettext strings
we expect a gettext on a single line and to not contain any
variable/logic, so we remove the long text from it altogether (since we
do not want to translate that at the moment), and we rearrange the code
so that gettext only contains strings

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-01-10 12:14:12 +01:00
Dietmar Maurer
ff79a11669 Clone.js: add onlineHelp 2017-01-03 12:30:48 +01:00
Dominik Csapak
5f80c67ecc make date column resizable
this makes the date column in the snapshottree a little bit bigger and
resizable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-12-19 12:04:53 +01:00
Dominik Csapak
90ba9a4e02 snapshottree: remove sorter before saving the state
extjs saves the state including the sorter, but cannot serialize the
sorter function. when restoring the state, it is not a valid sorter,
so we delete it before saving

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-12-19 12:04:07 +01:00
Emmanuel Kasper
256a65a4bb reduce scope of jslint warnings to the problematic statement
also remove it from qemu/Clone.js since it validates OK
2016-12-19 07:31:51 +01:00
Emmanuel Kasper
ed416f2024 Convert the VMIDSelector to a generic GuestIDSelector
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.

Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a  *VM* ID, which is confusing.
2016-12-19 07:31:27 +01:00
Emmanuel Kasper
a255dd7e8c Turn the qemu StartupEdit widget into a generic component
and use this component for Qemu.
2016-12-06 06:53:20 +01:00
Emmanuel Kasper
ff05aec018 Add online help for startup/shutdown order and LXC general settings 2016-12-01 11:42:37 +01:00
Emmanuel Kasper
2b9e88286e Add Windows 2016 as available ostype to select 2016-11-29 09:11:28 +01:00
Dominik Csapak
9a60a19b4a fix #1208: add ballooning checkbox to memory edit
when using fixed memory size, we implicitly deleted shares and
ballon, which removed a (manually) set balloon: 0,

to be able to set this via the gui, we add a checkbox to the fixed
memory edit (using variable memory always needs ballooning)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-22 16:39:12 +01:00
Dominik Csapak
af603c1570 make lxc/qemu snapshot/network grids stateful
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:17:02 +01:00
Dominik Csapak
8a7e5598f1 add pveIntegerField and use it
this adds a subclass of Ext.form.field.Number with the settings for
Integers (allowDecimals: false and allowExponential: false and default
step size 1)

and use it where we only accept integers

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:14:06 +01:00
Dominik Csapak
ba93a9c665 move onlineHelp into classes from definition
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:13:12 +01:00
Thomas Lamprecht
fe4f00adc9 add 'delete_if_default' helper and use it
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2016-11-02 11:00:16 +01:00
Emmanuel Kasper
aeae272a86 Move out custom css style for hints in css class and use it 2016-10-19 17:24:28 +02:00
Dietmar Maurer
c8802a60b7 use auto-generated block IDs to reference online docu. 2016-10-13 11:26:06 +02:00
Dietmar Maurer
3d9a210f55 fix lint error 2016-10-13 09:40:33 +02:00
Emmanuel Kasper
e2d725633e Move bus priority list to OSDefaults
So a field container does not need to know if Linux likes SCSI.
2016-10-11 07:02:33 +02:00
Emmanuel Kasper
78a5e21e4c make Win XP and Win 2003 use the same defaults as Win 2000
(this means: rtl8139 as nic and lsi as hardware controller)

XP & 2003 ISO E1000 drivers are missing or do not work with Qemu
(source: https://pve.proxmox.com/wiki/Windows_2003_guest_best_practices)
(source: https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes)

The lsi SCSI controller was the default SCSI controller until recently and works with Win2003.
(NB: An IDE controller is still selected during installation for these OSes)

The aim is to provide an out-of-the box besser experience when using the Create Wizard.

NB: we have a distinct OS type between wxp and w2k3 in QemuServer.pm but since they
use the same defaults we can still wxp for both of those.
2016-10-11 06:47:40 +02:00
Emmanuel Kasper
98a01af2a8 Add regexp to match a bus entry in a VM config 2016-10-07 07:01:36 +02:00
Dominik Csapak
7ec884caee fix width of panels in statusviews
since we introduced the vertical menus,
each panel is about 30px too wide for having
two side by side with a 1920x1080 resolution

this patch changes, the paddings/sizes so that
this fits again, at the cost of about 30 pixels width
per panel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-05 06:55:33 +02:00
Dominik Csapak
6f6bb9c2eb fix jslint error
trailing comma

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-04 10:48:57 +02:00
Emmanuel Kasper
d6dfc45b8e add a warning message if the EFI disk is missing fix #1112
do not display an obstrusive popup on top of a modal window,
but display a hint under the combo box
2016-09-20 17:21:50 +02:00
Emmanuel Kasper
2c0e2890e0 fix #1113 use a LSI controller for legacy OSes
instead of setting virtio-scsi for all newly created VMs, pass the
OS Optimal SCSI Controller to pveQemuCreateWizard which will
add it as an hidden paramater just before POSTing the wizard data
to the API.
2016-09-20 17:21:34 +02:00
Emmanuel Kasper
c149681d61 fix #1113: preserve LSI controller for legacy Oses
The SCSI HW type handling will be made in the Wizard class, removing from here.
2016-09-20 17:18:19 +02:00
Dietmar Maurer
59f2dd3dcf use refresh event instead of datachanged 2016-09-16 07:36:15 +02:00
Emmanuel Kasper
9daa22a630 Use SCSI controller as default for l26 guests fix #1105
NB: This is only for new created VMs.
2016-09-15 11:40:12 +02:00
Emmanuel Kasper
eca87c69bc virtio-scsi-pci as default SCSI for new VMS fix #1106 2016-09-15 11:36:35 +02:00
Dominik Csapak
67fc6ddf0e add onlineHelp for UEFI
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 16:46:07 +02:00
Dominik Csapak
1535df627b give error instead of disabling efidisk button
when seabios is selected, we do not want to simply
disable the add efi button, because it is not clear
why it is disabled

so we give a meaningful error message instead

the button is still 'just' disabled when there
is already an efidisk, because then it is clear
that you alread have one

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 16:45:49 +02:00
Dominik Csapak
3c724630b3 add onlineHelp to qemu
and its options

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 16:42:06 +02:00
Dominik Csapak
816b62b0aa fix #1104: add missing /firewall in url
with the reorganizing of the tabs to
the treelist, we forgot to add /firewall to some
urls, making the url for source/destination invalid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 08:03:20 +02:00
Dominik Csapak
3b37ab6db8 add efidisk button to add menu
this adds a new button "efi disk" to the
qemu hardware add menu

this is only enabled if the vm has ovmf enabled and
no active efidisk

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 07:52:46 +02:00
Dominik Csapak
194c9b0964 add efidisk to qemu hardwareview
this shows an active efidisk above
unused disks, without an editor (because there are no options)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 07:51:19 +02:00