By default when no target storage is selected in the clone panel, the clone
will use the same storage*s* as the source.
This was not obvious to guess that from the panel.
Up to now the Migrate function had a first class button in the toolbar,
but the Clone function didn't.
With this button the toolbar still fit correctly in a smaller
1280 pixel wide display.
This allows to add the components in each column in the order they
appear in the Clone Window.
References from child components are kept in an object in the parent
component so it should be the same performance-wise (contrary to to Ext.ComponentQuery
which is doing DOM parsing)
The pool membership relates here to the VM membership, not
the storage membership, so it makes sense to move it closer
to the VM ID / VM name form fields.
The snapshot selector was known to confuse first time pve users.
Some wondered that they had no snapshot called 'current' in their
snapshot trees, and other thought that snapshots would be included
in the copied image.
So before displaying the Clone Window, do an API call to verify
if the source VM has snapshots.
Until now we disabled the submit button, based on
the feature API call where we tested if the selected VM, and its snapshot
can be used as the source of a clone.
This had the following problems:
* the feature test for copy clone / linked clone always returned true,
since the passed paramaters were already filtered before user input
(ie we only allowed a linked clone to be selected if the source VM is
a template, or a snasphot to be selected if existed on source VM)
* the guest ID input field was not validated
With the current patch, the validation is now made on each of the form
fields. verifyFeature() is still used to populate a list of valid nodes
passed to the Node Selector.
we expect a gettext on a single line and to not contain any
variable/logic, so we remove the long text from it altogether (since we
do not want to translate that at the moment), and we rearrange the code
so that gettext only contains strings
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
extjs saves the state including the sorter, but cannot serialize the
sorter function. when restoring the state, it is not a valid sorter,
so we delete it before saving
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.
Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a *VM* ID, which is confusing.
when using fixed memory size, we implicitly deleted shares and
ballon, which removed a (manually) set balloon: 0,
to be able to set this via the gui, we add a checkbox to the fixed
memory edit (using variable memory always needs ballooning)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this adds a subclass of Ext.form.field.Number with the settings for
Integers (allowDecimals: false and allowExponential: false and default
step size 1)
and use it where we only accept integers
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(this means: rtl8139 as nic and lsi as hardware controller)
XP & 2003 ISO E1000 drivers are missing or do not work with Qemu
(source: https://pve.proxmox.com/wiki/Windows_2003_guest_best_practices)
(source: https://pve.proxmox.com/wiki/Windows_XP_Guest_Notes)
The lsi SCSI controller was the default SCSI controller until recently and works with Win2003.
(NB: An IDE controller is still selected during installation for these OSes)
The aim is to provide an out-of-the box besser experience when using the Create Wizard.
NB: we have a distinct OS type between wxp and w2k3 in QemuServer.pm but since they
use the same defaults we can still wxp for both of those.
since we introduced the vertical menus,
each panel is about 30px too wide for having
two side by side with a 1920x1080 resolution
this patch changes, the paddings/sizes so that
this fits again, at the cost of about 30 pixels width
per panel
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of setting virtio-scsi for all newly created VMs, pass the
OS Optimal SCSI Controller to pveQemuCreateWizard which will
add it as an hidden paramater just before POSTing the wizard data
to the API.
when seabios is selected, we do not want to simply
disable the add efi button, because it is not clear
why it is disabled
so we give a meaningful error message instead
the button is still 'just' disabled when there
is already an efidisk, because then it is clear
that you alread have one
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with the reorganizing of the tabs to
the treelist, we forgot to add /firewall to some
urls, making the url for source/destination invalid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this adds a new button "efi disk" to the
qemu hardware add menu
this is only enabled if the vm has ovmf enabled and
no active efidisk
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>