Showing already configured custom device classes makes it easier to
create new OSDs with custom device classes.
The Crush map contains a list of all OSDs in the cluster, including
their device class.
This means we can create a list of used device classes from it, avoiding
adding another API endpoint.
Fetching the crushmap should also be quite a bit less data that needs to
be transferred, compared to the other possible nodes/<node>/ceph/osd
endpoint, especially in larger clusters.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
to avoid implying that it's *only* quoted if that parameter is
truthy.
Also, check the boolean before looks_like_number call, as that is
more expensive to do.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
InfluxDB interprets the guest name '66601' as a number and the guest
name 'vm42' as a String. This leads to problematic metrics, that will
be dropped by influxdb. Whichever comes first decides how the
"schema" is defined.
To change that add a $to_quote hashmap to define which value
shouldn't get interpreted as number by always send it quoted.
For now only quote 'name'.
Note, that while the 'nodename' and 'host' properties would have the
same problem, they are tags in InfluxDB which are always interpreted
as strings:
https://docs.influxdata.com/influxdb/v2.1/reference/syntax/line-protocol/
Signed-off-by: Markus Frank <m.frank@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This way, a running backup cannot prevent pve-guests from starting a
virtual guest which was marked with 'onboot'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
commmit
b241deb7 ("close #3476: vzdump: add job-init hook")
introduces a 'cfs_update' in VZDump->new(), which overwrites our
carefully prepared storage/vm config which can break the tests
to prevent this, mock 'cfs_update' to do nothing, since we never
want to load the 'real' configs during tests anyway
fixes commit b241deb731
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
We do not use 'Set XYZ' anywhere else and it should be clear enough
from the PCI selector in the non-advanced section that the actual
device to get passed-through is chosen else where, but we still can
use the emptyText to avoid confusion where the (sub) vendor/id will
come from if a field is left empty.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
which allows users to prepare the backup storage for activation (e.g.
by waking up a remote node).
Suggested-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Reviewed-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
Acked-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
to make it easier guaranteeing the more capable calendar event
implementation is active for all parts using it.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
and calculate it by getting the next event after 'now' since
we currently have no way to get the last run time for jobs only running
on different cluster nodes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in commit
07195aa079 ("ui: fix novnc scaling radio button")
we always set to 'scale' when no value was set, but a non-set value
actually had a different behaviour:
in the embedded console it was set to 'scale', but in the pop-up it was
set to 'off'.
to restore this behaviour, introduce an option 'auto' which unsets the
'novnc-scaling' setting
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The only functional differences I could see are the missing
defaultValue for 'Scan' and the reduced height. For restoring the
height, there is a proposed patch for widget-toolkit.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
when having selected 'off', the next start of the window has both
radiobuttons selected and no change is possible anymore. It seems that
the 'checked: true' triggers only after the 'init' function.
So instead remove the 'checked: true', and add the default in the init
function.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in get_credentials, we try to read the token for the specified server,
and warn if we cannot do that (e.g. because the file does not exist)
since having no token is a valid configuration, suppress that warning on
connection.
reported by a forum-user:
https://forum.proxmox.com/threads/interface-comes-up-with-all-question-marks.83287/page-2#post-438204
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
to have the most recent ones first, while keeping backups from the
same guest together.
Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Overriding the controller render_status must be done in an derived
class, not as config for the instantiated object.
While it worked it really isn't idiomatic and ExtJS complained with
an error in debug mode, which broke the whole UI then.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Using 00:00 with relying on the implied default is sub optimal as its
a bit of a magic example that new users may not understand as easily.
So spell it out explicitly, even if there'd be a shorter version
possible.
We also had some request for the once-daily every day, and its a
sensible example to have in general, could help getting the
difference between an hour list and a single one.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
dragHandle was copied from the BootOrderEdit.
Also increases the width by 23px to make space for it.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
