Commit Graph

3772 Commits

Author SHA1 Message Date
Dominik Csapak
5fc4ccfb9f gui: add form/PCISelector
this adds a form field for selecting a pci device

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-22 13:31:31 +01:00
Dominik Csapak
07d982de6c api/Scan: allow to get a PCI device's mediated devices
this is for the gui to be able to select mediated devices
path ist /node/NODE/scan/pci/PCIID/mdev

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-22 13:30:50 +01:00
Dominik Csapak
782be7dae2 api/Scan: allow to scan a nodes PCI devices
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-22 13:30:21 +01:00
Thomas Lamprecht
9a25bf06b6 ui: storage/content: reference volid in confirm window and use new task description
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 13:27:34 +01:00
Thomas Lamprecht
f726b8da42 ui: storage/content: jslint and styling fixups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 13:26:56 +01:00
Wolfgang Link
4f19410bdd Add imageRemoveButton
If an image has a <vmid>  encoded in the image name
and the guest does not exist in the cluster
we can delete it on the GUI.

Also, if a config exists on another node and the storage is local
we can delete.

In all other cases, it is not allowed to delete it.

For safety reason the safe remove windows are used.
2018-11-22 11:57:19 +01:00
Thomas Lamprecht
f8346b5201 CephTools: cleanup module usage
as done with the api ceph modules:
most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 11:06:12 +01:00
Thomas Lamprecht
400742e432 api/Ceph: actually use imported file_{g,s}et_contents 2018-11-22 11:06:12 +01:00
Thomas Lamprecht
0cd34b008b api/Ceph: cleanup module usage
most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

As this file includes two perl modules you need to take a bit caution
when looking at this, as some things are used in one module but not
the other - simple grep'ing at this may give false positives.

Also add PVE::API2::Storage use which was missing here.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 11:06:12 +01:00
Thomas Lamprecht
d4d2e789b8 api/CephOSD: cleanup and sort module usage
most of this was imported by just copying without verifying if all is
actually required. Some lost its purpose as we re-used more from our
existing module code base (e.g., pve-common) but wasn't actually
removed.

As this file includes two perl modules you need to take a bit caution
when looking at this, as some things are used in one module but not
the other - simple grep'ing at this may give false positives.

Also include the missing IO::File use.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 11:06:12 +01:00
Wolfgang Link
c5e224fc73 Move removeButton in a variable
The move is necessary to hide the removeButton.
2018-11-22 08:50:32 +01:00
Wolfgang Link
5cdb27225f Add imagedestroy to SafeDestroy 2018-11-22 08:50:32 +01:00
Wolfgang Link
934182317d Add function guestNode
This function extracts the node where the guest resists.
2018-11-22 08:50:32 +01:00
Wolfgang Link
01532f8dcc Add function storageIsShared
This function extracts the shared flag of the storage state.
2018-11-22 08:50:32 +01:00
Wolfgang Link
1ce3fa3bc1 Add parameter storage shared
So we know in the content call if storage is shared.
This is used by removeImageButton.
2018-11-22 08:50:32 +01:00
Thomas Lamprecht
3097170dad ui: qemu/HW: menu setDisable mustn't ignore caps
We passed a 'disable' config to those menu items on creation, but
promptly ignored that after the first set_button_status call, which
only checked if it's possible to add another device, but not if our
capabilities heuristic is OK.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-22 08:40:15 +01:00
Thomas Lamprecht
160673c147 ui: lxc/net: s/i.e./e.g./ and transform to emptyText
We want to name an example here, so `e.g.` would be better.

Also show that in the field if empty. No changes to gettext stuff.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-20 11:10:07 +01:00
Thomas Lamprecht
4e120eb254 bump version to 5.2-12
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 15:26:20 +01:00
Thomas Lamprecht
e7a2b38b6e d/control: bump version dependency for libpve-common-perl
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 15:04:38 +01:00
Dominik Csapak
ab322f5f83 rename PVE::API2::Storage::Scan to PVE::API2::Scan
and use it in the API

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-19 15:04:31 +01:00
Dominik Csapak
805577a6f5 API/Scan: use scan_usb from PVE::SysFSTools
the code moved from PVE::Storage there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-19 15:04:02 +01:00
Dominik Csapak
bed048ef70 API/Scan: remove unused HTTP::Status module
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-19 15:03:50 +01:00
Dominik Csapak
6b028c3c48 Scan: whitespace fixes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-19 15:03:45 +01:00
Dominik Csapak
03b0c2f5dc copy storage scan API from pve-storage
this will be used for the api endpoints in the future as
PVE::API2::Scan instead of PVE::API2::Storage::Scan since it will
contain endpoints to other modules (like qemu-server for pci/usb
scanning)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-19 15:03:12 +01:00
Thomas Lamprecht
4a4b2b6e0b ui: dc/storage: allow to add CephFS
Allow to add CephFS storage over GUI. Reuse viewcontroller and model from RBD
to detect if we can do a "hyper-converged" addition (with PVE maintained Ceph)
or if only external is possible.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:40:49 +01:00
Thomas Lamprecht
8c93faf917 ui: rbd: storage: obsolete strange getBinds binding assembly
this was added for our (also in other places used):
> xtype: me.isCreate ? 'pveCephPoolSelector' : 'displayfield',
construct. But as displayfield does not has a submitValue setter we
cannot bind it generally.

So add such a setter with a small override and declare the bindings
direct when declaring the items, less side effects and all the
configurations for an item stays in the same place.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:40:49 +01:00
Thomas Lamprecht
b42d008b3a ui: storage: RBD: factor out view- model/controler
will be reused for CephFS, look at this with git's ignore whitespace
change flag '-w' to see that the changes consist mostly of indent and
hunk movement changes

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:40:49 +01:00
Thomas Lamprecht
35ce219cdc fix #1224: ui: ACLAdd: allow to filter by username
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:22:48 +01:00
Thomas Lamprecht
3d7b2aa9f4 fix #1358: ui: show clustername besides 'Datacenter' node, if available
If we get the cluster name (successful login with '/' Sys.Audit
permissions) then display it in the resource tree's root node.

This updated on login and all ticket refreshs (every 15 minutes).
I currently have no functionallity to refresh it actively on cluster
create over WebUI, as it's not a straight forward change there.
Further, this is something which does not changes often (in
production), and we cannot detect CLI or API triggered (from non-pve
clients) cluster creations anyway.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-19 10:15:14 +01:00
Thomas Lamprecht
eb421b2c57 followup: split up and pull out html tags from gettext
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-16 12:19:50 +01:00
Tim Marx
ea3bffd087 fix #1928: ct snapshot: changed rollback message to warning
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-16 12:15:05 +01:00
Thomas Lamprecht
ff7930c1e6 d/control: bump version dependency to pve-doc-generator
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-14 16:20:51 +01:00
David Limbeck
75ceae787d add help button to 'My Settings' window
link to 'gui_my_settings' in docs

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-14 15:46:44 +01:00
Nick Chevsky
75357e9f0d Enable "Discard" option for IDE and SATA drives
Even though QEMU supports the discard feature for both ATA [1] and
SCSI drives, the "Discard" checkbox in Proxmox VE is artificially
restricted to SCSI drives. This change expands availability of the
"Discard" checkbox to all drive types supported by QEMU, leaving
VirtIO Block as the only remaining exclusion.

Combined with the new "SSD emulation" option [2], enabling discard
on IDE/SATA drives allows reclaiming of free space on thin-provisioned
storage with guests that do not support our SCSI controllers.

[1] d353fb72f5
[2] https://git.proxmox.com/?p=pve-manager.git;a=commit;h=f9261fde2134cec35a5ec7c3ebbee5daa4d67ec7

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
Tested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-14 09:21:12 +01:00
David Limbeck
793f2cf4e0 fix #1959: remove invalid SLAAC option
nocloud configuration does not support SLAAC option, only static or dhcp
so this option shouldn't be available

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-13 10:12:06 +01:00
Alwin Antreich
6281777bd9 add_storage creates only one ceph storage entry
This patch removes the separate storage entries for CT & VM to the same
ceph pool. Instead only one entry is made as we can now map/unmap
volumes actively in pve-container.

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-12 13:22:55 +01:00
Thomas Lamprecht
37e228da8c ui: node/zfs: fix up order of variable declaration to match grid order
It confused me twice and I enabled autoScroll on the wrong component,
so order it as it's layouted and remove the autoscroll completely,
not needed at all...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-12 12:31:47 +01:00
Thomas Lamprecht
50d5490f3a ui: node/zfs: fix stretch and scroll in details window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-12 12:27:17 +01:00
Tim Marx
8cfe208868 node zfs: added panel to window as container for new components
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-12 12:11:39 +01:00
Tim Marx
e98bcf01c4 node zfs: added new component to display additional zfs details
ZFSStatus component got renamed to ZFSDevices to clarify that it only displays
 the device tree of the status command. The newly added component is now named
 ZFSStatus instead.

Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-12 12:11:39 +01:00
Tim Marx
eb43c6f438 node zfs: added read, write, cksum fields to device tree
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-12 12:11:39 +01:00
Thomas Lamprecht
740514094a bump version to 5.2-11
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-09 17:00:30 +01:00
David Limbeck
afa1997599 fix #1969: increase max unused disks
Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 16:51:56 +01:00
Thomas Lamprecht
98b48cbd37 followup: remove unnecessarry new line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-09 14:47:06 +01:00
Tim Marx
8c8604bae3 node zfs: added check for undefined & new case AVAIL
Signed-off-by: Tim Marx <t.marx@proxmox.com>
2018-11-09 14:46:26 +01:00
Thomas Lamprecht
93bd0d75c3 fixup: lxc/Resources: add missing trailing semicolon
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-11-09 14:18:47 +01:00
Dominik Csapak
4f3e66d89b gui: let users edit the vga memory
and show the default for each type of virtual gpu

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-11-09 14:02:35 +01:00
David Limbeck
1a2fdf62fa fix mount point/unused disk sorting in Resources.js
use the same sort function as for VMs based on group and order

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 14:02:26 +01:00
David Limbeck
cbe0b4b834 fix sorting for unused disks in HardwareView.js
sort everything based on group and order for those with multiple numbered
entries

Signed-off-by: David Limbeck <d.limbeck@proxmox.com>
2018-11-09 14:02:26 +01:00
Nick Chevsky
f9261fde21 Add "SSD emulation" property to IDE, SATA, and SCSI drives
When enabled, the "SSD emulation" feature exposes drives as
solid-state (rather than rotational) by enabling the new `ssd`
qm.conf flag [1] on the drives, which in turn sets QEMU's
`rotation_rate` property [2, 3] on the underlying devices.

This change also moves the "Discard" option out of the advanced
section and promotes it to the top of the dialog box, as proposed
by Thomas Lamprecht [4].

[1] https://git.proxmox.com/?p=qemu-server.git;a=commit;h=6c875f9f315f2dc7a0a3a988622c2efdf089b171
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1498042
[3] https://lists.gnu.org/archive/html/qemu-devel/2017-10/msg00698.html
[4] https://pve.proxmox.com/pipermail/pve-devel/2018-November/034327.html

Signed-off-by: Nick Chevsky <nchevsky@gmail.com>
2018-11-09 09:33:26 +01:00