doc was just bumped, there's no real content, I don't want to bump it
just for this, so replace with link to QM and a fixme comment
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
By ensuring we delete the property if it's true (the backend default)
and set it is false, i.e., like originally (pre, mine and Aaron's
patch), but with reversed user input.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The recent change transformed this checkbox from a negative "No
Backup" to a positive "Backup" did not accounted for changing the
default fallback for the parseBoolean call.
As this would had suggested that disk are backed-up which aren't
backup, it could lead to pretty devastating results...
fixes commit 8e1df0acc5
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Change the behavior from having to activate the `No backup` checkbox to
exclude a disk from backups to having a `Include in backup` checkbox
that is checked by default.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
This patch enables the backup checkbox by default for newly created
LXC mount points.
Hopefully this will help to avoid situations in the future where people
realize too late that the mount point has not been backed up when they
expected it to because they missed the checkbox.
The reason why `view.isCreate` is not passed directly is because
AFAIU the 'view.isCreate' can have one of three values:
* null - editing an existing mount point
* true - creating a new mp
* array('unusedX') - adding an unused disk again
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
introduce a new browser setting, with which the users can choose between
the automatic mode of choosing columns, or always using 1/2/3 columns
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of the viewport width. This means that the number of columns can
change when the tree width changes, not only on browser window resize
for this to work reliably, we have to change the structure of the first
two panels, so that they are in one container for non-templates. if
we do not do this, there are some weird glitches on resizing with the
scrollbar
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
vzdumps bwlimit is in KiB, so we have to tell our component that
and also remove the unnecessary multiplication with 1024
(the field previously returned the value in MiB)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Restore may be a long running operation, as it goes over the common
create API path we can reuse the "start after create" for a "start
after restore" for free.
Add this as hbox layout, as else it looks like a lot of wasted space
in the right side of the window, especially when restoring a CT
backup (were the "unprivileged" checkbox is additionally there).
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
main use case is to sort by date, e.g., I just re-created a cluster,
did some VM/CT backups on a NFS dump of mine which already had quite
some backups. Now, on restore I knew that only the backups made
yesterday were interesting, so a sort by date would allow me to find
them all easily, thus this patch was born.
Simple frontend extraction of information from the volid, for now
only for backups as there's the only case were we have the info at
all. Called the model entry "vdate" for "virtual date".
Mayb adding the creation date to all entries could be a nice addition
for the API someday.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
show both, checkbox and hint in one row, there more horizontal space
than vertical.
s/Warning/Note/
default to on for convenience
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
The size of an unused volume is not visible to the user and trying to resize
an unused volume runs into a 'parameter verification failed' anyways.
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
Tested-by: Oguz Bektas <o.bektas@proxmox.com>
in some languages (e.g. German) the default (100) is too short for some labels,
resulting in cut-off text. We often use 120 in such cases, so we should
do here as well
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
for a pending change, it's 'revert's job to do this. pressing remove
doesn't do anything and it might be confusing for users.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
This cannot work anyway, and it simplifies some editors for
format-string backed properties, like the upcoming u2f settings
integration.
If such a value was passed to the backend one would get:
> invalid format - missing key in comma-separated list property
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
as else we'd show "Unknown" if one set the type explicitly to
"virtio", either over API/CLI or editing the configuration directly
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This adds an extra field to the AgentFeatureSelector that reflects the
change in qemu-server.
Changes since previous version:
* Use map rather than if/else if/else for type display string.
* Use Proxmox.Utils.unknownText for unknown type (should not occur with
regular use).
* Keep existing fields as boxLabel rather than fieldLabel, as they
look crammed with fieldLabel.
* Use __default__ for default option, to save space and replicate
behaviour in other places.
* Store option in advancedItems as it is a special case.
Even though the map only contains one item, it will be easily added to
in the future. There is only one item as there is no need to have a
string for "virtio" as it is not displayed because of __default__.
Signed-off-by: Matt Dunwoodie <ncon@noconroy.net>
move stopBtn into shutdownBtn as a menu item.
we can remove the setDisabled() call for stopBtn near the end, since when
shutdownBtn is disabled, so is stopBtn.
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
but remove the default domain '0000' before sending to the backend,
and add it if no domain is given in the config
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Spice foldersharing needs the webdavd daemon installed inside the guest.
This patch adds a hint to remind the user to install it in the VM.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
