Commit Graph

42 Commits

Author SHA1 Message Date
Thomas Lamprecht
03153d556b ui: dc: log, options, support: eslint fixes and code cleanup/refactoring
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-18 15:14:51 +02:00
Thomas Lamprecht
53e3ea8488 ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:42:36 +01:00
Thomas Lamprecht
8058410f40 ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
f6710aac38 ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Thomas Lamprecht
59807d1e3b ui: fix optionview caps
there's no caps.dc['Sys.Modify'] in our heuristic caps-for-frontend
and the === undefined check was wrong

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-04-01 17:14:42 +02:00
Thomas Lamprecht
df9ad35744 ui: dc/options: add max_workers setting
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:42:16 +01:00
Thomas Lamprecht
27af8ed019 ui dc/options: refactor render_bwlimits
while this /could/ (not benched marked in any way) be slower it
operates on so small data sets that this isn't worth it having double
the code lines.

A map + join is still quite readable and not yet "code golfy"

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:19:12 +01:00
Thomas Lamprecht
136103b0c9 ui dc/options: add trailing commas
just to avoid making those lines dirty again in a future property
addition..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-03-06 20:16:32 +01:00
Stefan Reiter
e670ffc28a fix #2611: gui: use backendUnit and pretty renderer
Slightly confusing with the units:
* Backend stores values in KiB/s
* Frontend displays MiB/s (which is a good choice when considering
  current generation network speeds as opposed to huge KiB numbers IMO)
* Renderer previously showed no units, which would usually be interpreted
  as Bytes/s

So add a pretty renderer that shows units and set backendUnit to submit
correctly converted values.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-03-06 19:56:49 +01:00
Thomas Lamprecht
6ddc083cb5 ui: dc/options: fix capabillities for u2f, bwlimits, ha settings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-29 15:20:32 +01:00
Thomas Lamprecht
17a1ffa1b9 ui: dc/options: add onlineHelp to u2f and ha edit window
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 19:35:17 +01:00
Dominik Csapak
7d01dad4ef gui: Bandwidth limits: increase labelWidth to 120
in some languages (e.g. German) the default (100) is too short for some labels,
resulting in cut-off text. We often use 120 in such cases, so we should
do here as well

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-11-27 18:40:30 +01:00
Thomas Lamprecht
d837e79e39 fixup whitespace error
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:36:19 +01:00
Thomas Lamprecht
a89375f6a3 ui: dc/options: add bandwidth limit editor
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-27 11:25:51 +01:00
Thomas Lamprecht
481816075e followup: add intermediate directory index for sdn/zones
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:58:01 +01:00
Thomas Lamprecht
61c2b43420 ui: dc/options: allow to set U2F
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-26 17:02:01 +01:00
Thomas Lamprecht
e86024b727 allow to set 'migrate' shutdown policy in datacenter options
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-11-25 19:54:44 +01:00
Thomas Lamprecht
8144a0ddc7 ui: dc/options: minor followup cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 14:58:19 +02:00
Thomas Lamprecht
6619af8d4f ui: dc/options: use proxmoxNetworkSelector for network
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-07-10 14:38:49 +02:00
Thomas Lamprecht
bb469a1176 ui: dc/options: allow to edit cluster wide migration settings
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-04-10 16:04:34 +02:00
Thomas Lamprecht
8f17b4965a ui: dc/options: allow to edit HA shutdown policy
add some helpers handling this, can be re used for adding the
migration field, maybe we want to move this to widget-toolkits parent
ObjectGrid class, a bit cleaned up.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-04-10 15:31:24 +02:00
Dominik Csapak
3f2cccbc73 allow deletion of mac prefix
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-22 14:01:40 +01:00
Dominik Csapak
5dc48aa804 set the default console in the gui when setting the option
until now, we only set the default console once on page load,
this enables to set it everytime the dc->options panel loads,
so also after setting an option

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-23 09:42:55 +02:00
Thomas Lamprecht
21026cceb7 reuse Toolkit from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
755b9083dc dc/OptionView: cleanup & use new features from ObjectGrid
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
8ea2c8709e use ObjectGrid from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
09cacce778 use KVCombobox from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
e7ade592e3 use Proxmox.Utils instead of PVE.Utils
some function are now in Proxmox.Utils instead, so we have to use that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
5720fafabc use Button from widget toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:37 +01:00
Dominik Csapak
dbed4c1c05 use TextField from proxmox-widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:37 +01:00
Dominik Csapak
ba93a9c665 move onlineHelp into classes from definition
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:13:12 +01:00
Wolfgang Bumiller
4050aade7f Add mac prefix to the datacenter options 2016-07-26 14:41:26 +02:00
Dominik Csapak
e79d3eb5b7 change default proxy test to noneText
instead of having "Do not use a proxy" simply
use PVE.Utils.noneText, which defaults to 'none'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-07-18 12:40:59 +02:00
Emmanuel Kasper
3c813f7416 Enlarge Object Grid first column default size
The framework value of 100 is not enough for many of our description
fields.
Setting this at the parent component level allow to remove
the end component setting.
2016-05-17 11:33:34 +02:00
Dominik Csapak
22f2f9d6c0 jslint: remove trailing commas
before ECMA5 trailing commas in arrays and objects
are forbidden

in jslint this is an error and cannot be deactivated

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:34 +02:00
Dietmar Maurer
185a77e555 reduce translation overhead 2016-04-05 11:10:52 +02:00
Dominik Csapak
bc5d0cf8db ext6migrate: change applyIf to apply
in the option view, change the applyIf to apply to
correctly show the 'Edit' button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-02 06:13:16 +01:00
Dominik Csapak
f2782813cd ext6migrate: fix model behaviour for KVComboBox
we used an empty value for the Key-Value ComboBox for defaults.
With extjs6, if the idProperty of a model is empty, they generate
a name for it, which breaks our logic for submitting
(currently we checked if this is empty, and send a delete command
to our api)
instead, we use the value 'default' and check for it when we submit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-02-29 15:27:15 +01:00
Emmanuel Kasper
c0b3df6e34 ext6migrate: listen to 'activate' events for panels inside a tabpanel
Using ExtJS6 a browser refresh (F5) do not send the 'show' event which we use to display the store as it did with ExtJS4.

At the momment only for tabs inside the datacenter tabpanel, since node and lxc tabpanels are not yet in manager6/
2016-01-22 11:24:20 +01:00
Emmanuel Kasper
8ca163bd36 Allow email adresses with a top level domain of up to 63 characters
Reapply fix for  https://bugzilla.proxmox.com/show_bug.cgi?id=716
which was missing in manager6/ directory
2016-01-22 11:24:14 +01:00
Dietmar Maurer
bac5bd135c rename manager5 to manager6 2016-01-22 11:24:10 +01:00