Add one more to show that also weekdays + intervals are possible
Further improve wording + reduce translation needs for others entries.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
When a user sees this the first time and wants to add a job he
shouldn't be confused what the default value means, so display this
through the emptyText property, which does not get submitted to the
backend.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Commit 3385399339c94 ("replication: keep retrying every 30 minutes in
error state") changed the retry behavior to not stop after the 3rd error
and then stick to half-hour intervals. This needs to be reflected in the
tests. The numbers here match. (1900 + 30*60 = 3700).
Commit fd844180a7efa ("replication: don't sync to offline targets on
error states) changed the retry behavior to check whether the target
node is online. If this is not the case we fail right away. This
introduced a dependency on PVE::Cluster::get_members which we now need
to mock. Tests currently use node names "node{1,2,3}", so I just mock
those 3.
Delete the strange sounding Note from the Removal dialog.
This was added to make sure that an user isn't confused that a Job is
still shown after 'removing' it. But it isn't needed as there is
already noted in the jobs status that it will get removed soon after
doing so, so the user sees that his action had the desired effect, no
extra note needed.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This will allow to disable replication, when for instance we
add a disk on a non-replicatable storage.
The option is hidden in the wizard, because at that time no VM
replication has been set.
we used a static emptytext at creation, which is wrong after editing
now copied from qemu/Options.js (the name), but instead of deleting the
hostname on the backend on an empty field, we set it to CT<VMID>
(this is also the default in the wizard)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
there were a number of problems in how we reselected vms when they
migrated and selected:
we relied on the data in the configpanel to be static, but since
pveselnode is a reference, it actually changes when the resourcestore
changes
also, handling the reselection as a response to the statusstore failure
is very inconsistent, because we know exactly when a vm moves node in
the tree
this patch removes the whole configpanel vm migration code,
and lets the tree handle it
for this, we have to check if we have to reselect the entry,
deselect it manually and after the treeupdate reselect it
also in the right click selection check we have to check if it is
already selected, else the next selection will get canceled
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with using suspend/resumeEvents the reselection of vms when migrating,
was not working correctly, fixing this by resuming before selecting
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The status '-' can confuse users, as it could indicate something is
missing, whereas OK indicates everything is alright (which is the status
we want to show)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
so we always show one decimal place
(instead of all with seconds and none with minutes, hours, days)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
to show the number in the url fragment instead of 'replication'
also change the itemid in the datacenter to 'replication' from 'replica'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of getting the repoid from .git/refs/heads/master
using HEAD as commit also means we get the correct commit hash for when
building the package (e.g. when building from stable-4)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
API calls return dates in seconds where the JS Date() constructor
wants millisecond.
For the correct computation use render_timestamp_human_readable.
A similar fix was commited in 4092576b1b
for VMs but Containers missed the fix.
To have consistency with the CLI tools `pveceph destroyosd` command.
This is also more clear about the resulting action, as 'Remove' could
also just mean 'Remove from Config', for example.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Each command may not run longer than 10 seconds. This avoids
situations where no output gets generated because of a infinitely
hanging command (e.g. check for dead NFS storage)
Also ensure that commands are separated with a new line from each
other to improve readability.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
In a previous commit, the inputField of SafeDestroy.js was converted
from a numberfield to a textfield to allow ceph pools names to be
entered.
This means the type of 'value' changed from number to string and
the strong equal test === was failing against a numeric id.
To solve this, we now always stringify the resource id before comparing.
