Commit Graph

42 Commits

Author SHA1 Message Date
Fiona Ebner
a2b8ac2e21 ui: backup restore: validate name
Use the same validation as the guest creation wizards do to catch
errors early, before sending the API request.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2023-04-24 12:09:52 +02:00
Thomas Lamprecht
a707bed6dd ui: ct restore: put mountpoint-erasure note on new line
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-07-07 10:08:02 +02:00
Fabian Ebner
5f855ccf27 ui: restore: improve warning for restoring container with same ID
It's not clear to users that the "VM data" includes mount point
volumes including those that are not marked for backup. This is
different from VM restore, where volumes attached at drives not
present in the backup will be kept around as unused volumes.

Several (supposedly newer) users got tripped up by this over the
years, the latest report being [0]. The long term plan is to make the
restore dialog more flexible to be able to select actions for disks
individually, but that will take a bit of time. In the mean time, make
the warning more explicit.

[0]: https://forum.proxmox.com/threads/111760/#post-482045

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-07-07 10:03:39 +02:00
Fabian Ebner
b61d079afc ui: restore: fix syntax error introduced in previous commit
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 11:29:42 +02:00
Thomas Lamprecht
8ce4c52480 ui: restore overrides: switch from column to hbox+panel layout
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-28 11:12:19 +02:00
Fabian Ebner
6161093e26 ui: restore: display "Hostname" for container
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 10:45:17 +02:00
Fabian Ebner
c7f66bd038 ui: restore: group override settings in a fieldset
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 10:45:17 +02:00
Fabian Ebner
1ad2651202 ui: restore: allow override of some settings
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 08:43:36 +02:00
Fabian Ebner
47520da33a ui: restore: disallow empty storage selection if it wouldn't work
Namely, if there is a storage in the backup configuration that's not
available on the current node.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-04-28 08:43:36 +02:00
Thomas Lamprecht
70aaf893b8 ui: backup restore: add hint to window title on overwrite restore
we prompt for confirmation in that case anyway, but some subtle, but
extra difference may still help

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:46 +02:00
Thomas Lamprecht
0e593799aa ui: backup restore: show "make unique" field also for self-overrride-existing
For example, relevant if the filterVMID checkbox got turned off. But
a user may also want to make the restored VM unique in other cases
too.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:45 +02:00
Thomas Lamprecht
ce60366ff3 ui: backup restore: use displayEdit field for guest selector
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:27 +02:00
Thomas Lamprecht
d3de9b555a ui: backup restore: rework to leverage more viewcontroller and cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-04-23 13:26:25 +02:00
Thomas Lamprecht
d290acc84d ui: live-restore: refine notice
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 15:20:53 +02:00
Thomas Lamprecht
6da2926cbc ui: CT restore: make privilege level a tri-state radio group
Default to keeping the state of the archive, as that has the highest
chance to fully work, but allow to enforce either level.

It'd be good to add some more feedback of the to be restored guest,
i.e., the whole config..

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-24 15:18:44 +02:00
Thomas Lamprecht
52b31ee327 ui: live restore: make warning to a shorter note
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-15 17:21:47 +02:00
Stefan Reiter
878bbf0b96 ui: restore: add live-restore checkbox
Add 'isPBS' parameter for Restore window so we can detect when to show
the 'live-restore' checkbox.

Includes a warning about this feature being experimental for now.

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2021-04-15 17:18:40 +02:00
Fabian Ebner
9ae4a024f0 ui: restore: fix bandwidth limit behavior
by allowing zero and updating the field name. Otherwise the hint mentioning zero
is wrong. Also, it's not only a read limit as the emptyText already indicates.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-03-15 13:26:05 +01:00
Thomas Lamprecht
53e3ea8488 ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:42:36 +01:00
Thomas Lamprecht
8058410f40 ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
f6710aac38 ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Thomas Lamprecht
2a4971d8c9 ui: eslint: fix trailing spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:29:55 +01:00
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Fabian Ebner
6fe863ba7e Improve storage selection on restore
Previously, the blank '' would be passed along and lead to a
parameter verfication failure.

For LXC the default behavior in the backend is to use 'local', so
disallow blank and auto-select the first storage supporting'rootdir'
instead.

For QEMU the default behavior in the backend is to use the
original layout from the backup configuration file, which
makes sense to use as the default in the GUI as well.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-05-06 16:23:40 +02:00
Dominik Csapak
0545b2a560 ui: window/Restore: fixup unit conversion for bwlimit
vzdumps bwlimit is in KiB, so we have to tell our component that
and also remove the unnecessary multiplication with 1024
(the field previously returned the value in MiB)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
24c55f4143 ui: backup restore: add start-after-restore checkbox
Restore may be a long running operation, as it goes over the common
create API path we can reuse the "start after create" for a "start
after restore" for free.

Add this as hbox layout, as else it looks like a lot of wasted space
in the right side of the window, especially when restoring a CT
backup (were the "unprivileged" checkbox is additionally there).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-05 10:45:23 +01:00
Thomas Lamprecht
a331258a87 ui: backup restore: use new bandwith limit component
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-05 10:45:23 +01:00
Christian Ebner
677bb0e87b ui: Restore: Fix error where the textfield did not default to next free VMID
This was introduced when refactoring our seprated CT & VM ID
selectors into an unified one in
commit ed416f2024

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-04-10 09:09:10 +02:00
Thomas Lamprecht
8b030d0848 ui: restore: add tooltip for unique checkbox and declare static
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-04-04 12:37:17 +02:00
Christian Ebner
c517e21226 fix: #1218 Expose unique MAC address generation on restore of VMs and CTs in UI
Adds a checkbox to the restore window, allowing the user to avoid MAC address
collisions when restoring a VM/CT to a different vmid.
When restoring to the same vmid the checkbox is not visible.

Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
2019-04-04 11:54:31 +02:00
Dominik Csapak
21ef191b66 jslint fixes
type confusion: value is int and string
let is not recognized by our jslint version yet, so
use var for now

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-02-19 12:08:23 +01:00
Oguz Bektas
a18927017f unprivileged:true by default in restore window
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
2019-02-19 11:52:22 +01:00
Thomas Lamprecht
9fa4ce6d74 ui: restore: add bandwidth limit field
Let user input MiB/s as values in the KiB/s range are not that handy
and would make even smaller backups need several hours to restore,
days for bigger ones.

Try to give the user imformation about per-storage bandwidth limits
and how he can disable all of them.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-03-26 14:23:50 +02:00
Thomas Lamprecht
8cbc11a70c use TaskViewer & TaskProgress window from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
9fccc702ec use windowEdit from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
896c0d5019 use Checkbox from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Dominik Csapak
e7ade592e3 use Proxmox.Utils instead of PVE.Utils
some function are now in Proxmox.Utils instead, so we have to use that

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:38 +01:00
Dietmar Maurer
9cf2e84b93 add unpriviledged flag to container restore window. 2016-12-27 10:19:57 +01:00
Emmanuel Kasper
ed416f2024 Convert the VMIDSelector to a generic GuestIDSelector
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.

Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a  *VM* ID, which is confusing.
2016-12-19 07:31:27 +01:00
Dietmar Maurer
185a77e555 reduce translation overhead 2016-04-05 11:10:52 +02:00
Dietmar Maurer
16152937f8 reduce translation overhead 2016-04-04 16:59:52 +02:00
Dietmar Maurer
bac5bd135c rename manager5 to manager6 2016-01-22 11:24:10 +01:00