This moves the filters out of the grid header for the BulkActions and
puts them into their own fieldset above the grid. With that, we can
easily include a tags filter (one include and one exclude list).
The filter fieldset is collapsible and shows the active filters in
parenthesis. aside from that the filter should be the same as before.
To achieve the result, we regenerate the filterFn on every change of
every filter field, and set it with an 'id' so that only that filter is
overridden each time.
To make this work, we have to change three tiny details:
* manually set the labelWidths for the fields, otherwise it breaks
the ones in the fieldset.
* change the counting in the 'getErrors' of the VMSelector, so that we
actually get the count of selected VMs, not the one from the
selectionModel
* override the plugins to '' in the BulkAction windows, so that e.g. in
the backup window we still have the filters in the grid header
(we could add a filter box there too, but that is already very crowded
and would take up too much space for now)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
For a better screen-space utilization use two columns and remove the
local-storage warning, since this is rather obvious anyway.
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
[ TL: slight commit message rewording ]
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Better fit to the 800 px default width, especially as bulk shutdown
now also got some form fields that take up space.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
show both, checkbox and hint in one row, there more horizontal space
than vertical.
s/Warning/Note/
default to on for convenience
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
With introducing pmx-hint to pmg as well, by adding a 'pmx-hint' css-class
to proxmox-widget-toolkit, it makes sense to use the definition everywhere.
this patch drops the .pve-hint class from pve's css and replaces all occurences
in the GUI-source.
Signed-off-by: Stoiko Ivanov <s.ivanov@proxmox.com>
type confusion: value is int and string
let is not recognized by our jslint version yet, so
use var for now
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
only show warning in migration window and when a running lxc container
is chosen
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
Co-Authored by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
there we implemented deleteEmpty, which we can use in some cases.
this also fixes a bug in the ControllerSelector where
an empty field would be allowed (but should not)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we have translated 'Target Node' already and I add a translation for
german and italian for 'Parallel Jobs' in the next translation update
patches.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this adds a default filter for bulk start and stop, so that only the
relevant vms are visible (stopped and started respectively)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this is mostly copied from MigrateAll.js, but a more generic way,
to allow startall and stopall to also use it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
