Commit Graph

14 Commits

Author SHA1 Message Date
Max Carrara
9536d5ef92 ui: cert upload: fix private key field sending empty string
The private key's field is now excluded from the upload form's
JSON data if it's left empty.

Prior to this change, the form still used an empty string for the
private key's field, even if no key was provided by the user.
Because the key's field is marked as optional in the upload cert
API endpoint, JSONSchema validation would therefore fail.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Max Carrara
1904262b95 ui: cert upload: use inputpanel for certificate upload
This change replaces the the certificate upload form's items with
a single inputpanel widget. The components for the key and cert fields
are preserved as-is. Hardcoded values are now explicitly set in
`onGetValues` instead of using hidden widgets.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Thomas Lamprecht
2f9fc81190 ui: node: rework layout of certificate viewer
Move the raw cert into a fieldset and collapse that by default, also
make it render monospace and pre-wrap whitespace.

Use a inputpanel to get top, col 1/2 & bottom layout so that rsa key
type/size and validity range can be rendered more compactly

n addition to that limit the whole windows height but make it
scrollable, this allows to sanely use the viewer on certs with many
SANs even on small window/browser sizes.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-19 15:14:18 +02:00
Thomas Lamprecht
d3d4873615 ui: node certificate: make panel only vertical scrollable
Otherwise, a browser window breaks the responsive horizontal
flex-flow/grid-column resize, and just displays the vertical scroll
bar instead, which can look a bit odd.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Dominik Csapak
6a594c50cb ui: node certificate: make parent panel scrollable
The `ACME` panel may be rendered out of sight (overflow) when there
are enough SANs on the upper `Certificates` panel to push it down
enough and the browser/display height is too small.

Enable the `scrollable` config for the parent certificate view panel
to make ExtJS automatically add a scrollbar if the content overflows.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Thomas Lamprecht
3491bd184a ui: node certs: use new loadFile helper to avoid confusion
we did not handle those cert related files like SSH keys, so do not
suggest so.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
48bbb009c3 ui: node/certs: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
028e4cd309 ui: node certs: make delete button safer, add confirmation
IMO the behavior was really dangerous prev., possibly causing
downtime of API accessing stuff with a single mistaken click.

Follow our general pattern and ask for confirmation

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 11:10:16 +02:00
Thomas Lamprecht
8058410f40 ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
f6710aac38 ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Dominik Csapak
1f2497692a ui: node/{ACME, Certificates}: add stopUpdate on destruction
else the stores never stop updating

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-05-07 12:54:30 +02:00
Alwin Antreich
e81645f5de gui: cert: add public key type & size to certs view
by default the fields are hidden

Signed-off-by: Alwin Antreich <a.antreich@proxmox.com>
2019-07-23 08:16:55 +02:00
Dominik Csapak
16dedd0f6a add missing onlineHelp links
for:
* dc/Cluster
* node/Certificates
* qemu/CloudInit

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-14 12:01:39 +02:00
Dominik Csapak
c287e2336c add node/Certificates.js and use it
this adds the grid for showing the custom/builtin Certificates
and the means to upload and delete custom ones

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-04 16:11:00 +02:00