talked with Aaron off-list and he found it OK to drop this button now
that "Copy Details" became a "Copy All".
This reduces cognitive load on the user as there are half as many
buttons.
Rename "Copy All" to "Copy to Clipboard" now that there's only one and
drop the disable logic.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this causes jumps and is IMO rather irritating, keep hands off from
scrolling, that's best done by user/browser.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
to make it more clear that this is not the details, but a UI text
placeholder.
Add a `pmx-faded` class that reduced opacity, as there where recent
discussion about adding such a utility class to widget-toolkit anyway.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
by
* replacing the info button with expandable rows that contain the
details of the warning
* adding two action buttons to copy the summary and details
* making the text selectable
The row expander works like the one in the mail gateway tracking center
-> doubleclick only opens it.
The height of the warning grid is limited to not grow too large.
A Diffstore is used to avoid expanded rows being collapsed on an update.
The rowexpander cannot hide the toggle out of the box. Therefore, if
there is no detailed message for a warning, we show a placeholder text.
We could consider extending it in the future to only show the toggle if
a defined condition is met.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
inline the transformation for the health store and also avoid setting
raw data from the outside
and drop some bogus comments along the way, first one should mostly
use "why?" not "what happens?" comments and second, commenting
straight forward things always makes one pause and recheck everything
far to often, as a comment indicates there something non-obvious
happening.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
we incorrectly used 'total' as 100% of the to recovered objects here,
but that containst the total number of *bytes*.
rename 'toRecover' to better reflect that the unit is 'objects' and
use that as total
reported by a user:
https://forum.proxmox.com/threads/bug-ceph-recovery-bar-not-showing-percentage.91782/
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
there was a spurious leftover single quote("'"), that prevented
the correct css class to be inserted
(e.g., fa-exclamation' instead of fa-exclamation)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Looks already OK at that size, and one gets a better overview.
We have a slightly complex layout here (to columns which should be
above each other) so we cannot just use the generic helper, but
that's OK here - it *is* a special view.
Note, not all people use full-sized windows all the time, so the
widths here must not only be considered in terms of display
resolutions...
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
they live there now, so we can delete them here and use the ones from
widget-toolkit instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
shows a runningChart (like for reads) for the recovery speed
also shows a progressbar of the health percentage of the cluster
with an estimate of how long the recovery might need
(unhealthy objects) / (objects per second)
only show them when a recovery is ongoing or there are unhealthy
objects
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this fixes the dashboard when one views it on a node
alternatively, we can add a node specific metadata api call
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of hardcoding the width of the panels,
use a columnlayout and use one column for screens < 1900 width
and two columns for screens >= 1900 width
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Split PVE specific models, which where not moved to the general
widget toolkit, in a separate folder: data/models/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this adds the summary as first line,
and the long warning message as monospaced text (like on the console)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
in luminous, the output of the status/health has changed (again),
so we have to access the correct properties
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
they restructured the json structure, so we have to adapt to it.
additionally, we now have a 'detail' property for the messages
which we show on a click of the 'info' button in the new actioncolumn
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
they restructured the json interface
(e.g. they removed the timechecks from ceph status)
so we have to generate those differently
also make the whole thing more robust to changes,
as in do not bail out if one thing is missing, but check the needed
data only when we need it and omit that part
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch changes the ceph dashboard
now we show the information in a more graphical way, namely:
the overall status is displayed by a big icon (+health)
the warnings/errors are in a list (with severity)
we show more detailed information about monitors, osds, and pgs
we show the usage of the cluster as a gauge graph, and
the reads, writes and iops as running charts (the last 5 minutes)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
