A user may set the `iothread` option and then change the bus type to
something which does not support it (sata, ide), while we disable
it the previously set value remains, which is confusing.
An user could think he coulkd trick the Wizard into using iothreads
for SATA/IDE but we just ignore the value in this case.
Set iothread to false in the case it gets disabled.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
If not, the following could happen:
* user has a VM with two disks attached to a LSI controller
* adding a third disk, he notices the iothread option, and clicks it
* the scsihw type for all disks is changed now to virtio-scsi-single
* on next cold restart, STOP 0x0000007B INACCESSABLE_BOOT_DEVICE for a Windows VM
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
It isn't needed as its obvious that the table below show the
configuration. It just takes away space.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this hides not usuable buttons for qemu
e.g. start/shutdown for templates
migrate for non-cluster setups
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Camel Case names for component alias follow Ext recommended practises
and are used otherwise everyelse in the code base.
No functionnal changes, aliases for these components were not used
anyway.
This will allow to disable replication, when for instance we
add a disk on a non-replicatable storage.
The option is hidden in the wizard, because at that time no VM
replication has been set.
there were a number of problems in how we reselected vms when they
migrated and selected:
we relied on the data in the configpanel to be static, but since
pveselnode is a reference, it actually changes when the resourcestore
changes
also, handling the reselection as a response to the statusstore failure
is very inconsistent, because we know exactly when a vm moves node in
the tree
this patch removes the whole configpanel vm migration code,
and lets the tree handle it
for this, we have to check if we have to reselect the entry,
deselect it manually and after the treeupdate reselect it
also in the right click selection check we have to check if it is
already selected, else the next selection will get canceled
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the edit window has 3 radiobuttons (spice,device,port)
and a checkbox for usb3 (which gets disabled and checked
if you choose a usb3 device)
also it makes use of the help feature
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
By default when no target storage is selected in the clone panel, the clone
will use the same storage*s* as the source.
This was not obvious to guess that from the panel.
Up to now the Migrate function had a first class button in the toolbar,
but the Clone function didn't.
With this button the toolbar still fit correctly in a smaller
1280 pixel wide display.
This allows to add the components in each column in the order they
appear in the Clone Window.
References from child components are kept in an object in the parent
component so it should be the same performance-wise (contrary to to Ext.ComponentQuery
which is doing DOM parsing)
The pool membership relates here to the VM membership, not
the storage membership, so it makes sense to move it closer
to the VM ID / VM name form fields.
The snapshot selector was known to confuse first time pve users.
Some wondered that they had no snapshot called 'current' in their
snapshot trees, and other thought that snapshots would be included
in the copied image.
So before displaying the Clone Window, do an API call to verify
if the source VM has snapshots.
Until now we disabled the submit button, based on
the feature API call where we tested if the selected VM, and its snapshot
can be used as the source of a clone.
This had the following problems:
* the feature test for copy clone / linked clone always returned true,
since the passed paramaters were already filtered before user input
(ie we only allowed a linked clone to be selected if the source VM is
a template, or a snasphot to be selected if existed on source VM)
* the guest ID input field was not validated
With the current patch, the validation is now made on each of the form
fields. verifyFeature() is still used to populate a list of valid nodes
passed to the Node Selector.
we expect a gettext on a single line and to not contain any
variable/logic, so we remove the long text from it altogether (since we
do not want to translate that at the moment), and we rearrange the code
so that gettext only contains strings
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
extjs saves the state including the sorter, but cannot serialize the
sorter function. when restoring the state, it is not a valid sorter,
so we delete it before saving
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.
Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a *VM* ID, which is confusing.
