Commit Graph

258 Commits

Author SHA1 Message Date
Max Carrara
9536d5ef92 ui: cert upload: fix private key field sending empty string
The private key's field is now excluded from the upload form's
JSON data if it's left empty.

Prior to this change, the form still used an empty string for the
private key's field, even if no key was provided by the user.
Because the key's field is marked as optional in the upload cert
API endpoint, JSONSchema validation would therefore fail.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Max Carrara
1904262b95 ui: cert upload: use inputpanel for certificate upload
This change replaces the the certificate upload form's items with
a single inputpanel widget. The components for the key and cert fields
are preserved as-is. Hardcoded values are now explicitly set in
`onGetValues` instead of using hidden widgets.

Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Signed-off-by: Max Carrara <m.carrara@proxmox.com>
2023-03-17 11:20:43 +01:00
Fiona Ebner
0d06378c66 ui: bulk start/stop: align capability checks with backend
The backend requires VM.PowerMgmt, not Sys.PowerMgmt for bulk start
and bulk stop.

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2023-03-15 18:21:50 +01:00
Stefan Sterz
056e5aad9b subscription/summary/backup: stop setting the background color
setting the background color in js code adds that property as a style
attribute to the element. that makes it hard to alter later via css
and makes it hard to dynamically change the color e.g. if we want to
add different themes. the background color for these elements are
white already anyway, so just remove them here.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2023-03-08 17:55:41 +01:00
Thomas Lamprecht
dd604328aa ui: node config: code cleanups
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-02-22 16:16:37 +01:00
Thomas Lamprecht
44705bf65c ui: fix capability check for when to disable bulk migrate
In the resource tree context menu and in the node panel.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-02-22 16:15:50 +01:00
Lukas Wagner
ab78e7e2d0 ui: node options: make text for wakeonlan option a bit more descriptive
If one is not familiar with the underlying configuration option,
one might think that one can enable Wake-On-Lan for a node with this
option. It was not really clear (at least without RTFM ;) ) that a
MAC address is supposed to be entered here. The added text should
hopefully make this a bit more clear.

Also increased the label width a bit, so that a full MAC
address can be properly displayed.

Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
2023-01-24 16:13:43 +01:00
Thomas Lamprecht
04389e49d6 ui: factor out not found rendering to common helper
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-21 14:32:53 +01:00
Thomas Lamprecht
31fcdc1e8e fix #4194: ui: clarify that it's actually a bulk shutdown, not a stop
As some users where confused by the usage of "Stop", which we
normally reserve for a hard-stop.

And yes, while the bulk shutdown formerly always had a timeout armed
hard-stop hard coded, it was still subtle and we recently exposed
control on that via the API an UI, so use shutdown to be more in line
with the CT/VM naming, e.g., in their power menus.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2023-01-14 17:41:04 +01:00
Thomas Lamprecht
87f43acb8e ui: improve ZFS pool name validator accuracy
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-19 15:56:46 +01:00
Thomas Lamprecht
58de15074f ui: node disk manage: mark using ZFS reserved pool names as invalid
ZFS will die anyway later so catch this earlier for better UX

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-18 18:27:56 +01:00
Thomas Lamprecht
2db62238ee ui: disk manage: move dRAID options into field set
to avoid an overly asymmetric form field balance

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-17 19:29:21 +01:00
Thomas Lamprecht
049b783638 ui: disk manage: rework assembling dRAID options
Simply use onGetValues to assemble the dRAID config, if any.

We do not need to bother with setting values as this is only for
creates, never for edit/displays.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-11-17 19:14:08 +01:00
Stefan Hrdlicka
84cf9e4f4b fix #3967: enable ZFS dRAID creation in WebGUI
add fields for additional settings required by ZFS dRAID

Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
2022-11-17 18:47:23 +01:00
Fiona Ebner
cf6b65a292 ui: {guest, node} summary: use correct unit for CPU usage
One could also think about showing something like '% of N CPUs', but
this can be inaccurate for older data, because the number of CPUs can
change.

Reported in the community forum:
https://forum.proxmox.com/threads/117362/

Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
2022-11-07 11:20:59 +01:00
Thomas Lamprecht
2f9fc81190 ui: node: rework layout of certificate viewer
Move the raw cert into a fieldset and collapse that by default, also
make it render monospace and pre-wrap whitespace.

Use a inputpanel to get top, col 1/2 & bottom layout so that rsa key
type/size and validity range can be rendered more compactly

n addition to that limit the whole windows height but make it
scrollable, this allows to sanely use the viewer on certs with many
SANs even on small window/browser sizes.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-19 15:14:18 +02:00
Thomas Lamprecht
d3d4873615 ui: node certificate: make panel only vertical scrollable
Otherwise, a browser window breaks the responsive horizontal
flex-flow/grid-column resize, and just displays the vertical scroll
bar instead, which can look a bit odd.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Dominik Csapak
6a594c50cb ui: node certificate: make parent panel scrollable
The `ACME` panel may be rendered out of sight (overflow) when there
are enough SANs on the upper `Certificates` panel to push it down
enough and the browser/display height is too small.

Enable the `scrollable` config for the parent certificate view panel
to make ExtJS automatically add a scrollbar if the content overflows.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-10-10 16:28:28 +02:00
Fabian Grünbichler
dc17baee74 www: subscription: add Signed/Offline status
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2022-09-06 11:02:59 +02:00
Thomas Lamprecht
1992003e00 ui: move new node options below hosts entry
avoid splitting the related DNS and Hosts settings in the middle

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2022-05-12 16:40:41 +02:00
Daniel Tschlatscher
5837726350 fix #3994: ui: add Options entry in the node System menu
Add the subentry "Options" in the "System" menu to expose some
options in the GUI which were not exposed before.

Added a new file for displaying and editing the node config options
which were not exposed through the GUI yet. Namely those are the
settings for wakeonlan and startall-on-boot-delay. Edited the
Makefile to include the newly created file.

Signed-off-by: Daniel Tschlatscher <d.tschlatscher@proxmox.com>
2022-05-12 16:38:07 +02:00
Stefan Sterz
742de03d5a ui: move NotesView panel and NotesEdit window to widget kit
this removes the NotesView panel and NotesEdit and replaces them with
with the version from the widget kit. requires a bump of the widget
toolkit.

Signed-off-by: Stefan Sterz <s.sterz@proxmox.com>
2022-04-13 11:35:30 +02:00
Fabian Ebner
85df37251f ui: lvm: better convey space information
Namely, that it's just assigned/reserved space, not necessarily
actively used. Selection of forum threads about this confusion (of
dozens more):

https://forum.proxmox.com/threads/93820/
https://forum.proxmox.com/threads/52899/
https://forum.proxmox.com/threads/52929/

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-01-28 12:03:20 +01:00
Fabian Ebner
545f94e7d2 ui: node: zfs: use ZFSDetail window from widget-toolkit
The only functional differences I could see are the missing
defaultValue for 'Scan' and the reduced height. For restoring the
height, there is a proposed patch for widget-toolkit.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2022-01-13 12:54:03 +01:00
Fabian Ebner
392e3cf11d sorters: use correct property 'direction' and keep default 'ASC'
Ext.util.Sorter does not have an 'order' property, so 'order: DESC'
didn't have an effect. The default is 'ASC' and it is arguably the
preferred direction for all affected sorters anyways.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-12-16 10:11:48 +01:00
Fabian Ebner
6c356c927b partially fix #2285: ui: disk create: allow selecting partitions
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-11 21:51:04 +01:00
Fabian Ebner
87f1600869 ui: zfs create: switch to using widget-toolkit's multiDiskSelector
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-11 21:51:01 +01:00
Fabian Ebner
bccfb43f9f ui: node: storage removal: add checkbox for cleaning up disks
and factor out a SafeDestroyStorage sub-class to avoid duplication.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-10 14:03:27 +01:00
Fabian Ebner
14066c09ce ui: node: add destroy menu for directory, lvm, lvmthin, zfs
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-10 14:03:27 +01:00
Fabian Ebner
92a1b603f7 ui: node: lvmthin: add volume group to columns
to be able to identify thin pools even if they have the same name.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-10 14:03:27 +01:00
Fabian Ebner
978e2aeb93 ui: node: directory: use gettext for 'Directory'
It's also localised when adding a storage for example.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-11-10 14:03:27 +01:00
Dominik Csapak
8fc2d93898 ui: improve ACME edit/apply button visibilty
multiple users were confused[0], as they did not interpret the 'icon only'
in the toolbar as a button (and it did not help that we prevented
the cursor to change)

to improve it, make the button a normal one again, and add some
text for context (this is more inline what we do elsewhere in toolbars)

0: https://forum.proxmox.com/threads/acme-over-dnschallenge-failing.71902

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-09-09 17:35:43 +02:00
Dominik Csapak
fc2ff3e889 ui: node/ZFS: add zstd to possible compression methods
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-07-30 17:04:05 +02:00
Fabian Ebner
b2f17bfd61 ui: node status: use repo status widget from widget-toolkit
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-29 10:47:02 +02:00
Fabian Ebner
fac49b9a36 ui: node: repos: add online help
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-15 14:38:49 +02:00
Thomas Lamprecht
1a89220277 ui: node status: prioritize non-production and fix ok case
Non-production repositories will always pull in their newer software,
so even if enterprise+subscription is OK we should mark it with
priority if, e.g., pvetest is enabled.

There was also a bug regarding the all OK state

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 15:33:45 +02:00
Thomas Lamprecht
72931fec68 ui: node status: rework repo status texts/icon
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 14:47:17 +02:00
Thomas Lamprecht
e5457c1eb8 ui: node summary: slightly increase panles height
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 10:58:57 +02:00
Thomas Lamprecht
e4d3f62656 ui: status: improve reuse of gettext
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-05 10:47:58 +02:00
Thomas Lamprecht
2f79184cc0 ui: node status: small code size reduction
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 22:09:36 +02:00
Thomas Lamprecht
4b832488aa ui: node/status view: padding-reduce fixup
overlooked the inline one, and that caused some layout troubles

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 22:09:17 +02:00
Thomas Lamprecht
98f73c48d2 ui: node/status view: reduce quite generous paddings
As both, the whole panels body and the actual items all had their own
padding it added up quite a bit.

Some padding is good to avoid elements being "glued" to the parent
borders, but that can be done with also with ~15 px vs. 30 px on each
side, so no need to waste that much extra space we can use in some
languages to render content

Added benefit, the status panel now is more in sync with the RRD
panels regarding content start/end.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:52:05 +02:00
Thomas Lamprecht
bcfcf87bf9 ui: node summary: rework repo status output
the icon on the left side look a bit weird here, as the lines
directly above had none and the actual status which the icon tried to
emphasize is on the right anyway.

Rework also the output.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:18:43 +02:00
Thomas Lamprecht
e950ab260d ui: node summary: followup code cleanup
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-04 21:17:35 +02:00
Fabian Ebner
2bb75d1ea3 ui: node summary: show repository configuration status
I tried to use itemid and lookupreference for the nodeStatus item, but couldn't
get it to work, so I factored it out.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-07-04 20:58:33 +02:00
Thomas Lamprecht
56bc50b8a8 ui: adapt task-history icon, use same as in PBS
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-03 02:41:02 +02:00
Thomas Lamprecht
7810be88a4 Revert "ui: temporary disable repo config entry"
This reverts commit 48dd979c4b.
2021-07-03 01:33:42 +02:00
Thomas Lamprecht
48dd979c4b ui: temporary disable repo config entry
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-03 01:26:44 +02:00
Thomas Lamprecht
02c634bcdc ui: node: always show Repositories panel in navigation
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-07-01 18:40:09 +02:00
Fabian Ebner
2292a19637 ui: add panel for listing APT repositories
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-06-30 21:03:38 +02:00