Commit Graph

115 Commits

Author SHA1 Message Date
Dominik Csapak
928028c1f6 ui: panel/ConfigPanel: return early on no selection
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:43:08 +02:00
Dominik Csapak
c8d72c05ca ui: panel/ConfigPanel: change ui class to pve-nav
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:43:08 +02:00
Thomas Lamprecht
df22311b50 ui: nav: move bg-color override to CSS class
colors overrides really must not happen inline...

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-23 18:04:16 +02:00
Dominic Jäger
90519f8a55 ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
a9e7018401 ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
193df2f373 ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
202298c10b ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
ee3903451e ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominik Csapak
c95917c263 ui: use pmxInfoWidget instead of pveInfoWidget
to prevent that they further diverge than they alread have
(pmxInfoWidget got an additional function that is compatible)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-23 10:37:55 +02:00
Dominik Csapak
e3c4b75d9e ui: panel/StatusView: use from widget-toolkit instead
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
2874be00f2 ui: Utils: use updateColumns from widget-toolkit
it was moved there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
a8ea1b6876 ui: use some icons from widget-toolkit
we moved them there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-04-22 18:34:34 +02:00
Dominik Csapak
1bd7bcdbf1 ui: Utils: use render functions from widget-toolkit
they live there now, so we can delete them here and use the ones from
widget-toolkit instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-22 18:34:34 +02:00
Thomas Lamprecht
e67d454a18 ui: use byte unit and power-of-two base for memory rrd graphs
To better match the gauge in the current status infobox in the same
summary panel, which is already using a format where KiB is 1024

the latter needs a (not yet bumped) widget toolkit update to 2.5-2 or
newer, just setting now to avoid forgetting it.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-04-15 19:31:03 +02:00
Thomas Lamprecht
53e3ea8488 ui: eslint: enforce "no-extra-parens" rule
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:42:36 +01:00
Thomas Lamprecht
8058410f40 ui: eslint: fix various spacing related issues
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:39:15 +01:00
Thomas Lamprecht
f6710aac38 ui: eslint: fix trailing comma and comma related whitespaces errors
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:31:03 +01:00
Thomas Lamprecht
2a4971d8c9 ui: eslint: fix trailing spaces
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-01-19 17:29:55 +01:00
Dominik Csapak
8267aa6375 ui: fix usage of findRecord
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2020-11-26 10:52:07 +01:00
Fabian Ebner
a83c659a11 config panel: allow new nodes to be added later
in preparation for dynamically loading nodes for content-type-specific views.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2020-11-15 18:41:11 +01:00
Thomas Lamprecht
497c94f236 ui: running chart: assign getTime directly
no sense in doing it everywhere the Date variables are used, if it's
the only  thing we do on them.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:35:07 +02:00
Thomas Lamprecht
ca0267fdca ui: ceph status/running chart: disable trackRemoved
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:30:51 +02:00
Thomas Lamprecht
e75392ceb3 ui: running chart: avoid breakage if tooltip was on deleted record
if we cleanup records and there was a "stale" tooltip on one of them
we get an access on undefined value exception here

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:29:06 +02:00
Thomas Lamprecht
eb7f91977b ui: comment length cleanup to improve readability
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-07-22 10:27:45 +02:00
Thomas Lamprecht
3bbce3b8cd drop jslint lines
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2020-06-06 18:11:47 +02:00
Stefan Reiter
6751013a1b gui: never collapse notes for templates
There's no graphs on screen, so no reason to collapse the notes to save
space. Besides, it looked a bit funky expanding the notes on smaller
screens, since they always jumped to the bottom to fill the space...

Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
2020-05-06 16:24:37 +02:00
Thomas Lamprecht
300c0f736b fix #2552: ui: allow to collapse notes panel from guest summary
Allow to collapse and expand the "Notes" panel on the virtual guests
summary panel.

Further add a browser setting to control the default behavior, one
can chose from:
 * expand on show (default)
 * collapse on show
 * collapse if there are no notes

This way users can make slightly better use of the available screen
space for the guest status.

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Co-developed-by: Stefan Reiter <s.reiter@proxmox.com>
2020-01-14 11:13:42 +01:00
Thomas Lamprecht
8dc7c7af99 grammar fix: s/does not exists/does not exist/g
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-12-13 12:51:22 +01:00
Dominik Csapak
ed3e711e29 gui: set minWidth for node/guest Summary
to make sure the panels are always readable

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Dominik Csapak
f973c5b262 gui: let users choose the number of columns
introduce a new browser setting, with which the users can choose between
the automatic mode of choosing columns, or always using 1/2/3 columns

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Dominik Csapak
bbc833099e gui: GuestSummary: choose columns based on container width
instead of the viewport width. This means that the number of columns can
change when the tree width changes, not only on browser window resize

for this to work reliably, we have to change the structure of the first
two panels, so that they are in one container for non-templates. if
we do not do this, there are some weird glitches on resizing with the
scrollbar

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Dominik Csapak
df0875c20e gui: refactor {lxc, qemu}/Summary to panel/GuestSummary
they are both similar enough to have it only once

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-12-09 14:20:37 +01:00
Thomas Lamprecht
ec5052600f js: fix some common typos found with codespell
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2019-06-15 10:44:43 +02:00
Dominik Csapak
375d291810 gui: show lock in status bar of vms/cts
also add 'tbarSpacing' parameter to ConfigPanel, that controls
the spacing after the title

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2019-03-21 18:39:27 +01:00
Dominik Csapak
02eb40cf3e fix notes gear tool
me was used before it was defined

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 17:30:22 +02:00
Dominik Csapak
9db54b1f76 accept type 'node' for NotesView and refactor it
so that we can use it for the notes of a node,
also changes the configuration to a static declaration,
this adds an 'edit' button for the node panel

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
abbf0eb74f let NotesView load itself
instead of needing to load from the outside, let NotesView handle the
loading itself

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-05-25 11:04:08 +02:00
Dominik Csapak
09153eaf2b show qmpstatus if available
this patch shows the qmpstatus if it is available on the summary in
parenthesis

this shows things like 'suspended' and 'io-error'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-30 11:02:08 +02:00
Dominik Csapak
aec9d2ece3 implement multiField renderer for infopanels
we can use this for fields which use more than one value of the
guest status

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-04-30 11:02:08 +02:00
Dominik Csapak
5ba37d7c0b make GuestStatusView declarative
use the cbind function to generate isLxc/Qemu to hide the
relevant fields, and cbind the nodename

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-27 10:52:09 +01:00
Dominik Csapak
ade55c154f add xtype to noteview so we can use it declaratively
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-23 11:01:28 +01:00
Dominik Csapak
e7f07a2efc show guest-agent provided ip address in qemu summary
this adds a new component 'AgentIPView' which
uses the qemu-agent api call to tries to get the ip information for
the guests

only for vms at the moment, since for containers you already
set it on their network tab

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-23 11:01:28 +01:00
Dominik Csapak
20d76d1a12 add ha info to the template summary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-22 14:36:40 +01:00
Dominik Csapak
3ff9bf5a7c add icons to summaries and improve spacing
also add a helper css class to use the png icons like fontawesome icons
and add the ha state to template summary

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-22 14:36:40 +01:00
Dominik Csapak
60fb2b99b4 add optional icon to InfoWidget
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-22 14:36:40 +01:00
Dominik Csapak
5ce972f6c5 fix #1573: show bootdisk usage on container summary
we have the information, so show it
this does not change the output for vms, where we do not have
any information about disk usage at all

if we add the 'disk' info to vms, it will magically work there then

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-09 14:42:56 +01:00
Dominik Csapak
d3ecda1274 StatusView.js: call renderer in context of field
so that we can access the field inside the renderer

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-09 14:42:56 +01:00
Dominik Csapak
4926300a26 InfoWidget.js: make printBar toggleable at runtime
we add a setPrintBar function, where we can make the
progressbar visible/hide it at runtime

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2018-02-09 14:42:56 +01:00
Thomas Lamprecht
ef4ef788d5 use InputPanel from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00
Thomas Lamprecht
0ee5a21ef1 use LogView from widget toolkit
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
2018-01-25 13:36:38 +01:00