This patch enables the backup checkbox by default for newly created
LXC mount points.
Hopefully this will help to avoid situations in the future where people
realize too late that the mount point has not been backed up when they
expected it to because they missed the checkbox.
The reason why `view.isCreate` is not passed directly is because
AFAIU the 'view.isCreate' can have one of three values:
* null - editing an existing mount point
* true - creating a new mp
* array('unusedX') - adding an unused disk again
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
this way, backend only settings do not get lost (like 'size', 'shared')
when editing in the gui
this was most obvious with the new pending options, as every time
we edited a mp, we lost its size, and even setting the options
to exactly the same as the originals, we still had the mp as
'pending', but without the size
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
They should not be required and result in exceptions thrown if this
component is used in combination with ExtJS debug sources
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
having this new selector on the left column makes it a better fit for
both possible edit situations, rootfs is now fully balanced and both
mp/rootfs kip the "skip replication" setting on the same place - in
sync with VMs
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
This allows the following non-problematic mount options for lxc
container mountpoints:
* noexec - Do not permit execution of binaries on the mounted FS
* noatime - Do not update inode access times on this filesystem
* nosuid - Do not allow suid or sgid bits to take effect
* nodev - Do not interpret character or block devices on the FS
Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
since in the wizard, the validity check happens before the
viewmodel can set the visible/enabled state so this is invalid there,
even if the remaining panel is valid
setting it to disabled by default, makes the fields 'valid' at the
beginning but retain their behavior
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this is a complete rework of the inputpanel (long overdue)
it uses a viewModel and viewcontroller to avoid the
multiple is zfs/root/bind checks and concentrate them
in one place
also some features get optimized (e.g. the noreplication checkbox)
adds a setNodename to the DiskStorageSelector so that we can bind
the nodename there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we had it previously on 8GB for containers, but with the refactoring,
this got lost. this patch changes this back
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
