this one would deserve much more, especially the newer backup job
detail and not-backed-up view should be split out and done in a
declarative way (view view-controller)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
findRecord does not match exactly, but only at the beginning and
case insensitive, by default. Change all calls to be case sensitive
and an exactmatch (we never want the default behaviour afaics).
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
In case that there are guests which are not covered by any backup job, a
notification is shown and a window with a grid can be opened to view
these guests.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
The new detail view for backup jobs shows the settings similar to the
edit dialog but read only. Additionally it does show a list of all
included guests with their volumes and whether these volumes will be
included in the backup.
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
Moving the following renderers to Utils.js to be able to use them in
more than one place:
* render_backup_days_of_week
* render_backup_selection
Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
rather than reducing the total job count during execution (and that
not for all cases) do some checks first and pass only the known good
nodes to the for-each-node-POST-request loop, so we can omit all
checks there.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Previous behaviour was bugged and displayed "Node is offline" for all
non-selected nodes (only 1 can be selected at a time).
Also fix progress window to show correct number of nodes in backup job.
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Iterate all (online) nodes client-side and call vzdump with the correct
parameters (according to the job selected) for each one.
Then, show a progress bar in a non-closeable modal-dialog, to ensure the
user stays on the Backup page during the /vzdump API calls. Any errors
that occurred will be displayed in a consolidated message box.
Includes a "confirm" dialog to not accidentally run a potentially large
backup job.
Curiously, the "pve-cluster-backup" data model seems to have been broken
entirely. I'm not sure how it was working before, but the changes in
this patch need it fixed, so include that as well (use "mode" instead of
individual flags + "compress" is not a boolean).
Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
Split PVE specific models, which where not moved to the general
widget toolkit, in a separate folder: data/models/
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
some function are now in Proxmox.Utils instead, so we have to use that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
most 'Remove' buttons we have used the same code pattern over and over,
with the StdRemoveButton we have a component which does all of this for
us
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
Do not focus anything here in the case he backup window gains focus
again. Else, if we click outside of the window the nodefield gets
always focused again - even if another field was focused previously.
This is a bit confusing, rather have no field focused at all -
especially as a blank value will be often used here.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
insideUpdate protects for a endless loop which gets caused if the sm
selection change callback updates vmidField which then triggers the
vmidField change callback which updates the selection model again,
and the circle starts again.
As this construct is rather confusing when looking first at the code
replace it with a temporary suspend of the change event during the
vmidField update.
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we set the pveNodeSelector to [] by default,
but filter by !node (![] == false), so that no vms are shown
this occurs, when the pveNodeSelector store loads after the store
for the vm list, which rarely happens
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
before ECMA5 trailing commas in arrays and objects
are forbidden
in jslint this is an error and cannot be deactivated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when selecting days in a backup job,
show every series of 3 or more days as range, instead
of single days
e.g. Monday-Wednesday instead of Monday, Tuesday, Wednesday
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
previously we displayed always something like: "mon,tue,wed"
now we use the full name of the day and the correct translation
making it (eg in german):
"Montag, Dienstag, Mittwoch"
i did not to choose the first 3 letters, because we cannot be
sure they are unique for all workdays in every language
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we wrongly assumed, that no compression argument for
vzdump meant 'no compression', instead it means 'lzo'
this patch mirrors that behaviour on the gui
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Added a column in the datacenter backup job overview to see if a job
is enabled or not. Added checkbox to the input panel, which enables
or disables a job.
This closes bug/feature request 492.
This patch was missing in manager6
