in my commit 685b7aa4c5
i introduced a bug with that an item gets selected
in the tree when you right click on it
also fix the function parameters
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we had the function for the cmdmenu at two
different places (resourcetree and resourcegrid)
move it to PVE.Utils to reuse code, and
also use it in pool members list
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the hotplugselector was not good to use,
and the options were confusing (empty was the default value, etc)
now we have checkboxes for each value, and if none are selected,
hotplug is disabled
also fixes the renderer when hotplug is set to '1' which
just means the default of 'disk,network,usb'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with this fix, we (again) allow ipv4 cidr to be as low as 8
also check the cidr for ipv6 and show the valid ranges in the
error text
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Strings like 'Linux 4.X/3.X/2.6 Kernel' are difficult
enough to visually parse, so don't append the internal
representation (l26) at the end: it does not bring any relevant
information to the user, and we usually don't display
internal representations in the GUI.
previously, we had a disk/memory usage column in the resource grid,
whose raw data were the bytes used, but we added a renderer
to display it as percentage
with this, the columns sorted by bytes and not by percentage,
which made the column rather confusing
with this patch, we add a real percentage column (where the
data is a float from 0 to 1) so it sorts correctly
also make the old columns show the used size in B/KiB/etc.
by default we still only show the percentage column
since the disk usage part was always zero with qemu guests,
leave it empty there
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we set new icons for the tree and grid
changes:
* new icons
* wider type column (bigger icons)
* use arrows true (uses arrows instead of +/- and gets rid of the
ugly lines in the tree)
* datacenter has icon instead of folder open/close
* "folder view" gets type icons for folders
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we used a factor of 2^10 when calculating, but
wrote MB,GB,etc which is not (entirely) correct
this patch changes the units to MiB, GiB, etc,
because this is more sensible than changing the calculation
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we used an empty value for the Key-Value ComboBox for defaults.
With extjs6, if the idProperty of a model is empty, they generate
a name for it, which breaks our logic for submitting
(currently we checked if this is empty, and send a delete command
to our api)
instead, we use the value 'default' and check for it when we submit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
includes the following fixes:
* remove all code related to the old java applet vnc client
(we do not use this anymore)
* move static configuration to class definition
* use Ext.ux.IFrame instead of widget.uxiframe (to be consistent)
* change listener from show to activate (for browser refresh)
* change deprecated autoScroll to scrollable
* remove novnc option from openVNCViewer function,
since we do not need this option anymore
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
ExtJS6 adds accessibility (aria) support to the framework, which means
special handling of space/enter key and panels title, and a lot of
warnings / errors in the browser console
Aria support will be reenabled after all the components are migrated to
ExtJS6
