Commit Graph

61 Commits

Author SHA1 Message Date
Dominik Csapak
bf96f60deb use IntegerField from widget toolkit
there we implemented deleteEmpty, which we can use in some cases.
this also fixes a bug in the ControllerSelector where
an empty field would be allowed (but should not)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:37 +01:00
Dominik Csapak
dbed4c1c05 use TextField from proxmox-widget-toolkit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2018-01-25 13:36:37 +01:00
Emmanuel Kasper
c2d4185b1d Fix #1523: Display the Max Backups field only if relevant
Signed-off-by: Emmanuel Kasper <e.kasper@proxmox.com>
2017-11-07 09:35:45 +01:00
Dominik Csapak
8b1ee8ff0d drop unnecessary check for 'local'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-07 12:35:14 +02:00
Dominik Csapak
3c23c0258b add new "RBD (PVE)" storage choice
this is for adding a pve managed ceph rbd storage, so that the user
just has to select the pool, and does not need to write the monitor
hosts and copy the keyring

the old "RBD" is renamed to "RBD (external)"

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-09-07 12:35:14 +02:00
Dominik Csapak
5222800148 fix #1385: display no rbd user by default
when having an rbd storage with no user, we displayed 'admin' by default,
this patch sets '' and will be overwritten from the backend if a value is set

when creating a rbd storage, the textfield still has 'admin' in
there by default

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-06-08 15:13:38 +02:00
Dietmar Maurer
f536f691ab ZFSEdit.js: correctly set 'nowritecache' on zfs plugin 2017-03-08 06:39:26 +01:00
Emmanuel Kasper
d5e771ce51 Rename 'create' to 'isCreate' in pveWindowEdit and subclasses
This fixes around 20 jslint type confusion warnings.
Also reduce the scope and document jslint warnings along the way.
No functional changes.
2017-03-02 10:36:35 +01:00
Dominik Csapak
93cdb62689 add type column to storage content view
and move the grouping feature in the class definition while changing
the text to a generic one

this allows us to group by all columns and still have meaningful
grouping headers

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-01-10 15:42:12 +01:00
Fabian Grünbichler
4e31f56f0f fix #1230: add blocksize for ZFSPoolPlugin
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2017-01-03 12:56:33 +01:00
Dominik Csapak
1b14c8750d make storage/template grid stateful
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:17:10 +01:00
Dominik Csapak
8a7e5598f1 add pveIntegerField and use it
this adds a subclass of Ext.form.field.Number with the settings for
Integers (allowDecimals: false and allowExponential: false and default
step size 1)

and use it where we only accept integers

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:14:06 +01:00
Dominik Csapak
ba93a9c665 move onlineHelp into classes from definition
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:13:12 +01:00
Dietmar Maurer
c8802a60b7 use auto-generated block IDs to reference online docu. 2016-10-13 11:26:06 +02:00
Wolfgang Link
9e9ab96f6d Sort all lists in the storage what we load dynamically.
It locks better if the lists are sorted.
Also if you have long list it makes working easier.
2016-10-06 08:08:51 +02:00
Dominik Csapak
19e2978be2 use new statusview for storage
to better fit with the rest

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-05 07:00:07 +02:00
Emmanuel Kasper
7e06d55dd6 Minor refactor for #1115 (reload grid after template download)
Move the listener to the new window declaration to make it clear
this listener is not bound to the current component
2016-09-28 17:33:29 +02:00
Emmanuel Kasper
8b97744c78 fix #1115 reload storage grid after template download
Refresh the grid after the template has been downloaded, instead
of refreshing after the template has been selected.

this fix a the problem that a newly Turnkey / PVE downloaded template
would not be shown in the storage content grid after closing the task
window
2016-09-27 10:27:42 +02:00
Dominik Csapak
565a68be99 add onlineHelp to pool and storage
and their options

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 16:42:17 +02:00
Dominik Csapak
772042eaf0 fix #1091: add backup config button to storage contentview
this adds a show config button to the storage contentview
so that you can show the backup configuration from there

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-05 11:20:56 +02:00
Dominik Csapak
4661648a14 drop all hide calls
since we do not use tabpanels anymore,
the hide calls and listeners do nothing,
so we can drop them

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-08-24 12:46:47 +02:00
Dominik Csapak
7ccbcc6c89 reorganize storage and pools
add icons to panels

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-08-24 12:31:22 +02:00
Emmanuel Kasper
ed9896e205 prevent KRDB and Monitor(s) being localized
Both terms are rather domain specific and should not be translated.
See http://pve.proxmox.com/pipermail/pve-devel/2016-July/021975.html
for the problems of Monitor Host being wrongly translated
2016-07-26 14:38:47 +02:00
Dominik Csapak
70e779e47b add HostList validator and check monhosts with it
this adds a vtype which splits the given string into a list by
; or , or space
and checks if it is a valid (hostname|ip) port notation

also make the rbd monhost input field use it

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-07-15 11:53:05 +02:00
Dominik Csapak
91535f2ba7 htmlEncode some comment fields
this adds Ext.String.htmlEncode as renderer
for some comment/description fields

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-06-09 17:40:03 +02:00
Emmanuel Kasper
8c70732ba9 set 'disabled' for grid panels which disaply a read only, not sortable content
* closes the bug #976
 * minor usability improvement: having a clickable row where
 no action was possible is a bit misleading
2016-05-17 12:07:07 +02:00
Dominik Csapak
22f2f9d6c0 jslint: remove trailing commas
before ECMA5 trailing commas in arrays and objects
are forbidden

in jslint this is an error and cannot be deactivated

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:34 +02:00
Dominik Csapak
ec0bd652db jslint: fix type confusion and property access
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}

also fix object['property'] access with
object.property

also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:23 +02:00
Dominik Csapak
5ca0c804c6 remove displayfield height hack
this did not work anymore,
instead overwrite css for displayfields to have correct
min-height

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-06 16:29:35 +02:00
Dietmar Maurer
16152937f8 reduce translation overhead 2016-04-04 16:59:52 +02:00
Dominik Csapak
921324b6e1 use new rrd graphs on storage summary pages
this was missing before
also fix styling error (style takes not a single string parameter)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-31 17:17:40 +02:00
Dominik Csapak
78abe162e4 ext6migrate: remove button height from upload window
since we changed to the crisp theme, the button should
not have a height of 32px

this reverts part of the commit:
5d57889439c5f05afb86b08df076e422520e8381

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-21 14:02:47 +01:00
Dominik Csapak
540fdc8b1e formatting and trailing whitespaces fix
fix format of commit
f2a6ce6cf1
(space before 'load')

also fix trailing whitespaces in those files

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-15 16:31:02 +01:00
Dominik Csapak
3d9bc0a27f ext6migrate: fix trailing whitespaces
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:18:46 +01:00
Dominik Csapak
c90539dead ext6migrate: fix double loadMask
fix the double loadMask, (it exists, because extjs has a default
loadmask for gridpanels)

also move static configuration to class definition

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:17:51 +01:00
Dominik Csapak
f2a6ce6cf1 ext6migrate: fix store load race condition
when we click on a node/container/vm and quickly
click on something else, there might be a race condition,
where the store finished loading and we try to change
dom elements, which are not there anymore

so we change the store.on to me.mon, which
deletes the handler when the component is gone

in the logview panel we use API2Request, where
we cannot do this, so we check if the component
is destroyed manually

also we change this whenever we change a dom element
in a callback

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:16:37 +01:00
Dominik Csapak
6c1a2b8690 disable template/upload button in manager6, fixes #483
also for manager6

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-11 16:29:30 +01:00
Dominik Csapak
177de3de1c ext6migrate: fix trailing whitespaces
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:24:53 +01:00
Dominik Csapak
232c96e0f1 ext6migrate: add Tabs to Storages
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:24:42 +01:00
Dominik Csapak
86cc7049d2 ext6migrate: fix ContentView grouping
the framework triggers the convert function
when you click on a grouping header

since there is no volid there, we have to check this,
otherwise we get an error

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:24:31 +01:00
Dominik Csapak
2a82a5286b ext6migrate: fix zpool storage subject
the correct value is 'zfspool' not 'ZFS Storage'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:24:05 +01:00
Dominik Csapak
e857c94adc ext6migrate: fix StatuView and Summary
we move the static configuration to the class definiton
change applyIf to apply
and change the show event to activate

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:23:47 +01:00
Dominik Csapak
3b422683cf ext6migrate: fix ContentView
we move the static configuration to the class definition
we change the deprecated autoScroll to scrollable
we change applyIf to apply (when appropriate)
we change "new Ext..." to Ext.create
we change the event from show to activate

also we change the button height of the upload to 32
so that it matches the textfield (looks weird otherwise)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:23:36 +01:00
Dominik Csapak
c2317525f0 ext6migrate: fix dropboxes in Storage Edit windows
we fix this by moving the static configuration (especially value and
displayfield) to the class definition

also we remove the scrollbar hack (it works properly now)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:23:20 +01:00
Dominik Csapak
3f90858ace ext6migrate: remove unnecessary array declaration
we do not need the array definition for the alias

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:23:00 +01:00
Dominik Csapak
5198365d53 ext6migrate: change PVE.form.NodeSelector to pveNodeSelector
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-10 17:22:39 +01:00
Dietmar Maurer
6cbcc54638 copy storage/ZFSPoolEdit.js from manager to manager6 2016-03-08 11:22:43 +01:00
Dietmar Maurer
5bf28d898d copy storage/ZFSEdit.js from manager to manager6 2016-03-08 11:22:43 +01:00
Dietmar Maurer
af51679a15 copy storage/Summary.js from manager to manager6 2016-03-08 11:22:43 +01:00
Dietmar Maurer
35795eb72c copy storage/StatusView.js from manager to manager6 2016-03-08 11:22:43 +01:00