Commit Graph

19 Commits

Author SHA1 Message Date
Dominik Csapak
1490ff3d7e use DiskStorageSelector in qemu/Clone.js
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2017-11-14 13:27:03 +01:00
Emmanuel Kasper
67cb91e4d7 Indentation fix 2017-02-28 11:33:51 +01:00
Emmanuel Kasper
f4f9e66296 Make explicit the meaning of an empty storage field
By default when no target storage is selected in the clone panel, the clone
will use the same storage*s* as the source.

This was not obvious to guess that from the panel.
2017-02-28 11:20:30 +01:00
Emmanuel Kasper
4e2b6cc8ee Move the snapshot API test to a static function
This will allow code reuse in a following patch.

No functional change.
2017-02-22 13:54:36 +01:00
Emmanuel Kasper
0057ea5c88 Fix handling of failed API call verifyFeature()
This call can for instance fails when a source VM has references
to non existing storages.
2017-02-22 13:54:35 +01:00
Emmanuel Kasper
22c01a4473 Disable autoSelect of target storage
autoSelect: true  was surreptitiously commited with the refactoring
of 406ac585db
( Use component references via lookupReference() )
2017-01-12 17:00:33 +01:00
Emmanuel Kasper
406ac585db Use component references via lookupReference()
This allows to add the components in each column in the order they
appear in the Clone Window.
References from child components are kept in an object in the parent
component so it should be the same performance-wise (contrary to to Ext.ComponentQuery
which is doing DOM parsing)
2017-01-12 12:26:07 +01:00
Emmanuel Kasper
68a433faff Use qcow2 as default disk format for clones fix: #1144
When using a file based storage, qcow2 has more features as raw,
this is why we recommend it for clones, similarly to when adding
new disk images.
2017-01-12 10:56:02 +01:00
Emmanuel Kasper
1c06db3444 Do not show a Clone Mode selection Window for non-templates clones
As Non-templates clones are always a full clone.
2017-01-12 10:48:29 +01:00
Emmanuel Kasper
364c58460f Group the Pool selector combobox to the VM properties
The pool membership relates here to the VM membership, not
the storage membership, so it makes sense to move it closer
to the VM ID / VM name form fields.
2017-01-12 10:41:47 +01:00
Emmanuel Kasper
2f3c5c38c0 Make the Snapshot selector an optional parameter in the Clone Window
The snapshot selector was known to confuse first time pve users.
Some wondered that they had no snapshot called 'current' in their
snapshot trees, and other thought that snapshots would be included
in the copied image.

So before displaying the Clone Window, do an API call to verify
if the source VM has snapshots.
2017-01-12 10:41:36 +01:00
Emmanuel Kasper
26693bb937 Disable the submit button based on whole form validity
Until now we disabled the submit button, based on
the feature API call where we tested if the selected VM, and its snapshot
can be used as the source of a clone.

This had the following problems:
 * the feature test for copy clone / linked clone always returned true,
 since the passed paramaters were already filtered before user input
 (ie we only allowed a linked clone to be selected if the source VM is
 a template, or a snasphot to be selected if existed on source VM)
 * the guest ID input field was not validated

With the current patch, the validation is now made on each of the form
fields. verifyFeature() is still used to populate a list of valid nodes
passed to the Node Selector.
2017-01-12 10:40:22 +01:00
Emmanuel Kasper
c3dea8fcaa Use correct parameter for GuestIDSelector 2017-01-12 10:38:01 +01:00
Emmanuel Kasper
44494b4c4c Better naming for kv1 comb box, document the two private functions 2017-01-12 10:37:50 +01:00
Dietmar Maurer
ff79a11669 Clone.js: add onlineHelp 2017-01-03 12:30:48 +01:00
Emmanuel Kasper
256a65a4bb reduce scope of jslint warnings to the problematic statement
also remove it from qemu/Clone.js since it validates OK
2016-12-19 07:31:51 +01:00
Emmanuel Kasper
ed416f2024 Convert the VMIDSelector to a generic GuestIDSelector
This allows to display a 'CT', a 'VM', or a 'CT/VM' label
to be displayed, depending on the context.

Currently when restoring a CT backup or creating a CT via the
wizard, we are asked to enter a  *VM* ID, which is confusing.
2016-12-19 07:31:27 +01:00
Dominik Csapak
ca6372bda7 ext6migrate: fix KVCombobox behaviour in qemu
for details see commit:
f2782813cd

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-18 16:08:50 +01:00
Dietmar Maurer
f5226cd9f0 copy qemu/Clone.js from manager to manager6 2016-03-16 09:12:21 +01:00