Commit Graph

5726 Commits

Author SHA1 Message Date
Dominik Csapak
5caadba86f ui: ceph/Status: fix icon in status grid
there was a spurious leftover single quote("'"), that prevented
the correct css class to be inserted
(e.g., fa-exclamation' instead of fa-exclamation)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit c3b2a34528b40d000564c492cc0fd5ce69432c02)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 17:24:36 +02:00
Dominik Csapak
9e75c00ea4 fix #3470: ui: qemu/CmdMenu: fix confirm message for 'pause' cmd
while the command itself is 'suspend', the task description
is 'qmpause', so simply add a parameter and overwrite it for the pause
menu item

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit 9875adb0c789c1e88d19da32d1f16e63595929e9)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 17:22:08 +02:00
Thomas Lamprecht
56142f8c79 pve6to7: re-work output of description length check and add passes too
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 33015eb881f65030a1a2a6ebee57c5891edc6c6f)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 16:49:48 +02:00
Lorenz Stechauner
1be86a3678 pve6to7: add check for guest and node description length
Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
(cherry picked from commit 69677d51f7ac0c671577e70f62d95a0c7aba3e6a)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 16:49:48 +02:00
Thomas Lamprecht
21aa5446b1 pve6to7: bump free space requirement to 4 GiB
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 14:27:00 +02:00
Dominik Csapak
0d08e3e868 ui: fix Guest Summary Notes height
fixes 'infinite' height of the guest notes, by setting the height on the
container a level up

the notes view itself is already scrollable, so if it is too large,
there'll be a scrollbar

this does not change anything for templates, as there we show nothing
under the notes and thus there the infinite height is ok

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit 8530bc4149ee09f149c584870e0c4df5e6066a70)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-18 13:39:19 +02:00
Fabian Grünbichler
d817b52449 pve6to7: use file_get_contents
instead of File::Slurp

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-06-18 10:59:52 +02:00
Fabian Grünbichler
b5f89880eb pve6to7: improve user.cfg parser
make it a bit more like the actual one - remove whitespace padding, use
same regex/split calls.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-06-18 10:54:28 +02:00
Lorenz Stechauner
31e4ad5da2 pve6to7: add check for pool permissions
the two checks make sure that:
* no user defined role 'PVEPoolUser' exists
* the user gets a hint for roles only containing Pool.Allocate and
    not Pool.Audit

a very simple parser for user.cfg was implemented to be able to
parse the (in pve 6 invalid) Pool.Audit permission

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
2021-06-18 10:54:28 +02:00
Fabian Grünbichler
0a47d5a825 d/control: add pve-eslint to b-d
Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-06-16 14:11:04 +02:00
Fabian Ebner
0390b62e01 pve6to7: add check for CIFS credentials
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-06-16 14:04:30 +02:00
Fabian Grünbichler
359334501a pve6to7: improve vzdump.cron check
handle errors, and fix filename referenced in the warning.

Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
2021-06-16 14:04:30 +02:00
Fabian Ebner
440908162e pve6to7: add checks for backup retention options
Note that it's not possible to use read_vzdump_defaults() and storage_config(),
because they auto-converts maxfiles already.

Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
2021-06-16 14:04:30 +02:00
Thomas Lamprecht
ebe48d7e23 ui: TFA: use correct user-id value when creating TOTP QR code
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
(cherry picked from commit 2abc47ae590de83c0ff7a4fcc7abfbe5bb061088)
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-06-10 09:17:40 +02:00
Thomas Lamprecht
300d590b85 bump version to 6.4-8
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-27 14:57:52 +02:00
Thomas Lamprecht
4941b27bff actually install pve6to7 tool
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-27 14:57:52 +02:00
Dominik Csapak
57cbbfa969 ui: form/CalendarEvent: remove displayField from config
in extjs 7.0, setting the displayField overwrites the displayTpl, which
we use here

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
d6ee17e74f ui: tree/SnapshotTree: use beforedestroy instead of destroy
on extjs 7.0, this triggers when the handler is not available anymore,
so use the beforedestroy event instead

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
d040c83a54 ui: panel/ConfigPanel: return early on no selection
treelist technically allows deselection and this happens on destruction
in extjs 7.0 so simply return early to avoid errors accessing
components that do not exist anymore

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
e9e1c7de50 ui: panel/ConfigPanel: change ui class to pve-nav
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
cea4b35f49 ui: ResourceGrid: move first update to afterrender
else with extjs 7.0, the first render does not happen yet, because
the grid is not visible at that time

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Dominik Csapak
22ee5b5c29 ui: form/VMCPUFlagSelector: mark radio-buttons as 'not form fields'
else they might get picked up individually

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-27 12:35:21 +02:00
Thomas Lamprecht
8922a71e26 influxdb: rework comment
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-27 12:32:04 +02:00
Lorenz Stechauner
3343e297fc fix #3440: influxdb: remove duplicate vmid tag
remove vmid from data part, it is already contained in object part.
this is accomplished by adding the parameter $excluded to
build_influxdb_payload().

Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
2021-05-27 12:32:04 +02:00
Dominik Csapak
39fe40d8a2 ui: ResourceGrid: correctly remove ResourceStore listener
while the function in '.on' and '.un' are identical, they are not the
*same* function, thus the '.un' does not really remove the listener,
and we have leftover references to the grid which means it will never
really garbage-collected

instead, use '.mon' on the grid, which automatically cleans up the
listeners

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:38 +02:00
Dominik Csapak
aacfcde0e6 ui: dc/RoleView: add variableRowHeight
otherwise the grid is confused about the row height (since it is
variable here) and renders the scrollbars weirdly

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:38 +02:00
Dominik Csapak
ca2e1752d3 ui: Parser: fix bind and dev mounts for lxc
match returns 'null' if the regex does not match, which is not
destructurable. so we have to save the match and check if it valid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2021-05-20 21:00:37 +02:00
Thomas Lamprecht
1d2413c0ff pve5to6: preparatory steps for when 7 is released
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 19:02:51 +02:00
Thomas Lamprecht
4177a14d13 add pve6to7 WIP
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 19:01:51 +02:00
Thomas Lamprecht
861bf37d54 pveceph install: fix fallback for default version
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 18:25:45 +02:00
Thomas Lamprecht
be0bdb1a11 bump version to 6.4-7
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 17:51:51 +02:00
Thomas Lamprecht
c15d821e0a enable eslint on build
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 17:42:21 +02:00
Thomas Lamprecht
00c3ac53c7 ui: form/storage selector: re-validate after storage list was reloaded
two style fixes thrown in

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
685b52f58c ui: window/Migrate: avoid triggering another info request if already in-progress
use the node as key, so that a target switch would still trigger a
new one - else there's a slight chance that a user could get the
check out-of-sync (from another node).

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
d8d4c14b73 ui: window/Migrate: eslint fixes and code cleanup/refactoring/modernize
Use the Proxmox.Async.api2 helper to avoid deep nesting

Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
cb139584b1 ui: window/Browser Settings: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
75728a889b ui: window/FW Log Rate: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
3fb9e6f9df ui: window/wizard: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
3405edbefb ui: window/ceph install: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
f4eab70a57 ui: window/bulkaction: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
e5d5764668 ui: window/startup: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Thomas Lamprecht
eda300438e ui: snapshot tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 16:52:49 +02:00
Dominic Jäger
90519f8a55 ui: panel/StatusPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
a9e7018401 ui: panel/RunningChart: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
193df2f373 ui: panel/NotesView: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
202298c10b ui: panel/IPSet: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Dominic Jäger
ee3903451e ui: panel/ConfigPanel: eslint fixes
Signed-off-by: Dominic Jäger <d.jaeger@proxmox.com>
2021-05-19 14:03:08 +02:00
Thomas Lamprecht
ff0777c520 ui: resource tree: eslint fixes and code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 14:00:59 +02:00
Thomas Lamprecht
81cde64305 ui: form/pci: add simple IOMMU group renderer
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:30:06 +02:00
Thomas Lamprecht
a7ec3666b1 ui: qemu/PCI Edit: code cleanup/refactoring/modernize
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
2021-05-19 12:29:29 +02:00