when seabios is selected, we do not want to simply
disable the add efi button, because it is not clear
why it is disabled
so we give a meaningful error message instead
the button is still 'just' disabled when there
is already an efidisk, because then it is clear
that you alread have one
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with the reorganizing of the tabs to
the treelist, we forgot to add /firewall to some
urls, making the url for source/destination invalid
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this adds a new button "efi disk" to the
qemu hardware add menu
this is only enabled if the vm has ovmf enabled and
no active efidisk
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this will be used to add an efidisk,
mostly copied from hdedit, but stripped down,
because we do not use most of the functionality here
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we do not use tabpanels anymore,
the hide calls and listeners do nothing,
so we can drop them
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
use new tree functionality of configpanel
move options,monitor,console under hardware (now system)
move firewall subpanels into tree
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
When basic capabilities are missing, don't display the corresponding actions in
the tree menu.
Note that we *hide* the corresponding actions, instead of disabling by greying
out the menu command. Disabling here does not make sense, since a low privilege
user has no way to reenable the menu commands by himself.
This is mainly a usability improvement, as the real capabilities test is done in
the backend.
virtio-blk and virtio-net have been in the kernel since 2.6.25 released in 2008, so
it safe to assume distributions using the l26 type will have these drivers.
this is ExtJS recommended practise, follows most of our
conventions and is necessary for querying
components with Ext.ComponentQuery.query() without escaping the
dots in the component widget name.
we mistakenly sent
'name:'
instead of:
'delete:name'
in case of an empty name of qemu guest
which lead to an error message that it is
not a valid dns name
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since most of the information on the summary page is
irrelevant for templates (e.g. status,ha,using memory,graphs, etc),
we only show just the information which is available and helpful
since we then have the vertical space, we move the notes panel
below the statuspanel, to allow visually more space for the description
(which makes sense for a template)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
it makes more sense to define the padding in context,
rather than directly in the component
especially if we want to use this panel elsewhere in the future
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we cannot create templates with existing snapshots,
and we cannot take snapshots of templates, showing
the tab on templates makes no sense
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
The framework value of 100 is not enough for many of our description
fields.
Setting this at the parent component level allow to remove
the end component setting.
this patch fixes an access to an undefined value
if a disk/cd/network device was pending
also improve how this is displayed:
instead of
****
undefined
new value
****
show just the new value
this occured when having a new disk under pending,
or having a disk removal under pending
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch checks if only the bootdisk changed,
using the multikey funcionality
also use this in the revert button handler,
to revert the bootdisk also
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
before ECMA5 trailing commas in arrays and objects
are forbidden
in jslint this is an error and cannot be deactivated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}
also fix object['property'] access with
object.property
also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
refactor the test for the bootdisk, to make future changes easier,
also, only allow one bootdisk to be selected
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we mistakenly did not reset the originalvalues after the inital
load, which meant that on reset we would not get the correct values
furthermore we have to suspend only the change event and not all,
otherwise the functions for enabling/disabling the ok/reset buttons
do not trigger (on validitychange and dirtychange)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
changed the way the boot order selection behaves:
now when choosing a value which already is chosen elsewhere,
switch them
also when assigning any device as none, move the remaining devices up
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
change the order of the contextmenu items to
group functions, also introducing separators
like this:
***
power options
***
moving options
***
console
***
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
start button should be disabled when suspended
use 'file' icon instead of 'sticky-note'
to be consistent with tree icons
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this patch makes use of font-awesome for
lxc/qemu action buttons (start/shutdown etc.)
node actions buttons (restart/shutdown etc.)
and lxc/qemu cmdmenus
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
uses the new split button for the shutdown action
to reduse the number of buttons, and reduce confusion
also make the stop button 'dangerous'
(shows just a different symbol on the confirm dialog)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
uses the new charts for the rrd graphs in the summary pages
and make them lazy (for minimal performance impact)
also correct some styling errors and move static fields
to the class definition
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
change applyIf to apply, so that the values are changed
and
change activate to show, so that the store starts updating
on site refresh
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since we have a bigger font, instead of
hardcoding the width, let the components generate the
necessary width
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
since KVCombobox expects __default__ as default value
change to this in
DisplayEdit
HDEdit
KeyboardEdit
ProcessorEdit
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the StorageSelector fires the change event one time before data is there,
this patch catches that
also make the hdresize window wider because of the bigger font
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
changes id to itemid
make the snapshot info window a little bigger (for the bigger font)
changes the fireevent from datachanged to refresh
(for details see commit 1cd913372c)
and change show to activate event
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
instead of returning false in the 'beforeitemcollaps'
event (which is not fired in extjs6 anymore)
we set every element as not 'expendable'
this has thei nice side effect that there are no
'-' symbols anymore
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
* uses Ext.apply() instead of applyIf(), because the parent class
already set a toolbar to 'null', and we want to override that
* use 'activate' event to redisplay content on page reload
* use a managed listener via mon() so we ignore events from the store
when the component is not displayed ( prevent race conditions)
* replace scrollable with autoScroll and move to prototype body
* use 'activate' to load store on F5
* do not set a height on the StatusView component: it hides some rows,
and the framework sets a good working default height
* replace deprecated 'rows' parameter in textareafield with
height in pixels
fix format of commit
f2a6ce6cf1
(space before 'load')
also fix trailing whitespaces in those files
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when we click on a node/container/vm and quickly
click on something else, there might be a race condition,
where the store finished loading and we try to change
dom elements, which are not there anymore
so we change the store.on to me.mon, which
deletes the handler when the component is gone
in the logview panel we use API2Request, where
we cannot do this, so we check if the component
is destroyed manually
also we change this whenever we change a dom element
in a callback
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
looks like ExtJS is not automatically flattening the array anymore
and items in a multidimensionnal array are not displayed with ExtJS6
lxc/Config.js is still commented because we haven't reached this part
in the upgrade, but fixing there too