before ECMA5 trailing commas in arrays and objects
are forbidden
in jslint this is an error and cannot be deactivated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}
also fix object['property'] access with
object.property
also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
when switching from one node to another, we stop the wrong store
for the ceph tabs disk/monitor/pools because they have the same id,
so give them different ones
also the same applies for node/Services, fix it there too
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
make following (sub)tabs lazy:
* ceph
* firewall
* ha
* search
* lxc/Resources
we have to add layout: 'fit', whereever we make a whole tab lazy
and we have to move the title of the search tab to the instantiaton
instead of the class definition, because the search grid is now a
sub component instead of a tab
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the subpanelconfig class was modeled after the ceph config class
but the ceph config was never changed to use that subclass
this patch changes that
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
the usual:
* move static conf. to class definition
* change "show" event to "activate"
special attention here to the bufferedRenderer: false value here:
if the grid panel has bufferedRenderer: true (default) and the
store is our Diffstore, it adds the Summary Row twice, once before
the store is loaded and once after.
because there probably will not be many pools in a ceph configuration
managed by the gui, we can safely deactivate bufferedRenderer
(according to extjs documentation, this is intended for gridpanels
with several thousand rows, which is not an issue with ceph pools
i think)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
* moved static configuration to class definition
* changed the width of the headers (because most were too small)
* changed "show" event to "activate"
special attention for the data fields:
changed the id from type integer to default type, because
extjs cannot convert form integer for this field
(if we do not do this, the whole ceph tab breaks)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this fixed the ceph subtabs: Status,Config,Crush,Disks,Monitor
with the usual fixes:
* moving static configuration to class definition
* change deprecated fields
* make xtypes consistent
* change "show" event to "activated"
special note: i moved the subtabs to the left (like the firewall),
because the alternatives are really bad (top looks not good, bottom
is not obvious)
i also changed the width of some headers in gridpanels when the
title was too long
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>