Commit Graph

63 Commits

Author SHA1 Message Date
Emmanuel Kasper
b9628aa501 Do not translate IT terms which should be used 'as is' in every language
for 'Initialize GPT' we use the alternate 'Initialize Disk with GPT' string
which was already existing
2017-03-02 10:39:41 +01:00
Emmanuel Kasper
d5e771ce51 Rename 'create' to 'isCreate' in pveWindowEdit and subclasses
This fixes around 20 jslint type confusion warnings.
Also reduce the scope and document jslint warnings along the way.
No functional changes.
2017-03-02 10:36:35 +01:00
Emmanuel Kasper
0a3cf3d482 Use the enabled/disabled toggler to render grid options
Allows getting rid of multiple "Enable foobar" gettext strings in
LXC and Firewall option panels.
2017-01-24 08:54:58 +01:00
Emmanuel Kasper
e83e60bfa1 Reload the grid list of backups after the backup task completion
This allows visual feedback for first time users doing a backup.
2017-01-05 16:17:32 +01:00
Emmanuel Kasper
8dfd00cd09 Fix a race conditon provoking the error no such file '/pve-storage-content'
(NB: the error was only displayed intermittently in the browser console)

The reload call could try a store reload before the store has
a defined url.
The call here is useless since the initial display of
the storage selector compoment will call setStorage() to pass an url
to the store and load it.

Also remove the test on me.store.proxy.url since it was not working
(ExtJS autodefined an URL based on the model name)
2017-01-03 11:00:19 +01:00
Dominik Csapak
cc751ecd73 move hideHeaders into static configuration
in extjs 6.2, this property will not be set in ApplyIf, so we move it
into the static configuration, so that the headers will not be visible

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-12-19 12:02:53 +01:00
Emmanuel Kasper
2685b38224 Rename filterFn to vmtypeFilter
since we have now two filters defined it makes sense to use
a separate name here
2016-12-19 11:37:20 +01:00
Emmanuel Kasper
ce76a18ae0 Filter by default the displayed guest backups fix #1161
This add a default filter which is executed on store initial load,
so we display only the backups matching our ID.
2016-12-19 11:36:51 +01:00
Dominik Csapak
07a3397f4e make pool members grid stateful
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-18 10:21:37 +01:00
Dominik Csapak
9a8119659f move onlineHelp from FirewallAliasEdit to FirewallAliases
since the first is a window, not the grid

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:17:38 +01:00
Dominik Csapak
a61607a85a make backupview stateful
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:16:52 +01:00
Dominik Csapak
123e1c808e make firewall panels/grids stateful
to save the columns/layouts in the browsers local storage

also change width to string (or else jslint complains)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:16:23 +01:00
Dominik Csapak
ac419eb9a2 remove reset columns button from resource grid
since we now have the client settings, we do not need this anymore

also rename the stateid to 'grid-resource'
(we want to establish a convention to differentiate between saved local
storage items)

the whole saveCurrentState logic was not really necessary, so we can drop this too

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-17 09:16:07 +01:00
Dominik Csapak
03375edf97 disable rules copy button if not 'in' or 'out' rule
else you could always click the button, but
nothing would happen

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-10 10:01:57 +01:00
Dominik Csapak
8a7e5598f1 add pveIntegerField and use it
this adds a subclass of Ext.form.field.Number with the settings for
Integers (allowDecimals: false and allowExponential: false and default
step size 1)

and use it where we only accept integers

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:14:06 +01:00
Dominik Csapak
ba93a9c665 move onlineHelp into classes from definition
this patch moves the onlineHelp ids into the javascript classes, instead
of defining them where we use the classes

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-11-02 17:13:12 +01:00
Dominik Csapak
5eff07f74c grid/FirewallRules.js jslint fixes
trailing commas are bad

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-10-07 08:34:41 +02:00
Wolfgang Link
330020d2af fix #1108: add copy firewall rule to GUI
It is now possible to select a firewall rule on the GUI
and copy it as template for the new rule.
2016-10-05 07:06:51 +02:00
Dominik Csapak
f118971daf use renamed alias for xtype
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-13 07:47:34 +02:00
Dominik Csapak
6da4aea874 refactor backupconfig window
refactor it in its own class, because we need it again

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-09-05 11:20:41 +02:00
Dominik Csapak
fc349cb69a make content of configuration window a component
otherwise, the styling does not apply

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-06-29 14:32:36 +02:00
Dominik Csapak
79f305de0d add configuration button to backups
this adds a button to show the configuration of backups

this helps if someone wants to know the details of the
vm in the backup (e.g. name, storages, etc.)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-06-16 16:35:13 +02:00
Dominik Csapak
91535f2ba7 htmlEncode some comment fields
this adds Ext.String.htmlEncode as renderer
for some comment/description fields

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-06-09 17:40:03 +02:00
Dominik Csapak
685b7aa4c5 move cmdmenu function and use it in poolmemberlist
we had the function for the cmdmenu at two
different places (resourcetree and resourcegrid)

move it to PVE.Utils to reuse code, and
also use it in pool members list

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-05-20 07:30:21 +02:00
Emmanuel Kasper
8c70732ba9 set 'disabled' for grid panels which disaply a read only, not sortable content
* closes the bug #976
 * minor usability improvement: having a clickable row where
 no action was possible is a bit misleading
2016-05-17 12:07:07 +02:00
Emmanuel Kasper
3c813f7416 Enlarge Object Grid first column default size
The framework value of 100 is not enough for many of our description
fields.
Setting this at the parent component level allow to remove
the end component setting.
2016-05-17 11:33:34 +02:00
Dominik Csapak
25e0bc2d9d improve pending changes for qemu hardware in gui
this patch fixes an access to an undefined value
if a disk/cd/network device was pending

also improve how this is displayed:
instead of
****
undefined
new value
****

show just the new value

this occured when having a new disk under pending,
or having a disk removal under pending

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-05-03 11:24:47 +02:00
Dominik Csapak
7c7ae44f25 jslint: fix tab/space mixed intendation
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:09:44 +02:00
Dominik Csapak
a764c5f72e jslint: fix missing or extra semicolon
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:07:42 +02:00
Dominik Csapak
22f2f9d6c0 jslint: remove trailing commas
before ECMA5 trailing commas in arrays and objects
are forbidden

in jslint this is an error and cannot be deactivated

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:34 +02:00
Dominik Csapak
ec0bd652db jslint: fix type confusion and property access
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}

also fix object['property'] access with
object.property

also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-29 17:06:23 +02:00
Dominik Csapak
df6345f9ba fix #759: save columns of resourceGrid
with this patch, the resourceGrid saves its state when
the columns are changed (resized, sorted, etc.)

also add a little reset button to the toolbar

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-20 09:40:59 +02:00
Dominik Csapak
5ca0c804c6 remove displayfield height hack
this did not work anymore,
instead overwrite css for displayfields to have correct
min-height

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-06 16:29:35 +02:00
Dominik Csapak
b9722f5292 prevent contextmenu on lxc templates
since we do not support lxc templates on the gui yet,
prepare the correct contextmenu call, but comment it out

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-05 15:34:40 +02:00
Dietmar Maurer
16152937f8 reduce translation overhead 2016-04-04 16:59:52 +02:00
Dominik Csapak
4dce154f87 remove unneccesary title and border
since the 'search' panel is now a subcomponent of a tab,
the title here shows a redundant title bar, and we have
an unwanted border

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-04-01 09:06:59 +02:00
Dominik Csapak
5c41645953 filter backup always by vm type
currently, as soon as you type something in the backup search bar,
the filter for the vm type (e.g. lxc or qemu) gets cleared, and
you see *all* backups (also those not for the current type)

this patch adds the original filterFn to the filter when searching

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-21 14:02:29 +01:00
Emmanuel Kasper
fbe1b520b3 replace calls to new() with Ext.create() 2016-03-17 10:44:48 +01:00
Emmanuel Kasper
c5b0115067 initialize Diffstore sorters and filters with empty arrays
ExtJS expect this properties to be arrays of Filters/Sorters
objects, but sets them to null

setting an empty array here allows to push sorters/filters easily
later

This fix allows loading the Hardware Tab of the Qemu Panel
2016-03-17 10:44:39 +01:00
Emmanuel Kasper
69c635d770 fix delayed store loading
Because the store loading delay, it can be that reload() fails on trying to
load an undefined store, if the user switched tabs in the meantime
2016-03-15 16:33:49 +01:00
Dominik Csapak
8dc0c04951 ext6migrate: change VM selector in pool to grid
this changes the vm add window in a pool
from a VMIDSelector (a numberfield)
to a grid of vms which are currently in no pool
where you can select more than one

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-15 16:31:14 +01:00
Dominik Csapak
3d9bc0a27f ext6migrate: fix trailing whitespaces
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:18:46 +01:00
Dominik Csapak
1928545b8d ext6migrate: fix pool member view
change show event to activate

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-14 17:18:34 +01:00
Wolfgang Bumiller
9eef71f36e firewall: add ipfilter option 2016-03-03 09:45:33 +01:00
Dominik Csapak
bc5d0cf8db ext6migrate: change applyIf to apply
in the option view, change the applyIf to apply to
correctly show the 'Edit' button

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-03-02 06:13:16 +01:00
Wolfgang Bumiller
41380b4d5d firewall: add option to allow router advertisement 2016-02-27 10:26:31 +01:00
Emmanuel Kasper
636247e253 Add documentation header for ObjectGrid.js
also enhance the documentation header for DiffStore and UpdateStore
2016-02-24 11:05:22 +01:00
Dominik Csapak
2eb0767b3c add htmlEncode to various fields
and the same for manager6

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
2016-02-20 09:48:23 +01:00
Wolfgang Bumiller
bda8855a5b firewall: add enable ndp option 2016-02-19 10:10:51 +01:00
Emmanuel Kasper
7a3691ac08 use 'refresh' event to reload the grid after filtering the store
'datachanged' event was not reloading the store with ExtJS5,
but 'refresh' does.
According to the API description 'refresh' seems to be what we need:
http://docs.sencha.com/extjs/5.1/5.1.0-apidocs/#!/api/Ext.data.AbstractStore-event-refresh

also remove deprecated readme ( ExtJS6 do not have the 'chunking' Grid Feature, and no bugs
seen in scrolling yet)
2016-02-17 12:06:14 +01:00