by default, extjs submits the language dependent decimal separator,
e.g. ',' for german and '.' for english
but we always want '.'
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
(cherry picked from commit 5c660b6d1302a5fbb3dcf477cf8b5adc9f798530)
the error messages for several input fields (e.g. snapshot name)
did not correctly reflect the regex which was checked
this patch adds additional information about the required format
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
we have cases, were the original value of a combobox is an array,
but not the current value
on reset, we get an error in Ext.Array.equals, because we
did not check if the current value is also an array
this patch fixes this
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
this adds a vtype which splits the given string into a list by
; or , or space
and checks if it is a valid (hostname|ip) port notation
also make the rbd monhost input field use it
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
on comboboxes/combogrids with multiselect,
if you deselect an item (but not the last),
the order of the selected items after resetting is
not the same as the original order
because of this, the reset button is still enabled
this happens, because extjs only adds the missing
values instead of overwriting the whole array
with this fix, we overwrite the reset function of
the comboboxes and only if the values do not match
(after a reset) do we clear and set the value again
so we only change the behaviour when it is necessary
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
jslint does not like names that begin with _
also it complains when you do not filter
a for in statement with a hasOwnProperty(property) as first
if statement
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
before ECMA5 trailing commas in arrays and objects
are forbidden
in jslint this is an error and cannot be deactivated
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
fix various type confusion, for example:
items: {} and items: []
style: string and style: {}
also fix object['property'] access with
object.property
also fix /=/ with either '=' or /\=/ where appropriate
(/=/ can be confused with /= according to jslint)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
with this fix, we (again) allow ipv4 cidr to be as low as 8
also check the cidr for ipv6 and show the valid ranges in the
error text
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
Witouth this we can get into issues where only the picker is visible
and the rest of the GUI is completely grey when selecting a date
with the date picker, generally this happens when a scroll field is
involved (e.g., syslog).
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
in extjs 5/6 there is a caching issue, where they
save dom elements for reuse, but the garbage collector
can set them to null
when the framework now reuses the "cached" element it is null,
and any action on it produces an error, which breaks the site
for details see the forum link in the comment
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
